Roberto Ostinelli 8 лет назад
Родитель
Сommit
b5ce888443
4 измененных файлов с 34 добавлено и 36 удалено
  1. 1 1
      README.md
  2. 8 8
      src/syn.erl
  3. 16 18
      test/syn_registry_SUITE.erl
  4. 9 9
      test/syn_test_gen_server.erl

+ 1 - 1
README.md

@@ -146,7 +146,7 @@ Types:
 > You may re-register a process multiple times, for example if you need to update its metadata.
 > When a process gets registered, Syn will automatically monitor it.
 
-Processes can also be registered as gen_server names, by usage of via-tuples.
+Processes can also be registered as `gen_server` names, by usage of via-tuples.
 This way, you can use the gen_server API with these tuples without referring to the Pid directly.
 
 ```erlang

+ 8 - 8
src/syn.erl

@@ -107,17 +107,17 @@ registry_count(Node) ->
 -spec register_name(Name :: term(), Pid :: pid()) -> 'yes' | 'no'.
 register_name(Name, Pid) when is_pid(Pid) ->
     case syn_registry:register(Name, Pid) of
-      ok -> yes;
-      {error, _} -> no;
-      _ -> no
+        ok -> yes;
+        {error, _} -> no;
+        _ -> no
     end.
 
 -spec unregister_name(Name :: term()) -> _.
 unregister_name(Name) ->
     case syn_registry:unregister(Name) of
-      ok -> Name;
-      {error, _} -> nil;
-      _ -> nil
+        ok -> Name;
+        {error, _} -> nil;
+        _ -> nil
     end.
 
 -spec whereis_name(Name :: term()) -> pid() | 'undefined'.
@@ -126,8 +126,8 @@ whereis_name(Name) -> syn_registry:find_by_key(Name).
 -spec send(Name :: term(), Message :: term()) -> pid().
 send(Name, Message) ->
     case whereis_name(Name) of
-      undefined -> {badarg, {Name, Message}};
-      Pid -> Pid ! Message, Pid
+        undefined -> {badarg, {Name, Message}};
+        Pid -> Pid ! Message, Pid
     end.
 
 -spec join(Name :: any(), Pid :: pid()) -> ok.

+ 16 - 18
test/syn_registry_SUITE.erl

@@ -224,28 +224,26 @@ single_node_when_mnesia_is_ram_with_gen_server_name(_Config) ->
     call_received = gen_server:call({via, syn, <<"my proc">>}, message_is_ignored),
     %% gen_server cast messages
     gen_server:cast({via, syn, <<"my proc">>}, message_is_ignored),
-    ok =
-        receive
-            cast_received -> ok
-        after
-            100 -> error
-        end,
+    ok = receive
+        cast_received -> ok
+    after
+        1000 -> error_receiving_cast_message
+    end,
     %% any other message
     syn:send(<<"my proc">>, message_is_ignored),
-    ok =
-        receive
-            info_received -> ok
-        after
-            100 -> error
-        end,
+    ok = receive
+        info_received -> ok
+    after
+        1000 -> error_receiving_info_message
+    end,
     %% stop process
     syn_test_gen_server:stop({via, syn, <<"my proc">>}),
-    ok =
-        receive
-            stop_received -> ok
-        after
-            100 -> error
-        end,
+    ok = receive
+        stop_received -> ok
+    after
+        1000 -> error_stopping_process
+    end,
+    %% wait for process to exit
     timer:sleep(100),
     %% retrieve
     undefined = syn:find_by_key(<<"my proc">>).

+ 9 - 9
test/syn_test_gen_server.erl

@@ -24,19 +24,19 @@
 %% THE SOFTWARE.
 %% ==========================================================================================================
 -module(syn_test_gen_server).
-
 -behaviour(gen_server).
 
--export([start_link/2,
-         stop/1]).
+-export([start_link/2, stop/1]).
 
 %% gen_server callbacks
--export([init/1,
-         handle_call/3,
-         handle_cast/2,
-         handle_info/2,
-         terminate/2,
-         code_change/3]).
+-export([
+    init/1,
+    handle_call/3,
+    handle_cast/2,
+    handle_info/2,
+    terminate/2,
+    code_change/3
+]).
 
 start_link(Parent, Name) ->
     gen_server:start_link(Name, ?MODULE, Parent, []).