cleanup

src/kvs_acl.erl

@@ -5,8 +5,6 @@
 -include("metainfo.hrl").
 -include("acl.hrl").
 -include("user.hrl").
--include("group.hrl").
--include("feed.hrl").
 
 metainfo() ->
     #schema{name=kvs,tables=[

src/kvs_feed.erl

@@ -1,19 +1,20 @@
 -module(kvs_feed).
 -copyright('Synrc Research Center, s.r.o.').
 -compile(export_all).
+-include("kvs.hrl").
 -include("config.hrl").
 -include("entry.hrl").
 -include("comment.hrl").
 -include("feed.hrl").
 -include("metainfo.hrl").
--include("kvs.hrl").
 
-metainfo() ->
-    #schema{name=kvs,tables=[
-        #table{name=entry,container=true,fields=record_info(fields,entry)},
-        #table{name=config,fields=record_info(fields,config)},
-        #table{name=log,container=true,fields=record_info(fields,log)},
-        #table{name=operation,container=log,fields=record_info(fields,operation)},
-        #table{name=comment,container=true,fields=record_info(fields,comment)},
-        #table{name=feed,container=true,fields=record_info(fields,feed)}
-    ]}.
+metainfo() ->  #schema{name=kvs,tables= core() ++ feeds() }.
+
+core()     -> [ #table{name=config,fields=record_info(fields,config)},
+                #table{name=log,container=true,fields=record_info(fields,log)},
+                #table{name=operation,container=log,fields=record_info(fields,operation)},
+                #table{name=id_seq,fields=record_info(fields,id_seq),keys=[thing]} ].
+
+feeds()    -> [ #table{name=entry,container=true,fields=record_info(fields,entry)},
+                #table{name=comment,container=true,fields=record_info(fields,comment)},
+                #table{name=feed,container=true,fields=record_info(fields,feed)} ].

src/kvs_subscription.erl

@@ -1,14 +1,12 @@
 -module(kvs_subscription).
 -copyright('Synrc Research Center s.r.o.').
 -include("subscription.hrl").
--include("user.hrl").
 -include("metainfo.hrl").
 -compile(export_all).
 
 metainfo() ->
     #schema{name=kvs,tables=[
-        #table{name=subscription,fields=record_info(fields,subscription),keys=[id,whom,who]},
-        #table{name=id_seq,fields=record_info(fields,id_seq),keys=[thing]}
+        #table{name=subscription,fields=record_info(fields,subscription),keys=[id,whom,who]}
     ]}.
 
 subscribe(Who, Whom) -> kvs:put(#subscription{key={Who,Whom},who = Who, whom = Whom}).
@@ -17,7 +15,6 @@ unsubscribe(Who, Whom) ->
         true  -> kvs:delete(subscription, {Who, Whom});
         false -> skip end.
 
-subscriptions(#user{username = UId}) -> subscriptions(UId);
 subscriptions(UId) -> kvs:index(subscription, who, UId).
 subscribed(Who) -> kvs:index(subscription, whom, Who).
 subscribed(Who, Whom) ->

src/kvs_sup.erl

@@ -1,11 +1,6 @@
 -module(kvs_sup).
 -behaviour(supervisor).
--export([start_link/0]).
--export([init/1]).
--define(CHILD(I, Type), {I, {I, start_link, []}, permanent, 5000, Type, [I]}).
+-export([init/1, start_link/0]).
 
 start_link() -> supervisor:start_link({local, ?MODULE}, ?MODULE, []).
-
-init([]) ->
-
-    {ok, { {one_for_one, 5, 10}, []} }.
+init([])     -> {ok, { {one_for_one, 5, 10}, []} }.

src/kvs_user.erl

@@ -2,7 +2,6 @@
 -copyright('Synrc Research Center s.r.o.').
 -include("user.hrl").
 -include("group.hrl").
--include("config.hrl").
 -include("metainfo.hrl").
 -compile(export_all).