Browse Source

Use verify_in_constant_time in plaintext signature verification

Tim Fletcher 13 years ago
parent
commit
72f7a87808
1 changed files with 1 additions and 1 deletions
  1. 1 1
      src/oauth.erl

+ 1 - 1
src/oauth.erl

@@ -113,7 +113,7 @@ plaintext_signature(Consumer, TokenSecret) ->
   uri_join([consumer_secret(Consumer), TokenSecret]).
   uri_join([consumer_secret(Consumer), TokenSecret]).
 
 
 plaintext_verify(Signature, Consumer, TokenSecret) ->
 plaintext_verify(Signature, Consumer, TokenSecret) ->
-  Signature =:= plaintext_signature(Consumer, TokenSecret).
+  verify_in_constant_time(Signature, plaintext_signature(Consumer, TokenSecret)).
 
 
 hmac_sha1_signature(HttpMethod, URL, Params, Consumer, TokenSecret) ->
 hmac_sha1_signature(HttpMethod, URL, Params, Consumer, TokenSecret) ->
   BaseString = signature_base_string(HttpMethod, URL, Params),
   BaseString = signature_base_string(HttpMethod, URL, Params),