Browse Source

Remove a few old @todo comments

Loïc Hoguin 12 years ago
parent
commit
09c68ca755
2 changed files with 0 additions and 8 deletions
  1. 0 2
      src/cowboy_req.erl
  2. 0 6
      src/cowboy_rest.erl

+ 0 - 2
src/cowboy_req.erl

@@ -728,7 +728,6 @@ skip_body(Req) ->
 
 %% @doc Return the full body sent with the request, parsed as an
 %% application/x-www-form-urlencoded string. Essentially a POST query string.
-%% @todo We need an option to limit the size of the body for QS too.
 -spec body_qs(Req)
 	-> {ok, [{binary(), binary() | true}], Req} | {error, atom()}
 	when Req::req().
@@ -765,7 +764,6 @@ multipart_data(Req=#http_req{multipart={Length, Cont}}) ->
 multipart_data(Req=#http_req{body_state=done}) ->
 	{eof, Req}.
 
-%% @todo Typespecs.
 multipart_data(Req, Length, {headers, Headers, Cont}) ->
 	{headers, Headers, Req#http_req{multipart={Length, Cont}}};
 multipart_data(Req, Length, {body, Data, Cont}) ->

+ 0 - 6
src/cowboy_rest.erl

@@ -846,12 +846,6 @@ generate_etag(Req, State=#state{etag=undefined}) ->
 	case call(Req, State, generate_etag) of
 		no_call ->
 			{undefined, Req, State#state{etag=no_call}};
-		%% Previously the return value from the generate_etag/2 callback was set
-		%% as the value of the ETag header in the response. Therefore the only
-		%% valid return type was `binary()'. If a handler returns a `binary()'
-		%% it must be mapped to the expected type or it'll always fail to
-		%% compare equal to any entity tags present in the request headers.
-		%% @todo Remove support for binary return values after 0.6.
 		{Etag, Req2, HandlerState} when is_binary(Etag) ->
 			[Etag2] = cowboy_http:entity_tag_match(Etag),
 			{Etag2, Req2, State#state{handler_state=HandlerState, etag=Etag2}};