test_thread_editreply_api.py 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530
  1. # -*- coding: utf-8 -*-
  2. from __future__ import unicode_literals
  3. from datetime import timedelta
  4. from django.test.client import BOUNDARY, MULTIPART_CONTENT, encode_multipart
  5. from django.urls import reverse
  6. from django.utils import timezone
  7. from misago.acl.testutils import override_acl
  8. from misago.categories.models import Category
  9. from misago.threads import testutils
  10. from misago.threads.models import Post, Thread
  11. from misago.users.testutils import AuthenticatedUserTestCase
  12. class EditReplyTests(AuthenticatedUserTestCase):
  13. def setUp(self):
  14. super(EditReplyTests, self).setUp()
  15. self.category = Category.objects.get(slug='first-category')
  16. self.thread = testutils.post_thread(category=self.category)
  17. self.post = testutils.reply_thread(self.thread, poster=self.user)
  18. self.api_link = reverse(
  19. 'misago:api:thread-post-detail',
  20. kwargs={
  21. 'thread_pk': self.thread.pk,
  22. 'pk': self.post.pk,
  23. }
  24. )
  25. def override_acl(self, extra_acl=None):
  26. new_acl = self.user.acl_cache
  27. new_acl['categories'][self.category.pk].update({
  28. 'can_see': 1,
  29. 'can_browse': 1,
  30. 'can_start_threads': 0,
  31. 'can_reply_threads': 0,
  32. 'can_edit_posts': 1,
  33. })
  34. if extra_acl:
  35. new_acl['categories'][self.category.pk].update(extra_acl)
  36. override_acl(self.user, new_acl)
  37. def put(self, url, data=None):
  38. content = encode_multipart(BOUNDARY, data or {})
  39. return self.client.put(url, content, content_type=MULTIPART_CONTENT)
  40. def test_cant_edit_reply_as_guest(self):
  41. """user has to be authenticated to be able to edit reply"""
  42. self.logout_user()
  43. response = self.put(self.api_link)
  44. self.assertEqual(response.status_code, 403)
  45. def test_thread_visibility(self):
  46. """thread's visibility is validated"""
  47. self.override_acl({'can_see': 0})
  48. response = self.put(self.api_link)
  49. self.assertEqual(response.status_code, 404)
  50. self.override_acl({'can_browse': 0})
  51. response = self.put(self.api_link)
  52. self.assertEqual(response.status_code, 404)
  53. self.override_acl({'can_see_all_threads': 0})
  54. response = self.put(self.api_link)
  55. self.assertEqual(response.status_code, 404)
  56. def test_cant_edit_reply(self):
  57. """permission to edit reply is validated"""
  58. self.override_acl({'can_edit_posts': 0})
  59. response = self.put(self.api_link)
  60. self.assertContains(response, "You can't edit posts in this category.", status_code=403)
  61. def test_cant_edit_other_user_reply(self):
  62. """permission to edit reply by other users is validated"""
  63. self.override_acl({'can_edit_posts': 1})
  64. self.post.poster = None
  65. self.post.save()
  66. response = self.put(self.api_link)
  67. self.assertContains(
  68. response, "You can't edit other users posts in this category.", status_code=403
  69. )
  70. def test_edit_too_old(self):
  71. """permission to edit reply within timelimit is validated"""
  72. self.override_acl({
  73. 'can_edit_posts': 1,
  74. 'post_edit_time': 1,
  75. })
  76. self.post.posted_on = timezone.now() - timedelta(minutes=5)
  77. self.post.save()
  78. response = self.put(self.api_link)
  79. self.assertContains(
  80. response, "You can't edit posts that are older than 1 minute.", status_code=403
  81. )
  82. def test_closed_category(self):
  83. """permssion to edit reply in closed category is validated"""
  84. self.override_acl({'can_close_threads': 0})
  85. self.category.is_closed = True
  86. self.category.save()
  87. response = self.put(self.api_link)
  88. self.assertContains(
  89. response, "This category is closed. You can't edit posts in it.", status_code=403
  90. )
  91. # allow to post in closed category
  92. self.override_acl({'can_close_threads': 1})
  93. response = self.put(self.api_link)
  94. self.assertEqual(response.status_code, 400)
  95. def test_closed_thread(self):
  96. """permssion to edit reply in closed thread is validated"""
  97. self.override_acl({'can_close_threads': 0})
  98. self.thread.is_closed = True
  99. self.thread.save()
  100. response = self.put(self.api_link)
  101. self.assertContains(
  102. response, "This thread is closed. You can't edit posts in it.", status_code=403
  103. )
  104. # allow to post in closed thread
  105. self.override_acl({'can_close_threads': 1})
  106. response = self.put(self.api_link)
  107. self.assertEqual(response.status_code, 400)
  108. def test_protected_post(self):
  109. """permssion to edit protected post is validated"""
  110. self.override_acl({'can_protect_posts': 0})
  111. self.post.is_protected = True
  112. self.post.save()
  113. response = self.put(self.api_link)
  114. self.assertContains(
  115. response, "This post is protected. You can't edit it.", status_code=403
  116. )
  117. # allow to post in closed thread
  118. self.override_acl({'can_protect_posts': 1})
  119. response = self.put(self.api_link)
  120. self.assertEqual(response.status_code, 400)
  121. def test_empty_data(self):
  122. """no data sent handling has no showstoppers"""
  123. self.override_acl()
  124. response = self.put(self.api_link, data={})
  125. self.assertContains(response, "You have to enter a message.", status_code=400)
  126. def test_invalid_data(self):
  127. """api errors for invalid request data"""
  128. self.override_acl()
  129. response = self.client.put(
  130. self.api_link,
  131. 'false',
  132. content_type="application/json",
  133. )
  134. self.assertContains(response, "Invalid data.", status_code=400)
  135. def test_edit_event(self):
  136. """events can't be edited"""
  137. self.override_acl()
  138. self.post.is_event = True
  139. self.post.save()
  140. response = self.put(self.api_link, data={})
  141. self.assertContains(response, "Events can't be edited.", status_code=403)
  142. def test_post_is_validated(self):
  143. """post is validated"""
  144. self.override_acl()
  145. response = self.put(
  146. self.api_link, data={
  147. 'post': "a",
  148. }
  149. )
  150. self.assertEqual(response.status_code, 400)
  151. self.assertEqual(
  152. response.json(), {
  153. 'post': ["Posted message should be at least 5 characters long (it has 1)."],
  154. }
  155. )
  156. def test_edit_reply_no_change(self):
  157. """endpoint isn't bumping edits count if no change was made to post's body"""
  158. self.override_acl()
  159. self.assertEqual(self.post.edits_record.count(), 0)
  160. response = self.put(self.api_link, data={'post': self.post.original})
  161. self.assertEqual(response.status_code, 200)
  162. self.override_acl()
  163. response = self.client.get(self.thread.get_absolute_url())
  164. self.assertContains(response, self.post.parsed)
  165. post = self.thread.post_set.order_by('id').last()
  166. self.assertEqual(post.edits, 0)
  167. self.assertEqual(post.original, self.post.original)
  168. self.assertIsNone(post.last_editor_id, self.user.id)
  169. self.assertIsNone(post.last_editor_name, self.user.username)
  170. self.assertIsNone(post.last_editor_slug, self.user.slug)
  171. self.assertEqual(self.post.edits_record.count(), 0)
  172. def test_edit_reply(self):
  173. """endpoint updates reply"""
  174. self.override_acl()
  175. self.assertEqual(self.post.edits_record.count(), 0)
  176. response = self.put(self.api_link, data={'post': "This is test edit!"})
  177. self.assertEqual(response.status_code, 200)
  178. self.override_acl()
  179. response = self.client.get(self.thread.get_absolute_url())
  180. self.assertContains(response, "<p>This is test edit!</p>")
  181. self.assertEqual(self.user.audittrail_set.count(), 1)
  182. post = self.thread.post_set.order_by('id').last()
  183. self.assertEqual(post.edits, 1)
  184. self.assertEqual(post.original, "This is test edit!")
  185. self.assertEqual(post.last_editor_id, self.user.id)
  186. self.assertEqual(post.last_editor_name, self.user.username)
  187. self.assertEqual(post.last_editor_slug, self.user.slug)
  188. self.assertEqual(self.post.edits_record.count(), 1)
  189. post_edit = post.edits_record.last()
  190. self.assertEqual(post_edit.edited_from, self.post.original)
  191. self.assertEqual(post_edit.edited_to, post.original)
  192. self.assertEqual(post_edit.editor_id, self.user.id)
  193. self.assertEqual(post_edit.editor_name, self.user.username)
  194. self.assertEqual(post_edit.editor_slug, self.user.slug)
  195. def test_edit_first_post_hidden(self):
  196. """endpoint updates hidden thread's first post"""
  197. self.override_acl({'can_hide_threads': 1, 'can_edit_posts': 2})
  198. self.thread.is_hidden = True
  199. self.thread.save()
  200. self.thread.first_post.is_hidden = True
  201. self.thread.first_post.save()
  202. api_link = reverse(
  203. 'misago:api:thread-post-detail',
  204. kwargs={
  205. 'thread_pk': self.thread.pk,
  206. 'pk': self.thread.first_post.pk,
  207. }
  208. )
  209. response = self.put(api_link, data={'post': "This is test edit!"})
  210. self.assertEqual(response.status_code, 200)
  211. def test_protect_post(self):
  212. """can protect post"""
  213. self.override_acl({'can_protect_posts': 1})
  214. response = self.put(
  215. self.api_link, data={
  216. 'post': "Lorem ipsum dolor met!",
  217. 'protect': 1,
  218. }
  219. )
  220. self.assertEqual(response.status_code, 200)
  221. post = self.user.post_set.order_by('id').last()
  222. self.assertTrue(post.is_protected)
  223. def test_protect_post_no_permission(self):
  224. """cant protect post without permission"""
  225. self.override_acl({'can_protect_posts': 0})
  226. response = self.put(
  227. self.api_link, data={
  228. 'post': "Lorem ipsum dolor met!",
  229. 'protect': 1,
  230. }
  231. )
  232. self.assertEqual(response.status_code, 200)
  233. post = self.user.post_set.order_by('id').last()
  234. self.assertFalse(post.is_protected)
  235. def test_post_unicode(self):
  236. """unicode characters can be posted"""
  237. self.override_acl()
  238. response = self.put(
  239. self.api_link, data={
  240. 'post': "Chrzążczyżewoszyce, powiat Łękółody.",
  241. }
  242. )
  243. self.assertEqual(response.status_code, 200)
  244. def test_reply_category_moderation_queue(self):
  245. """edit sends reply to queue due to category setup"""
  246. self.category.require_edits_approval = True
  247. self.category.save()
  248. response = self.put(
  249. self.api_link, data={
  250. 'post': "Lorem ipsum dolor met!",
  251. }
  252. )
  253. self.assertEqual(response.status_code, 200)
  254. post = self.user.post_set.all()[:1][0]
  255. self.assertTrue(post.is_unapproved)
  256. def test_reply_category_moderation_queue_bypass(self):
  257. """bypass moderation queue due to user's acl"""
  258. override_acl(self.user, {'can_approve_content': 1})
  259. self.category.require_edits_approval = True
  260. self.category.save()
  261. response = self.put(
  262. self.api_link, data={
  263. 'post': "Lorem ipsum dolor met!",
  264. }
  265. )
  266. self.assertEqual(response.status_code, 200)
  267. post = self.user.post_set.all()[:1][0]
  268. self.assertFalse(post.is_unapproved)
  269. def test_reply_user_moderation_queue(self):
  270. """edit sends reply to queue due to user acl"""
  271. self.override_acl({'require_edits_approval': 1})
  272. response = self.put(
  273. self.api_link, data={
  274. 'post': "Lorem ipsum dolor met!",
  275. }
  276. )
  277. self.assertEqual(response.status_code, 200)
  278. post = self.user.post_set.all()[:1][0]
  279. self.assertTrue(post.is_unapproved)
  280. def test_reply_user_moderation_queue_bypass(self):
  281. """bypass moderation queue due to user's acl"""
  282. override_acl(self.user, {'can_approve_content': 1})
  283. self.override_acl({'require_edits_approval': 1})
  284. response = self.put(
  285. self.api_link, data={
  286. 'post': "Lorem ipsum dolor met!",
  287. }
  288. )
  289. self.assertEqual(response.status_code, 200)
  290. post = self.user.post_set.all()[:1][0]
  291. self.assertFalse(post.is_unapproved)
  292. def test_reply_omit_other_moderation_queues(self):
  293. """other queues are omitted"""
  294. self.category.require_threads_approval = True
  295. self.category.require_replies_approval = True
  296. self.category.save()
  297. self.override_acl({
  298. 'require_threads_approval': 1,
  299. 'require_replies_approval': 1,
  300. })
  301. response = self.put(
  302. self.api_link, data={
  303. 'post': "Lorem ipsum dolor met!",
  304. }
  305. )
  306. self.assertEqual(response.status_code, 200)
  307. post = self.user.post_set.all()[:1][0]
  308. self.assertFalse(post.is_unapproved)
  309. def setUpFirstReplyTest(self):
  310. self.post = self.thread.first_post
  311. self.post.poster = self.user
  312. self.post.save()
  313. self.api_link = reverse(
  314. 'misago:api:thread-post-detail',
  315. kwargs={
  316. 'thread_pk': self.thread.pk,
  317. 'pk': self.post.pk,
  318. }
  319. )
  320. def test_first_reply_category_moderation_queue(self):
  321. """edit sends thread to queue due to category setup"""
  322. self.setUpFirstReplyTest()
  323. self.category.require_edits_approval = True
  324. self.category.save()
  325. response = self.put(
  326. self.api_link, data={
  327. 'post': "Lorem ipsum dolor met!",
  328. }
  329. )
  330. self.assertEqual(response.status_code, 200)
  331. thread = Thread.objects.get(pk=self.thread.pk)
  332. self.assertTrue(thread.is_unapproved)
  333. self.assertTrue(thread.has_unapproved_posts)
  334. post = Post.objects.get(pk=self.post.pk)
  335. self.assertTrue(post.is_unapproved)
  336. def test_first_reply_category_moderation_queue_bypass(self):
  337. """bypass moderation queue due to user's acl"""
  338. self.setUpFirstReplyTest()
  339. override_acl(self.user, {'can_approve_content': 1})
  340. self.category.require_edits_approval = True
  341. self.category.save()
  342. response = self.put(
  343. self.api_link, data={
  344. 'post': "Lorem ipsum dolor met!",
  345. }
  346. )
  347. self.assertEqual(response.status_code, 200)
  348. thread = Thread.objects.get(pk=self.thread.pk)
  349. self.assertFalse(thread.is_unapproved)
  350. self.assertFalse(thread.has_unapproved_posts)
  351. post = Post.objects.get(pk=self.post.pk)
  352. self.assertFalse(post.is_unapproved)
  353. def test_first_reply_user_moderation_queue(self):
  354. """edit sends thread to queue due to user acl"""
  355. self.setUpFirstReplyTest()
  356. self.override_acl({'require_edits_approval': 1})
  357. response = self.put(
  358. self.api_link, data={
  359. 'post': "Lorem ipsum dolor met!",
  360. }
  361. )
  362. self.assertEqual(response.status_code, 200)
  363. thread = Thread.objects.get(pk=self.thread.pk)
  364. self.assertTrue(thread.is_unapproved)
  365. self.assertTrue(thread.has_unapproved_posts)
  366. post = Post.objects.get(pk=self.post.pk)
  367. self.assertTrue(post.is_unapproved)
  368. def test_first_reply_user_moderation_queue_bypass(self):
  369. """bypass moderation queue due to user's acl"""
  370. self.setUpFirstReplyTest()
  371. override_acl(self.user, {'can_approve_content': 1})
  372. self.override_acl({'require_edits_approval': 1})
  373. response = self.put(
  374. self.api_link, data={
  375. 'post': "Lorem ipsum dolor met!",
  376. }
  377. )
  378. self.assertEqual(response.status_code, 200)
  379. thread = Thread.objects.get(pk=self.thread.pk)
  380. self.assertFalse(thread.is_unapproved)
  381. self.assertFalse(thread.has_unapproved_posts)
  382. post = Post.objects.get(pk=self.post.pk)
  383. self.assertFalse(post.is_unapproved)
  384. def test_first_reply_omit_other_moderation_queues(self):
  385. """other queues are omitted"""
  386. self.setUpFirstReplyTest()
  387. self.category.require_threads_approval = True
  388. self.category.require_replies_approval = True
  389. self.category.save()
  390. self.override_acl({
  391. 'require_threads_approval': 1,
  392. 'require_replies_approval': 1,
  393. })
  394. response = self.put(
  395. self.api_link, data={
  396. 'post': "Lorem ipsum dolor met!",
  397. }
  398. )
  399. self.assertEqual(response.status_code, 200)
  400. thread = Thread.objects.get(pk=self.thread.pk)
  401. self.assertFalse(thread.is_unapproved)
  402. self.assertFalse(thread.has_unapproved_posts)
  403. post = Post.objects.get(pk=self.post.pk)
  404. self.assertFalse(post.is_unapproved)