test_thread_postmerge_api.py 21 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610
  1. # -*- coding: utf-8 -*-
  2. from __future__ import unicode_literals
  3. import json
  4. from django.urls import reverse
  5. from misago.acl.testutils import override_acl
  6. from misago.categories.models import Category
  7. from misago.readtracker import poststracker
  8. from misago.threads import testutils
  9. from misago.threads.models import Post, Thread
  10. from misago.threads.serializers.moderation import POSTS_LIMIT
  11. from misago.users.testutils import AuthenticatedUserTestCase
  12. class ThreadPostMergeApiTestCase(AuthenticatedUserTestCase):
  13. def setUp(self):
  14. super(ThreadPostMergeApiTestCase, self).setUp()
  15. self.category = Category.objects.get(slug='first-category')
  16. self.thread = testutils.post_thread(category=self.category)
  17. self.post = testutils.reply_thread(self.thread, poster=self.user)
  18. self.api_link = reverse(
  19. 'misago:api:thread-post-merge', kwargs={
  20. 'thread_pk': self.thread.pk,
  21. }
  22. )
  23. self.override_acl()
  24. def refresh_thread(self):
  25. self.thread = Thread.objects.get(pk=self.thread.pk)
  26. def override_acl(self, extra_acl=None):
  27. new_acl = self.user.acl_cache
  28. new_acl['categories'][self.category.pk].update({
  29. 'can_see': 1,
  30. 'can_browse': 1,
  31. 'can_start_threads': 0,
  32. 'can_reply_threads': 0,
  33. 'can_edit_posts': 1,
  34. 'can_approve_content': 0,
  35. 'can_merge_posts': 1,
  36. })
  37. if extra_acl:
  38. new_acl['categories'][self.category.pk].update(extra_acl)
  39. override_acl(self.user, new_acl)
  40. def test_anonymous_user(self):
  41. """you need to authenticate to merge posts"""
  42. self.logout_user()
  43. response = self.client.post(
  44. self.api_link,
  45. json.dumps({}),
  46. content_type="application/json",
  47. )
  48. self.assertEqual(response.status_code, 403)
  49. def test_no_permission(self):
  50. """api validates permission to merge"""
  51. self.override_acl({'can_merge_posts': 0})
  52. response = self.client.post(
  53. self.api_link,
  54. json.dumps({}),
  55. content_type="application/json",
  56. )
  57. self.assertEqual(response.status_code, 403)
  58. self.assertEqual(response.json(), {
  59. 'detail': "You can't merge posts in this thread.",
  60. })
  61. def test_empty_data_json(self):
  62. """api handles empty json data"""
  63. response = self.client.post(
  64. self.api_link, json.dumps({}), content_type="application/json"
  65. )
  66. self.assertEqual(response.status_code, 400)
  67. self.assertEqual(response.json(), {
  68. 'posts': ["You have to select at least two posts to merge."],
  69. })
  70. def test_empty_data_form(self):
  71. """api handles empty form data"""
  72. response = self.client.post(self.api_link, {})
  73. self.assertEqual(response.status_code, 400)
  74. self.assertEqual(response.json(), {
  75. 'posts': ["You have to select at least two posts to merge."],
  76. })
  77. def test_invalid_data(self):
  78. """api handles post that is invalid type"""
  79. self.override_acl()
  80. response = self.client.post(self.api_link, '[]', content_type="application/json")
  81. self.assertEqual(response.status_code, 400)
  82. self.assertEqual(response.json(), {
  83. 'non_field_errors': ["Invalid data. Expected a dictionary, but got list."],
  84. })
  85. self.override_acl()
  86. response = self.client.post(self.api_link, '123', content_type="application/json")
  87. self.assertEqual(response.status_code, 400)
  88. self.assertEqual(response.json(), {
  89. 'non_field_errors': ["Invalid data. Expected a dictionary, but got int."],
  90. })
  91. self.override_acl()
  92. response = self.client.post(self.api_link, '"string"', content_type="application/json")
  93. self.assertEqual(response.status_code, 400)
  94. self.assertEqual(response.json(), {
  95. 'non_field_errors': ["Invalid data. Expected a dictionary, but got str."],
  96. })
  97. self.override_acl()
  98. response = self.client.post(self.api_link, 'malformed', content_type="application/json")
  99. self.assertEqual(response.status_code, 400)
  100. self.assertEqual(response.json(), {
  101. 'detail': "JSON parse error - Expecting value: line 1 column 1 (char 0)",
  102. })
  103. def test_no_posts_ids(self):
  104. """api rejects no posts ids"""
  105. response = self.client.post(
  106. self.api_link,
  107. json.dumps({
  108. 'posts': []
  109. }),
  110. content_type="application/json",
  111. )
  112. self.assertEqual(response.status_code, 400)
  113. self.assertEqual(response.json(), {
  114. 'posts': ["You have to select at least two posts to merge."],
  115. })
  116. def test_invalid_posts_data(self):
  117. """api handles invalid data"""
  118. response = self.client.post(
  119. self.api_link,
  120. json.dumps({
  121. 'posts': 'string'
  122. }),
  123. content_type="application/json",
  124. )
  125. self.assertEqual(response.status_code, 400)
  126. self.assertEqual(response.json(), {
  127. 'posts': ['Expected a list of items but got type "str".'],
  128. })
  129. def test_invalid_posts_ids(self):
  130. """api handles invalid post id"""
  131. response = self.client.post(
  132. self.api_link,
  133. json.dumps({
  134. 'posts': [1, 2, 'string']
  135. }),
  136. content_type="application/json",
  137. )
  138. self.assertEqual(response.status_code, 400)
  139. self.assertEqual(response.json(), {
  140. 'posts': ["One or more post ids received were invalid."],
  141. })
  142. def test_one_post_id(self):
  143. """api rejects one post id"""
  144. response = self.client.post(
  145. self.api_link,
  146. json.dumps({
  147. 'posts': [1]
  148. }),
  149. content_type="application/json",
  150. )
  151. self.assertEqual(response.status_code, 400)
  152. self.assertEqual(response.json(), {
  153. 'posts': ["You have to select at least two posts to merge."],
  154. })
  155. def test_merge_limit(self):
  156. """api rejects more posts than merge limit"""
  157. response = self.client.post(
  158. self.api_link,
  159. json.dumps({
  160. 'posts': list(range(POSTS_LIMIT + 1))
  161. }),
  162. content_type="application/json",
  163. )
  164. self.assertEqual(response.status_code, 400)
  165. self.assertEqual(response.json(), {
  166. 'posts': ["No more than {} posts can be merged at single time.".format(POSTS_LIMIT)],
  167. })
  168. def test_merge_event(self):
  169. """api recjects events"""
  170. event = testutils.reply_thread(self.thread, is_event=True, poster=self.user)
  171. response = self.client.post(
  172. self.api_link,
  173. json.dumps({
  174. 'posts': [self.post.pk, event.pk]
  175. }),
  176. content_type="application/json",
  177. )
  178. self.assertEqual(response.status_code, 400)
  179. self.assertEqual(response.json(), {
  180. 'posts': ["Events can't be merged."],
  181. })
  182. def test_merge_notfound_pk(self):
  183. """api recjects nonexistant pk's"""
  184. response = self.client.post(
  185. self.api_link,
  186. json.dumps({
  187. 'posts': [self.post.pk, self.post.pk * 1000]
  188. }),
  189. content_type="application/json",
  190. )
  191. self.assertEqual(response.status_code, 400)
  192. self.assertEqual(response.json(), {
  193. 'posts': ["One or more posts to merge could not be found."],
  194. })
  195. def test_merge_cross_threads(self):
  196. """api recjects attempt to merge with post made in other thread"""
  197. other_thread = testutils.post_thread(category=self.category)
  198. other_post = testutils.reply_thread(other_thread, poster=self.user)
  199. response = self.client.post(
  200. self.api_link,
  201. json.dumps({
  202. 'posts': [self.post.pk, other_post.pk]
  203. }),
  204. content_type="application/json",
  205. )
  206. self.assertEqual(response.status_code, 400)
  207. self.assertEqual(response.json(), {
  208. 'posts': ["One or more posts to merge could not be found."],
  209. })
  210. def test_merge_authenticated_with_guest_post(self):
  211. """api recjects attempt to merge with post made by deleted user"""
  212. other_post = testutils.reply_thread(self.thread)
  213. response = self.client.post(
  214. self.api_link,
  215. json.dumps({
  216. 'posts': [self.post.pk, other_post.pk]
  217. }),
  218. content_type="application/json",
  219. )
  220. self.assertEqual(response.status_code, 400)
  221. self.assertEqual(response.json(), {
  222. 'posts': ["Posts made by different users can't be merged."],
  223. })
  224. def test_merge_guest_with_authenticated_post(self):
  225. """api recjects attempt to merge with post made by deleted user"""
  226. other_post = testutils.reply_thread(self.thread)
  227. response = self.client.post(
  228. self.api_link,
  229. json.dumps({
  230. 'posts': [other_post.pk, self.post.pk]
  231. }),
  232. content_type="application/json",
  233. )
  234. self.assertEqual(response.status_code, 400)
  235. self.assertEqual(response.json(), {
  236. 'posts': ["Posts made by different users can't be merged."],
  237. })
  238. def test_merge_guest_posts_different_usernames(self):
  239. """api recjects attempt to merge posts made by different guests"""
  240. response = self.client.post(
  241. self.api_link,
  242. json.dumps({
  243. 'posts': [
  244. testutils.reply_thread(self.thread, poster="Bob").pk,
  245. testutils.reply_thread(self.thread, poster="Miku").pk,
  246. ]
  247. }),
  248. content_type="application/json",
  249. )
  250. self.assertEqual(response.status_code, 400)
  251. self.assertEqual(response.json(), {
  252. 'posts': ["Posts made by different users can't be merged."],
  253. })
  254. def test_merge_different_visibility(self):
  255. """api recjects attempt to merge posts with different visibility"""
  256. self.override_acl({'can_hide_posts': 1})
  257. response = self.client.post(
  258. self.api_link,
  259. json.dumps({
  260. 'posts': [
  261. testutils.reply_thread(self.thread, poster=self.user, is_hidden=True).pk,
  262. testutils.reply_thread(self.thread, poster=self.user, is_hidden=False).pk,
  263. ]
  264. }),
  265. content_type="application/json",
  266. )
  267. self.assertEqual(response.status_code, 400)
  268. self.assertEqual(response.json(), {
  269. 'posts': ["Posts with different visibility can't be merged."],
  270. })
  271. def test_merge_different_approval(self):
  272. """api recjects attempt to merge posts with different approval"""
  273. self.override_acl({'can_approve_content': 1})
  274. response = self.client.post(
  275. self.api_link,
  276. json.dumps({
  277. 'posts': [
  278. testutils.reply_thread(self.thread, poster=self.user, is_unapproved=True).pk,
  279. testutils.reply_thread(self.thread, poster=self.user, is_unapproved=False).pk,
  280. ]
  281. }),
  282. content_type="application/json",
  283. )
  284. self.assertEqual(response.status_code, 400)
  285. self.assertEqual(response.json(), {
  286. 'posts': ["Posts with different visibility can't be merged."],
  287. })
  288. def test_closed_thread(self):
  289. """api validates permission to merge in closed thread"""
  290. self.thread.is_closed = True
  291. self.thread.save()
  292. posts = [
  293. testutils.reply_thread(self.thread, poster=self.user).pk,
  294. testutils.reply_thread(self.thread, poster=self.user).pk,
  295. ]
  296. response = self.client.post(
  297. self.api_link,
  298. json.dumps({'posts': posts}),
  299. content_type="application/json",
  300. )
  301. self.assertEqual(response.status_code, 400)
  302. self.assertEqual(response.json(), {
  303. 'posts': ["This thread is closed. You can't merge posts in it."],
  304. })
  305. # allow closing threads
  306. self.override_acl({'can_close_threads': 1})
  307. response = self.client.post(
  308. self.api_link,
  309. json.dumps({'posts': posts}),
  310. content_type="application/json",
  311. )
  312. self.assertEqual(response.status_code, 200)
  313. def test_closed_category(self):
  314. """api validates permission to merge in closed category"""
  315. self.category.is_closed = True
  316. self.category.save()
  317. posts = [
  318. testutils.reply_thread(self.thread, poster=self.user).pk,
  319. testutils.reply_thread(self.thread, poster=self.user).pk,
  320. ]
  321. response = self.client.post(
  322. self.api_link,
  323. json.dumps({'posts': posts}),
  324. content_type="application/json",
  325. )
  326. self.assertEqual(response.status_code, 400)
  327. self.assertEqual(response.json(), {
  328. 'posts': ["This category is closed. You can't merge posts in it."],
  329. })
  330. # allow closing threads
  331. self.override_acl({'can_close_threads': 1})
  332. response = self.client.post(
  333. self.api_link,
  334. json.dumps({'posts': posts}),
  335. content_type="application/json",
  336. )
  337. self.assertEqual(response.status_code, 200)
  338. def test_merge_best_answer_first_post(self):
  339. """api recjects attempt to merge best_answer with first post"""
  340. self.thread.first_post.poster = self.user
  341. self.thread.first_post.save()
  342. self.post.poster = self.user
  343. self.post.save()
  344. self.thread.set_best_answer(self.user, self.post)
  345. self.thread.save()
  346. response = self.client.post(
  347. self.api_link,
  348. json.dumps({
  349. 'posts': [
  350. self.thread.first_post.pk,
  351. self.post.pk,
  352. ]
  353. }),
  354. content_type="application/json",
  355. )
  356. self.assertEqual(response.status_code, 400)
  357. self.assertEqual(response.json(), {
  358. 'posts': ["Post marked as best answer can't be merged with thread's first post."]
  359. })
  360. def test_merge_posts(self):
  361. """api merges two posts"""
  362. post_a = testutils.reply_thread(self.thread, poster=self.user, message="Battęry")
  363. post_b = testutils.reply_thread(self.thread, poster=self.user, message="Hórse")
  364. thread_replies = self.thread.replies
  365. response = self.client.post(
  366. self.api_link,
  367. json.dumps({
  368. 'posts': [post_a.pk, post_b.pk]
  369. }),
  370. content_type="application/json",
  371. )
  372. self.assertEqual(response.status_code, 200)
  373. self.refresh_thread()
  374. self.assertEqual(self.thread.replies, thread_replies - 1)
  375. with self.assertRaises(Post.DoesNotExist):
  376. Post.objects.get(pk=post_b.pk)
  377. merged_post = Post.objects.get(pk=post_a.pk)
  378. self.assertEqual(merged_post.parsed, '{}\n{}'.format(post_a.parsed, post_b.parsed))
  379. def test_merge_guest_posts(self):
  380. """api recjects attempt to merge posts made by same guest"""
  381. response = self.client.post(
  382. self.api_link,
  383. json.dumps({
  384. 'posts': [
  385. testutils.reply_thread(self.thread, poster="Bob").pk,
  386. testutils.reply_thread(self.thread, poster="Bob").pk,
  387. ]
  388. }),
  389. content_type="application/json",
  390. )
  391. self.assertEqual(response.status_code, 200)
  392. def test_merge_hidden_posts(self):
  393. """api merges two hidden posts"""
  394. self.override_acl({'can_hide_posts': 1})
  395. response = self.client.post(
  396. self.api_link,
  397. json.dumps({
  398. 'posts': [
  399. testutils.reply_thread(self.thread, poster=self.user, is_hidden=True).pk,
  400. testutils.reply_thread(self.thread, poster=self.user, is_hidden=True).pk,
  401. ]
  402. }),
  403. content_type="application/json",
  404. )
  405. self.assertEqual(response.status_code, 200)
  406. def test_merge_unapproved_posts(self):
  407. """api merges two unapproved posts"""
  408. self.override_acl({'can_approve_content': 1})
  409. response = self.client.post(
  410. self.api_link,
  411. json.dumps({
  412. 'posts': [
  413. testutils.reply_thread(self.thread, poster=self.user, is_unapproved=True).pk,
  414. testutils.reply_thread(self.thread, poster=self.user, is_unapproved=True).pk,
  415. ]
  416. }),
  417. content_type="application/json",
  418. )
  419. self.assertEqual(response.status_code, 200)
  420. def test_merge_with_hidden_thread(self):
  421. """api excludes thread's first post from visibility checks"""
  422. self.thread.first_post.is_hidden = True
  423. self.thread.first_post.poster = self.user
  424. self.thread.first_post.save()
  425. post_visible = testutils.reply_thread(self.thread, poster=self.user, is_hidden=False)
  426. self.override_acl({'can_hide_threads': 1})
  427. response = self.client.post(
  428. self.api_link,
  429. json.dumps({
  430. 'posts': [self.thread.first_post.pk, post_visible.pk]
  431. }),
  432. content_type="application/json",
  433. )
  434. self.assertEqual(response.status_code, 200)
  435. def test_merge_protected(self):
  436. """api preserves protected status after merge"""
  437. response = self.client.post(
  438. self.api_link,
  439. json.dumps({
  440. 'posts': [
  441. testutils.reply_thread(self.thread, poster="Bob", is_protected=True).pk,
  442. testutils.reply_thread(self.thread, poster="Bob", is_protected=False).pk,
  443. ]
  444. }),
  445. content_type="application/json",
  446. )
  447. self.assertEqual(response.status_code, 200)
  448. merged_post = self.thread.post_set.order_by('-id')[0]
  449. self.assertTrue(merged_post.is_protected)
  450. def test_merge_best_answer(self):
  451. """api merges best answer with other post"""
  452. best_answer = testutils.reply_thread(self.thread, poster="Bob")
  453. self.thread.set_best_answer(self.user, best_answer)
  454. self.thread.save()
  455. response = self.client.post(
  456. self.api_link,
  457. json.dumps({
  458. 'posts': [
  459. best_answer.pk,
  460. testutils.reply_thread(self.thread, poster="Bob").pk,
  461. ]
  462. }),
  463. content_type="application/json",
  464. )
  465. self.assertEqual(response.status_code, 200)
  466. self.refresh_thread()
  467. self.assertEqual(self.thread.best_answer, best_answer)
  468. def test_merge_best_answer_in(self):
  469. """api merges best answer into other post"""
  470. other_post = testutils.reply_thread(self.thread, poster="Bob")
  471. best_answer = testutils.reply_thread(self.thread, poster="Bob")
  472. self.thread.set_best_answer(self.user, best_answer)
  473. self.thread.save()
  474. response = self.client.post(
  475. self.api_link,
  476. json.dumps({
  477. 'posts': [
  478. best_answer.pk,
  479. other_post.pk,
  480. ]
  481. }),
  482. content_type="application/json",
  483. )
  484. self.assertEqual(response.status_code, 200)
  485. self.refresh_thread()
  486. self.assertEqual(self.thread.best_answer, other_post)
  487. def test_merge_best_answer_in_protected(self):
  488. """api merges best answer into protected post"""
  489. best_answer = testutils.reply_thread(self.thread, poster="Bob")
  490. self.thread.set_best_answer(self.user, best_answer)
  491. self.thread.save()
  492. response = self.client.post(
  493. self.api_link,
  494. json.dumps({
  495. 'posts': [
  496. best_answer.pk,
  497. testutils.reply_thread(self.thread, poster="Bob", is_protected=True).pk,
  498. ]
  499. }),
  500. content_type="application/json",
  501. )
  502. self.assertEqual(response.status_code, 200)
  503. self.refresh_thread()
  504. self.assertEqual(self.thread.best_answer, best_answer)
  505. self.assertTrue(self.thread.best_answer.is_protected)
  506. self.assertTrue(self.thread.best_answer_is_protected)
  507. def test_merge_remove_reads(self):
  508. """two posts merge removes read tracker from post"""
  509. post_a = testutils.reply_thread(self.thread, poster=self.user, message="Battęry")
  510. post_b = testutils.reply_thread(self.thread, poster=self.user, message="Hórse")
  511. poststracker.save_read(self.user, post_a)
  512. poststracker.save_read(self.user, post_b)
  513. response = self.client.post(
  514. self.api_link,
  515. json.dumps({
  516. 'posts': [post_a.pk, post_b.pk]
  517. }),
  518. content_type="application/json",
  519. )
  520. self.assertEqual(response.status_code, 200)
  521. # both post's were removed from readtracker
  522. self.assertEqual(self.user.postread_set.count(), 0)