test_thread_pollvotes_api.py 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392
  1. from datetime import timedelta
  2. from django.contrib.auth import get_user_model
  3. from django.urls import reverse
  4. from django.utils import timezone
  5. from ...acl.test import patch_user_acl
  6. from ..models import Poll
  7. from ..test import patch_category_acl
  8. from .test_thread_poll_api import ThreadPollApiTestCase
  9. User = get_user_model()
  10. class ThreadGetVotesTests(ThreadPollApiTestCase):
  11. def setUp(self):
  12. super().setUp()
  13. self.mock_poll()
  14. self.poll.is_public = True
  15. self.poll.save()
  16. self.api_link = reverse(
  17. "misago:api:thread-poll-votes",
  18. kwargs={"thread_pk": self.thread.pk, "pk": self.poll.pk},
  19. )
  20. def test_anonymous(self):
  21. """api allows guests to get poll votes"""
  22. self.logout_user()
  23. response = self.client.get(self.api_link)
  24. self.assertEqual(response.status_code, 200)
  25. def test_invalid_thread_id(self):
  26. """api validates that thread id is integer"""
  27. api_link = reverse(
  28. "misago:api:thread-poll-votes",
  29. kwargs={"thread_pk": "kjha6dsa687sa", "pk": self.poll.pk},
  30. )
  31. response = self.client.get(api_link)
  32. self.assertEqual(response.status_code, 404)
  33. def test_nonexistant_thread_id(self):
  34. """api validates that thread exists"""
  35. api_link = reverse(
  36. "misago:api:thread-poll-votes",
  37. kwargs={"thread_pk": self.thread.pk + 1, "pk": self.poll.pk},
  38. )
  39. response = self.client.get(api_link)
  40. self.assertEqual(response.status_code, 404)
  41. def test_invalid_poll_id(self):
  42. """api validates that poll id is integer"""
  43. api_link = reverse(
  44. "misago:api:thread-poll-votes",
  45. kwargs={"thread_pk": self.thread.pk, "pk": "sad98as7d97sa98"},
  46. )
  47. response = self.client.get(api_link)
  48. self.assertEqual(response.status_code, 404)
  49. def test_nonexistant_poll_id(self):
  50. """api validates that poll exists"""
  51. api_link = reverse(
  52. "misago:api:thread-poll-votes",
  53. kwargs={"thread_pk": self.thread.pk, "pk": self.poll.pk + 123},
  54. )
  55. response = self.client.get(api_link)
  56. self.assertEqual(response.status_code, 404)
  57. @patch_user_acl({"can_always_see_poll_voters": False})
  58. def test_no_permission(self):
  59. """api chcecks permission to see poll voters"""
  60. self.poll.is_public = False
  61. self.poll.save()
  62. response = self.client.get(self.api_link)
  63. self.assertEqual(response.status_code, 403)
  64. def test_nonpublic_poll(self):
  65. """api validates that poll is public"""
  66. self.logout_user()
  67. self.poll.is_public = False
  68. self.poll.save()
  69. response = self.client.get(self.api_link)
  70. self.assertEqual(response.status_code, 403)
  71. def test_get_votes(self):
  72. """api returns list of voters"""
  73. response = self.client.get(self.api_link)
  74. self.assertEqual(response.status_code, 200)
  75. response_json = response.json()
  76. self.assertEqual(len(response_json), 4)
  77. self.assertEqual(
  78. [c["label"] for c in response_json], ["Alpha", "Beta", "Gamma", "Delta"]
  79. )
  80. self.assertEqual([c["votes"] for c in response_json], [1, 0, 2, 1])
  81. self.assertEqual([len(c["voters"]) for c in response_json], [1, 0, 2, 1])
  82. self.assertEqual(
  83. [[v["username"] for v in c["voters"]] for c in response_json][0][0], "User"
  84. )
  85. user = User.objects.get(slug="user")
  86. self.assertEqual(
  87. [[v["url"] for v in c["voters"]] for c in response_json][0][0],
  88. user.get_absolute_url(),
  89. )
  90. @patch_user_acl({"can_always_see_poll_voters": True})
  91. def test_get_votes_private_poll(self):
  92. """api returns list of voters on private poll for user with permission"""
  93. self.poll.is_public = False
  94. self.poll.save()
  95. response = self.client.get(self.api_link)
  96. self.assertEqual(response.status_code, 200)
  97. response_json = response.json()
  98. self.assertEqual(len(response_json), 4)
  99. self.assertEqual(
  100. [c["label"] for c in response_json], ["Alpha", "Beta", "Gamma", "Delta"]
  101. )
  102. self.assertEqual([c["votes"] for c in response_json], [1, 0, 2, 1])
  103. self.assertEqual([len(c["voters"]) for c in response_json], [1, 0, 2, 1])
  104. self.assertEqual(
  105. [[v["username"] for v in c["voters"]] for c in response_json][0][0], "User"
  106. )
  107. user = User.objects.get(slug="user")
  108. self.assertEqual(
  109. [[v["url"] for v in c["voters"]] for c in response_json][0][0],
  110. user.get_absolute_url(),
  111. )
  112. class ThreadPostVotesTests(ThreadPollApiTestCase):
  113. def setUp(self):
  114. super().setUp()
  115. self.mock_poll()
  116. self.api_link = reverse(
  117. "misago:api:thread-poll-votes",
  118. kwargs={"thread_pk": self.thread.pk, "pk": self.poll.pk},
  119. )
  120. def delete_user_votes(self):
  121. self.poll.choices[2]["votes"] = 1
  122. self.poll.choices[3]["votes"] = 0
  123. self.poll.votes = 2
  124. self.poll.save()
  125. self.poll.pollvote_set.filter(voter=self.user).delete()
  126. def test_anonymous(self):
  127. """api requires you to sign in to vote in poll"""
  128. self.logout_user()
  129. response = self.post(self.api_link)
  130. self.assertEqual(response.status_code, 403)
  131. def test_empty_vote_json(self):
  132. """api validates if vote that user has made was empty"""
  133. self.delete_user_votes()
  134. response = self.client.post(
  135. self.api_link, "[]", content_type="application/json"
  136. )
  137. self.assertEqual(response.status_code, 400)
  138. self.assertEqual(response.json(), {"detail": "You have to make a choice."})
  139. def test_empty_vote_form(self):
  140. """api validates if vote that user has made was empty"""
  141. self.delete_user_votes()
  142. response = self.client.post(self.api_link)
  143. self.assertEqual(response.status_code, 400)
  144. self.assertEqual(response.json(), {"detail": "You have to make a choice."})
  145. def test_malformed_vote(self):
  146. """api validates if vote that user has made was correctly structured"""
  147. self.delete_user_votes()
  148. response = self.post(self.api_link)
  149. self.assertEqual(response.status_code, 400)
  150. self.assertEqual(
  151. response.json(), {"detail": 'Expected a list of items but got type "dict".'}
  152. )
  153. response = self.post(self.api_link, data={})
  154. self.assertEqual(response.status_code, 400)
  155. self.assertEqual(
  156. response.json(), {"detail": 'Expected a list of items but got type "dict".'}
  157. )
  158. response = self.post(self.api_link, data="hello")
  159. self.assertEqual(response.status_code, 400)
  160. self.assertEqual(
  161. response.json(), {"detail": 'Expected a list of items but got type "str".'}
  162. )
  163. response = self.post(self.api_link, data=123)
  164. self.assertEqual(response.status_code, 400)
  165. self.assertEqual(
  166. response.json(), {"detail": 'Expected a list of items but got type "int".'}
  167. )
  168. def test_invalid_choices(self):
  169. """api validates if vote that user has made overlaps with allowed votes"""
  170. self.delete_user_votes()
  171. response = self.post(self.api_link, data=["lorem", "ipsum"])
  172. self.assertEqual(response.status_code, 400)
  173. self.assertEqual(
  174. response.json(), {"detail": "One or more of poll choices were invalid."}
  175. )
  176. def test_too_many_choices(self):
  177. """api validates if vote that user has made overlaps with allowed votes"""
  178. self.poll.allowed_choices = 1
  179. self.poll.allow_revotes = True
  180. self.poll.save()
  181. response = self.post(self.api_link, data=["aaaaaaaaaaaa", "bbbbbbbbbbbb"])
  182. self.assertEqual(response.status_code, 400)
  183. self.assertEqual(
  184. response.json(),
  185. {"detail": "This poll disallows voting for more than 1 choice."},
  186. )
  187. def test_revote(self):
  188. """
  189. api validates if user is trying to change vote in poll that disallows revoting
  190. """
  191. response = self.post(self.api_link, data=["lorem", "ipsum"])
  192. self.assertEqual(response.status_code, 403)
  193. self.assertEqual(
  194. response.json(), {"detail": "You have already voted in this poll."}
  195. )
  196. self.delete_user_votes()
  197. response = self.post(self.api_link)
  198. self.assertEqual(response.status_code, 400)
  199. self.assertEqual(
  200. response.json(), {"detail": 'Expected a list of items but got type "dict".'}
  201. )
  202. @patch_category_acl({"can_close_threads": False})
  203. def test_vote_in_closed_thread_no_permission(self):
  204. """api validates is user has permission to vote poll in closed thread"""
  205. self.thread.is_closed = True
  206. self.thread.save()
  207. self.delete_user_votes()
  208. response = self.post(self.api_link)
  209. self.assertEqual(response.status_code, 403)
  210. self.assertEqual(
  211. response.json(), {"detail": "This thread is closed. You can't vote in it."}
  212. )
  213. @patch_category_acl({"can_close_threads": True})
  214. def test_vote_in_closed_thread(self):
  215. """api validates is user has permission to vote poll in closed thread"""
  216. self.thread.is_closed = True
  217. self.thread.save()
  218. self.delete_user_votes()
  219. response = self.post(self.api_link)
  220. self.assertEqual(response.status_code, 400)
  221. @patch_category_acl({"can_close_threads": False})
  222. def test_vote_in_closed_category_no_permission(self):
  223. """api validates is user has permission to vote poll in closed category"""
  224. self.category.is_closed = True
  225. self.category.save()
  226. self.delete_user_votes()
  227. response = self.post(self.api_link)
  228. self.assertEqual(response.status_code, 403)
  229. self.assertEqual(
  230. response.json(),
  231. {"detail": "This category is closed. You can't vote in it."},
  232. )
  233. @patch_category_acl({"can_close_threads": True})
  234. def test_vote_in_closed_category(self):
  235. """api validates is user has permission to vote poll in closed category"""
  236. self.category.is_closed = True
  237. self.category.save()
  238. self.delete_user_votes()
  239. response = self.post(self.api_link)
  240. self.assertEqual(response.status_code, 400)
  241. def test_vote_in_finished_poll(self):
  242. """api valdiates if poll has finished before letting user to vote in it"""
  243. self.poll.posted_on = timezone.now() - timedelta(days=15)
  244. self.poll.length = 5
  245. self.poll.save()
  246. self.delete_user_votes()
  247. response = self.post(self.api_link)
  248. self.assertEqual(response.status_code, 403)
  249. self.assertEqual(
  250. response.json(), {"detail": "This poll is over. You can't vote in it."}
  251. )
  252. self.poll.length = 50
  253. self.poll.save()
  254. response = self.post(self.api_link)
  255. self.assertEqual(response.status_code, 400)
  256. self.assertEqual(
  257. response.json(), {"detail": 'Expected a list of items but got type "dict".'}
  258. )
  259. def test_fresh_vote(self):
  260. """api handles first vote in poll"""
  261. self.delete_user_votes()
  262. response = self.post(self.api_link, data=["aaaaaaaaaaaa", "bbbbbbbbbbbb"])
  263. self.assertEqual(response.status_code, 200)
  264. # validate state change
  265. poll = Poll.objects.get(pk=self.poll.pk)
  266. self.assertEqual(poll.votes, 4)
  267. self.assertEqual([c["votes"] for c in poll.choices], [2, 1, 1, 0])
  268. for choice in poll.choices:
  269. self.assertNotIn("selected", choice)
  270. self.assertEqual(poll.pollvote_set.count(), 4)
  271. # validate response json
  272. response_json = response.json()
  273. self.assertEqual(response_json["votes"], 4)
  274. self.assertEqual([c["votes"] for c in response_json["choices"]], [2, 1, 1, 0])
  275. self.assertEqual(
  276. [c["selected"] for c in response_json["choices"]],
  277. [True, True, False, False],
  278. )
  279. self.assertFalse(response_json["acl"]["can_vote"])
  280. def test_vote_change(self):
  281. """api handles vote change"""
  282. self.poll.allow_revotes = True
  283. self.poll.save()
  284. response = self.post(self.api_link, data=["aaaaaaaaaaaa", "bbbbbbbbbbbb"])
  285. self.assertEqual(response.status_code, 200)
  286. # validate state change
  287. poll = Poll.objects.get(pk=self.poll.pk)
  288. self.assertEqual(poll.votes, 4)
  289. self.assertEqual([c["votes"] for c in poll.choices], [2, 1, 1, 0])
  290. for choice in poll.choices:
  291. self.assertNotIn("selected", choice)
  292. self.assertEqual(poll.pollvote_set.count(), 4)
  293. # validate response json
  294. response_json = response.json()
  295. self.assertEqual(response_json["votes"], 4)
  296. self.assertEqual([c["votes"] for c in response_json["choices"]], [2, 1, 1, 0])
  297. self.assertEqual(
  298. [c["selected"] for c in response_json["choices"]],
  299. [True, True, False, False],
  300. )
  301. self.assertTrue(response_json["acl"]["can_vote"])