123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566 |
- import json
- from django.core.urlresolvers import reverse
- from django.utils.encoding import smart_str
- from django.utils.six.moves import range
- from misago.acl import add_acl
- from misago.acl.testutils import override_acl
- from misago.categories.models import Category
- from .. import testutils
- from ..api.threadendpoints.merge import MERGE_LIMIT
- from ..models import Post, Thread
- from ..serializers import ThreadsListSerializer
- from .test_threads_api import ThreadsApiTestCase
- class ThreadsMergeApiTests(ThreadsApiTestCase):
- def setUp(self):
- super(ThreadsMergeApiTests, self).setUp()
- self.api_link = reverse('misago:api:thread-merge')
- Category(
- name='Category B',
- slug='category-b',
- ).insert_at(self.category, position='last-child', save=True)
- self.category_b = Category.objects.get(slug='category-b')
- def test_merge_no_threads(self):
- """api validates if we are trying to merge no threads"""
- response = self.client.post(self.api_link, content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'detail': "You have to select at least two threads to merge."
- })
- def test_merge_empty_threads(self):
- """api validates if we are trying to empty threads list"""
- response = self.client.post(self.api_link, json.dumps({
- 'threads': []
- }), content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'detail': "You have to select at least two threads to merge."
- })
- def test_merge_invalid_threads(self):
- """api validates if we are trying to merge invalid thread ids"""
- response = self.client.post(self.api_link, json.dumps({
- 'threads': 'abcd'
- }), content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'detail': "One or more thread ids received were invalid."
- })
- response = self.client.post(self.api_link, json.dumps({
- 'threads': ['a', '-', 'c']
- }), content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'detail': "One or more thread ids received were invalid."
- })
- def test_merge_single_thread(self):
- """api validates if we are trying to merge single thread"""
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id]
- }), content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'detail': "You have to select at least two threads to merge."
- })
- def test_merge_with_nonexisting_thread(self):
- """api validates if we are trying to merge with invalid thread"""
- unaccesible_thread = testutils.post_thread(category=self.category_b)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, self.thread.id + 1000]
- }), content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'detail': "One or more threads to merge could not be found."
- })
- def test_merge_with_invisible_thread(self):
- """api validates if we are trying to merge with inaccesible thread"""
- unaccesible_thread = testutils.post_thread(category=self.category_b)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, unaccesible_thread.id]
- }), content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'detail': "One or more threads to merge could not be found."
- })
- def test_merge_no_permission(self):
- """api validates permission to merge threads"""
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id]
- }), content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, [
- {
- 'id': thread.pk,
- 'title': thread.title,
- 'errors': [
- "You don't have permission to merge this thread with others."
- ]
- },
- {
- 'id': self.thread.pk,
- 'title': self.thread.title,
- 'errors': [
- "You don't have permission to merge this thread with others."
- ]
- },
- ])
- def test_merge_too_many_threads(self):
- """api rejects too many threads to merge"""
- threads = []
- for i in range(MERGE_LIMIT + 1):
- threads.append(testutils.post_thread(category=self.category).pk)
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- response = self.client.post(self.api_link, json.dumps({
- 'threads': threads
- }), content_type="application/json")
- self.assertEqual(response.status_code, 403)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'detail': "No more than %s threads can be merged at single time." % MERGE_LIMIT
- })
- def test_merge_no_final_thread(self):
- """api rejects merge because no data to merge threads was specified"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id]
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'title': ['This field is required.'],
- 'category': ['This field is required.'],
- })
- def test_merge_invalid_final_title(self):
- """api rejects merge because final thread title was invalid"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': '$$$',
- 'category': self.category.id,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'title': ["Thread title should be at least 5 characters long (it has 3)."]
- })
- def test_merge_invalid_category(self):
- """api rejects merge because final category was invalid"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': 'Valid thread title',
- 'category': self.category_b.id,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'category': ["Requested category could not be found."]
- })
- def test_merge_unallowed_start_thread(self):
- """api rejects merge because category isn't allowing starting threads"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- 'can_start_threads': 0
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': 'Valid thread title',
- 'category': self.category.id
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'category': [
- "You can't create new threads in selected category."
- ]
- })
- def test_merge_invalid_weight(self):
- """api rejects merge because final weight was invalid"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': 'Valid thread title',
- 'category': self.category.id,
- 'weight': 4,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'weight': ["Ensure this value is less than or equal to 2."]
- })
- def test_merge_unallowed_global_weight(self):
- """api rejects merge because global weight was unallowed"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': 'Valid thread title',
- 'category': self.category.id,
- 'weight': 2,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'weight': [
- "You don't have permission to pin threads globally in this category."
- ]
- })
- def test_merge_unallowed_local_weight(self):
- """api rejects merge because local weight was unallowed"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': 'Valid thread title',
- 'category': self.category.id,
- 'weight': 1,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'weight': [
- "You don't have permission to pin threads in this category."
- ]
- })
- def test_merge_allowed_local_weight(self):
- """api allows local weight"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- 'can_pin_threads': 1,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': '$$$',
- 'category': self.category.id,
- 'weight': 1,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'title': ["Thread title should be at least 5 characters long (it has 3)."]
- })
- def test_merge_allowed_global_weight(self):
- """api allows local weight"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- 'can_pin_threads': 2,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': '$$$',
- 'category': self.category.id,
- 'weight': 2,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'title': ["Thread title should be at least 5 characters long (it has 3)."]
- })
- def test_merge_unallowed_close(self):
- """api rejects merge because closing thread was unallowed"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': 'Valid thread title',
- 'category': self.category.id,
- 'is_closed': True,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'is_closed': [
- "You don't have permission to close threads in this category."
- ]
- })
- def test_merge_with_close(self):
- """api allows for closing thread"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- 'can_close_threads': True,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': '$$$',
- 'category': self.category.id,
- 'weight': 0,
- 'is_closed': True,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'title': ["Thread title should be at least 5 characters long (it has 3)."]
- })
- def test_merge_unallowed_hidden(self):
- """api rejects merge because hidden thread was unallowed"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- 'can_hide_threads': 0,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': 'Valid thread title',
- 'category': self.category.id,
- 'is_hidden': True,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'is_hidden': [
- "You don't have permission to hide threads in this category."
- ]
- })
- def test_merge_with_hide(self):
- """api allows for hiding thread"""
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- 'can_hide_threads': 1,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': '$$$',
- 'category': self.category.id,
- 'weight': 0,
- 'is_hidden': True,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 400)
- response_json = json.loads(smart_str(response.content))
- self.assertEqual(response_json, {
- 'title': ["Thread title should be at least 5 characters long (it has 3)."]
- })
- def test_merge(self):
- """api performs basic merge"""
- posts_ids = [p.id for p in Post.objects.all()]
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'threads': [self.thread.id, thread.id],
- 'title': 'Merged thread!',
- 'category': self.category.id,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 200)
- # is response json with new thread?
- response_json = json.loads(smart_str(response.content))
- new_thread = Thread.objects.get(pk=response_json['id'])
- new_thread.is_read = False
- new_thread.subscription = None
- new_thread.top_category = None
- add_acl(self.user, new_thread.category)
- add_acl(self.user, new_thread)
- self.assertEqual(response_json, ThreadsListSerializer(new_thread).data)
- # did posts move to new thread?
- for post in Post.objects.filter(id__in=posts_ids):
- self.assertEqual(post.thread_id, new_thread.id)
- # are old threads gone?
- self.assertEqual([t.pk for t in Thread.objects.all()], [new_thread.pk])
- def test_merge_with_top_category(self):
- """api performs merge with top category"""
- posts_ids = [p.id for p in Post.objects.all()]
- self.override_acl({
- 'can_merge_threads': True,
- 'can_close_threads': False,
- 'can_edit_threads': False,
- 'can_reply_threads': False,
- })
- thread = testutils.post_thread(category=self.category)
- response = self.client.post(self.api_link, json.dumps({
- 'top_category': self.root.id,
- 'threads': [self.thread.id, thread.id],
- 'title': 'Merged thread!',
- 'category': self.category.id,
- }), content_type="application/json")
- self.assertEqual(response.status_code, 200)
- # is response json with new thread?
- response_json = json.loads(smart_str(response.content))
- new_thread = Thread.objects.get(pk=response_json['id'])
- new_thread.is_read = False
- new_thread.subscription = None
- new_thread.top_category = self.category
- add_acl(self.user, new_thread.category)
- add_acl(self.user, new_thread)
- self.assertEqual(response_json, ThreadsListSerializer(new_thread).data)
- # did posts move to new thread?
- for post in Post.objects.filter(id__in=posts_ids):
- self.assertEqual(post.thread_id, new_thread.id)
- # are old threads gone?
- self.assertEqual([t.pk for t in Thread.objects.all()], [new_thread.pk])
|