test_thread_pollvotes_api.py 13 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398
  1. from datetime import timedelta
  2. from django.contrib.auth import get_user_model
  3. from django.urls import reverse
  4. from django.utils import timezone
  5. from misago.acl.test import patch_user_acl
  6. from misago.threads.models import Poll
  7. from misago.threads.test import patch_category_acl
  8. from .test_thread_poll_api import ThreadPollApiTestCase
  9. UserModel = get_user_model()
  10. class ThreadGetVotesTests(ThreadPollApiTestCase):
  11. def setUp(self):
  12. super().setUp()
  13. self.mock_poll()
  14. self.poll.is_public = True
  15. self.poll.save()
  16. self.api_link = reverse(
  17. 'misago:api:thread-poll-votes',
  18. kwargs={
  19. 'thread_pk': self.thread.pk,
  20. 'pk': self.poll.pk,
  21. }
  22. )
  23. def test_anonymous(self):
  24. """api allows guests to get poll votes"""
  25. self.logout_user()
  26. response = self.client.get(self.api_link)
  27. self.assertEqual(response.status_code, 200)
  28. def test_invalid_thread_id(self):
  29. """api validates that thread id is integer"""
  30. api_link = reverse(
  31. 'misago:api:thread-poll-votes',
  32. kwargs={
  33. 'thread_pk': 'kjha6dsa687sa',
  34. 'pk': self.poll.pk,
  35. }
  36. )
  37. response = self.client.get(api_link)
  38. self.assertEqual(response.status_code, 404)
  39. def test_nonexistant_thread_id(self):
  40. """api validates that thread exists"""
  41. api_link = reverse(
  42. 'misago:api:thread-poll-votes',
  43. kwargs={
  44. 'thread_pk': self.thread.pk + 1,
  45. 'pk': self.poll.pk,
  46. }
  47. )
  48. response = self.client.get(api_link)
  49. self.assertEqual(response.status_code, 404)
  50. def test_invalid_poll_id(self):
  51. """api validates that poll id is integer"""
  52. api_link = reverse(
  53. 'misago:api:thread-poll-votes',
  54. kwargs={
  55. 'thread_pk': self.thread.pk,
  56. 'pk': 'sad98as7d97sa98',
  57. }
  58. )
  59. response = self.client.get(api_link)
  60. self.assertEqual(response.status_code, 404)
  61. def test_nonexistant_poll_id(self):
  62. """api validates that poll exists"""
  63. api_link = reverse(
  64. 'misago:api:thread-poll-votes',
  65. kwargs={
  66. 'thread_pk': self.thread.pk,
  67. 'pk': self.poll.pk + 123,
  68. }
  69. )
  70. response = self.client.get(api_link)
  71. self.assertEqual(response.status_code, 404)
  72. @patch_user_acl({"can_always_see_poll_voters": False})
  73. def test_no_permission(self):
  74. """api chcecks permission to see poll voters"""
  75. self.poll.is_public = False
  76. self.poll.save()
  77. response = self.client.get(self.api_link)
  78. self.assertEqual(response.status_code, 403)
  79. def test_nonpublic_poll(self):
  80. """api validates that poll is public"""
  81. self.logout_user()
  82. self.poll.is_public = False
  83. self.poll.save()
  84. response = self.client.get(self.api_link)
  85. self.assertEqual(response.status_code, 403)
  86. def test_get_votes(self):
  87. """api returns list of voters"""
  88. response = self.client.get(self.api_link)
  89. self.assertEqual(response.status_code, 200)
  90. response_json = response.json()
  91. self.assertEqual(len(response_json), 4)
  92. self.assertEqual([c['label'] for c in response_json], ['Alpha', 'Beta', 'Gamma', 'Delta'])
  93. self.assertEqual([c['votes'] for c in response_json], [1, 0, 2, 1])
  94. self.assertEqual([len(c['voters']) for c in response_json], [1, 0, 2, 1])
  95. self.assertEqual([[v['username'] for v in c['voters']] for c in response_json][0][0],
  96. 'bob')
  97. user = UserModel.objects.get(slug='bob')
  98. self.assertEqual([[v['url'] for v in c['voters']] for c in response_json][0][0],
  99. user.get_absolute_url())
  100. @patch_user_acl({"can_always_see_poll_voters": True})
  101. def test_get_votes_private_poll(self):
  102. """api returns list of voters on private poll for user with permission"""
  103. self.poll.is_public = False
  104. self.poll.save()
  105. response = self.client.get(self.api_link)
  106. self.assertEqual(response.status_code, 200)
  107. response_json = response.json()
  108. self.assertEqual(len(response_json), 4)
  109. self.assertEqual([c['label'] for c in response_json], ['Alpha', 'Beta', 'Gamma', 'Delta'])
  110. self.assertEqual([c['votes'] for c in response_json], [1, 0, 2, 1])
  111. self.assertEqual([len(c['voters']) for c in response_json], [1, 0, 2, 1])
  112. self.assertEqual([[v['username'] for v in c['voters']] for c in response_json][0][0],
  113. 'bob')
  114. user = UserModel.objects.get(slug='bob')
  115. self.assertEqual([[v['url'] for v in c['voters']] for c in response_json][0][0],
  116. user.get_absolute_url())
  117. class ThreadPostVotesTests(ThreadPollApiTestCase):
  118. def setUp(self):
  119. super().setUp()
  120. self.mock_poll()
  121. self.api_link = reverse(
  122. 'misago:api:thread-poll-votes',
  123. kwargs={
  124. 'thread_pk': self.thread.pk,
  125. 'pk': self.poll.pk,
  126. }
  127. )
  128. def delete_user_votes(self):
  129. self.poll.choices[2]['votes'] = 1
  130. self.poll.choices[3]['votes'] = 0
  131. self.poll.votes = 2
  132. self.poll.save()
  133. self.poll.pollvote_set.filter(voter=self.user).delete()
  134. def test_anonymous(self):
  135. """api requires you to sign in to vote in poll"""
  136. self.logout_user()
  137. response = self.post(self.api_link)
  138. self.assertEqual(response.status_code, 403)
  139. def test_empty_vote_json(self):
  140. """api validates if vote that user has made was empty"""
  141. self.delete_user_votes()
  142. response = self.client.post(
  143. self.api_link, '[]', content_type='application/json'
  144. )
  145. self.assertEqual(response.status_code, 400)
  146. self.assertEqual(response.json(), {
  147. "detail": "You have to make a choice.",
  148. })
  149. def test_empty_vote_form(self):
  150. """api validates if vote that user has made was empty"""
  151. self.delete_user_votes()
  152. response = self.client.post(self.api_link)
  153. self.assertEqual(response.status_code, 400)
  154. self.assertEqual(response.json(), {
  155. "detail": "You have to make a choice.",
  156. })
  157. def test_malformed_vote(self):
  158. """api validates if vote that user has made was correctly structured"""
  159. self.delete_user_votes()
  160. response = self.post(self.api_link)
  161. self.assertEqual(response.status_code, 400)
  162. self.assertEqual(response.json(), {
  163. "detail": 'Expected a list of items but got type "dict".',
  164. })
  165. response = self.post(self.api_link, data={})
  166. self.assertEqual(response.status_code, 400)
  167. self.assertEqual(response.json(), {
  168. "detail": 'Expected a list of items but got type "dict".',
  169. })
  170. response = self.post(self.api_link, data='hello')
  171. self.assertEqual(response.status_code, 400)
  172. self.assertEqual(response.json(), {
  173. "detail": 'Expected a list of items but got type "str".',
  174. })
  175. response = self.post(self.api_link, data=123)
  176. self.assertEqual(response.status_code, 400)
  177. self.assertEqual(response.json(), {
  178. "detail": 'Expected a list of items but got type "int".',
  179. })
  180. def test_invalid_choices(self):
  181. """api validates if vote that user has made overlaps with allowed votes"""
  182. self.delete_user_votes()
  183. response = self.post(self.api_link, data=['lorem', 'ipsum'])
  184. self.assertEqual(response.status_code, 400)
  185. self.assertEqual(response.json(), {
  186. "detail": "One or more of poll choices were invalid.",
  187. })
  188. def test_too_many_choices(self):
  189. """api validates if vote that user has made overlaps with allowed votes"""
  190. self.poll.allowed_choices = 1
  191. self.poll.allow_revotes = True
  192. self.poll.save()
  193. response = self.post(self.api_link, data=['aaaaaaaaaaaa', 'bbbbbbbbbbbb'])
  194. self.assertEqual(response.status_code, 400)
  195. self.assertEqual(response.json(), {
  196. "detail": "This poll disallows voting for more than 1 choice.",
  197. })
  198. def test_revote(self):
  199. """api validates if user is trying to change vote in poll that disallows revoting"""
  200. response = self.post(self.api_link, data=['lorem', 'ipsum'])
  201. self.assertEqual(response.status_code, 403)
  202. self.assertEqual(response.json(), {
  203. "detail": "You have already voted in this poll.",
  204. })
  205. self.delete_user_votes()
  206. response = self.post(self.api_link)
  207. self.assertEqual(response.status_code, 400)
  208. self.assertEqual(response.json(), {
  209. "detail": 'Expected a list of items but got type "dict".',
  210. })
  211. @patch_category_acl({"can_close_threads": False})
  212. def test_vote_in_closed_thread_no_permission(self):
  213. """api validates is user has permission to vote poll in closed thread"""
  214. self.thread.is_closed = True
  215. self.thread.save()
  216. self.delete_user_votes()
  217. response = self.post(self.api_link)
  218. self.assertEqual(response.status_code, 403)
  219. self.assertEqual(response.json(), {
  220. "detail": "This thread is closed. You can't vote in it.",
  221. })
  222. @patch_category_acl({"can_close_threads": True})
  223. def test_vote_in_closed_thread(self):
  224. """api validates is user has permission to vote poll in closed thread"""
  225. self.thread.is_closed = True
  226. self.thread.save()
  227. self.delete_user_votes()
  228. response = self.post(self.api_link)
  229. self.assertEqual(response.status_code, 400)
  230. @patch_category_acl({"can_close_threads": False})
  231. def test_vote_in_closed_category_no_permission(self):
  232. """api validates is user has permission to vote poll in closed category"""
  233. self.category.is_closed = True
  234. self.category.save()
  235. self.delete_user_votes()
  236. response = self.post(self.api_link)
  237. self.assertEqual(response.status_code, 403)
  238. self.assertEqual(response.json(), {
  239. "detail": "This category is closed. You can't vote in it.",
  240. })
  241. @patch_category_acl({"can_close_threads": True})
  242. def test_vote_in_closed_category(self):
  243. """api validates is user has permission to vote poll in closed category"""
  244. self.category.is_closed = True
  245. self.category.save()
  246. self.delete_user_votes()
  247. response = self.post(self.api_link)
  248. self.assertEqual(response.status_code, 400)
  249. def test_vote_in_finished_poll(self):
  250. """api valdiates if poll has finished before letting user to vote in it"""
  251. self.poll.posted_on = timezone.now() - timedelta(days=15)
  252. self.poll.length = 5
  253. self.poll.save()
  254. self.delete_user_votes()
  255. response = self.post(self.api_link)
  256. self.assertEqual(response.status_code, 403)
  257. self.assertEqual(response.json(), {
  258. "detail": "This poll is over. You can't vote in it.",
  259. })
  260. self.poll.length = 50
  261. self.poll.save()
  262. response = self.post(self.api_link)
  263. self.assertEqual(response.status_code, 400)
  264. self.assertEqual(response.json(), {
  265. "detail": 'Expected a list of items but got type "dict".',
  266. })
  267. def test_fresh_vote(self):
  268. """api handles first vote in poll"""
  269. self.delete_user_votes()
  270. response = self.post(self.api_link, data=['aaaaaaaaaaaa', 'bbbbbbbbbbbb'])
  271. self.assertEqual(response.status_code, 200)
  272. # validate state change
  273. poll = Poll.objects.get(pk=self.poll.pk)
  274. self.assertEqual(poll.votes, 4)
  275. self.assertEqual([c['votes'] for c in poll.choices], [2, 1, 1, 0])
  276. for choice in poll.choices:
  277. self.assertNotIn('selected', choice)
  278. self.assertEqual(poll.pollvote_set.count(), 4)
  279. # validate response json
  280. response_json = response.json()
  281. self.assertEqual(response_json['votes'], 4)
  282. self.assertEqual([c['votes'] for c in response_json['choices']], [2, 1, 1, 0])
  283. self.assertEqual([c['selected'] for c in response_json['choices']],
  284. [True, True, False, False])
  285. self.assertFalse(response_json['acl']['can_vote'])
  286. def test_vote_change(self):
  287. """api handles vote change"""
  288. self.poll.allow_revotes = True
  289. self.poll.save()
  290. response = self.post(self.api_link, data=['aaaaaaaaaaaa', 'bbbbbbbbbbbb'])
  291. self.assertEqual(response.status_code, 200)
  292. # validate state change
  293. poll = Poll.objects.get(pk=self.poll.pk)
  294. self.assertEqual(poll.votes, 4)
  295. self.assertEqual([c['votes'] for c in poll.choices], [2, 1, 1, 0])
  296. for choice in poll.choices:
  297. self.assertNotIn('selected', choice)
  298. self.assertEqual(poll.pollvote_set.count(), 4)
  299. # validate response json
  300. response_json = response.json()
  301. self.assertEqual(response_json['votes'], 4)
  302. self.assertEqual([c['votes'] for c in response_json['choices']], [2, 1, 1, 0])
  303. self.assertEqual([c['selected'] for c in response_json['choices']],
  304. [True, True, False, False])
  305. self.assertTrue(response_json['acl']['can_vote'])