test_threads_merge_api.py 32 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968969970971972973974975976977978979980981982
  1. import json
  2. from django.urls import reverse
  3. from misago.acl import add_acl
  4. from misago.acl.testutils import override_acl
  5. from misago.categories.models import Category
  6. from misago.readtracker import poststracker
  7. from misago.threads import testutils
  8. from misago.threads.serializers.moderation import THREADS_LIMIT
  9. from misago.threads.models import Poll, PollVote, Post, Thread
  10. from misago.threads.serializers import ThreadsListSerializer
  11. from .test_threads_api import ThreadsApiTestCase
  12. class ThreadsMergeApiTests(ThreadsApiTestCase):
  13. def setUp(self):
  14. super(ThreadsMergeApiTests, self).setUp()
  15. self.api_link = reverse('misago:api:thread-merge')
  16. Category(
  17. name='Category B',
  18. slug='category-b',
  19. ).insert_at(
  20. self.category,
  21. position='last-child',
  22. save=True,
  23. )
  24. self.category_b = Category.objects.get(slug='category-b')
  25. def override_other_category(self):
  26. categories = self.user.acl_cache['categories']
  27. visible_categories = self.user.acl_cache['visible_categories']
  28. browseable_categories = self.user.acl_cache['browseable_categories']
  29. visible_categories.append(self.category_b.pk)
  30. browseable_categories.append(self.category_b.pk)
  31. override_acl(
  32. self.user, {
  33. 'visible_categories': visible_categories,
  34. 'browseable_categories': browseable_categories,
  35. 'categories': {
  36. self.category.pk: categories[self.category.pk],
  37. self.category_b.pk: {
  38. 'can_see': 1,
  39. 'can_browse': 1,
  40. 'can_see_all_threads': 1,
  41. 'can_see_own_threads': 0,
  42. 'can_start_threads': 2,
  43. },
  44. },
  45. }
  46. )
  47. def test_merge_no_threads(self):
  48. """api validates if we are trying to merge no threads"""
  49. response = self.client.post(self.api_link, content_type="application/json")
  50. self.assertEqual(response.status_code, 403)
  51. response_json = response.json()
  52. self.assertEqual(
  53. response_json, {
  54. 'detail': "You have to select at least two threads to merge.",
  55. }
  56. )
  57. def test_merge_empty_threads(self):
  58. """api validates if we are trying to empty threads list"""
  59. response = self.client.post(
  60. self.api_link,
  61. json.dumps({
  62. 'threads': [],
  63. }),
  64. content_type="application/json",
  65. )
  66. self.assertEqual(response.status_code, 403)
  67. response_json = response.json()
  68. self.assertEqual(
  69. response_json, {
  70. 'detail': "You have to select at least two threads to merge.",
  71. }
  72. )
  73. def test_merge_invalid_threads(self):
  74. """api validates if we are trying to merge invalid thread ids"""
  75. response = self.client.post(
  76. self.api_link,
  77. json.dumps({
  78. 'threads': 'abcd',
  79. }),
  80. content_type="application/json",
  81. )
  82. self.assertContains(response, "Expected a list of items", status_code=403)
  83. response = self.client.post(
  84. self.api_link,
  85. json.dumps({
  86. 'threads': ['a', '-', 'c'],
  87. }),
  88. content_type="application/json",
  89. )
  90. self.assertEqual(response.status_code, 403)
  91. response_json = response.json()
  92. self.assertEqual(
  93. response_json, {
  94. 'detail': "One or more thread ids received were invalid.",
  95. }
  96. )
  97. def test_merge_single_thread(self):
  98. """api validates if we are trying to merge single thread"""
  99. response = self.client.post(
  100. self.api_link,
  101. json.dumps({
  102. 'threads': [self.thread.id],
  103. }),
  104. content_type="application/json",
  105. )
  106. self.assertEqual(response.status_code, 403)
  107. response_json = response.json()
  108. self.assertEqual(
  109. response_json, {
  110. 'detail': "You have to select at least two threads to merge.",
  111. }
  112. )
  113. def test_merge_with_nonexisting_thread(self):
  114. """api validates if we are trying to merge with invalid thread"""
  115. response = self.client.post(
  116. self.api_link,
  117. json.dumps({
  118. 'threads': [self.thread.id, self.thread.id + 1000],
  119. }),
  120. content_type="application/json",
  121. )
  122. self.assertEqual(response.status_code, 403)
  123. response_json = response.json()
  124. self.assertEqual(
  125. response_json, {
  126. 'detail': "One or more threads to merge could not be found.",
  127. }
  128. )
  129. def test_merge_with_invisible_thread(self):
  130. """api validates if we are trying to merge with inaccesible thread"""
  131. unaccesible_thread = testutils.post_thread(category=self.category_b)
  132. response = self.client.post(
  133. self.api_link,
  134. json.dumps({
  135. 'threads': [self.thread.id, unaccesible_thread.id],
  136. }),
  137. content_type="application/json",
  138. )
  139. self.assertEqual(response.status_code, 403)
  140. response_json = response.json()
  141. self.assertEqual(
  142. response_json, {
  143. 'detail': "One or more threads to merge could not be found.",
  144. }
  145. )
  146. def test_merge_no_permission(self):
  147. """api validates permission to merge threads"""
  148. thread = testutils.post_thread(category=self.category)
  149. response = self.client.post(
  150. self.api_link,
  151. json.dumps({
  152. 'category': self.category.pk,
  153. 'title': 'Lorem ipsum dolor',
  154. 'threads': [self.thread.id, thread.id],
  155. }),
  156. content_type="application/json",
  157. )
  158. self.assertEqual(response.status_code, 403)
  159. response_json = response.json()
  160. self.assertEqual(
  161. response_json, [
  162. {
  163. 'id': thread.pk,
  164. 'title': thread.title,
  165. 'errors': ["You can't merge threads in this category."],
  166. },
  167. {
  168. 'id': self.thread.pk,
  169. 'title': self.thread.title,
  170. 'errors': ["You can't merge threads in this category."],
  171. },
  172. ]
  173. )
  174. def test_thread_category_is_closed(self):
  175. """api validates if thread's category is open"""
  176. self.override_acl({
  177. 'can_merge_threads': 1,
  178. 'can_close_threads': 0,
  179. })
  180. self.override_other_category()
  181. other_thread = testutils.post_thread(self.category)
  182. self.category.is_closed = True
  183. self.category.save()
  184. response = self.client.post(
  185. self.api_link,
  186. json.dumps({
  187. 'category': self.category_b.pk,
  188. 'title': 'Lorem ipsum dolor',
  189. 'threads': [self.thread.id, other_thread.id],
  190. }),
  191. content_type="application/json",
  192. )
  193. self.assertContains(
  194. response,
  195. "This category is closed. You can't merge it's threads.",
  196. status_code=403,
  197. )
  198. def test_thread_is_closed(self):
  199. """api validates if thread is open"""
  200. self.override_acl({
  201. 'can_merge_threads': 1,
  202. 'can_close_threads': 0,
  203. })
  204. self.override_other_category()
  205. other_thread = testutils.post_thread(self.category)
  206. other_thread.is_closed = True
  207. other_thread.save()
  208. response = self.client.post(
  209. self.api_link,
  210. json.dumps({
  211. 'category': self.category_b.pk,
  212. 'title': 'Lorem ipsum dolor',
  213. 'threads': [self.thread.id, other_thread.id],
  214. }),
  215. content_type="application/json",
  216. )
  217. self.assertContains(
  218. response,
  219. "This thread is closed. You can't merge it with other threads.",
  220. status_code=403,
  221. )
  222. def test_merge_too_many_threads(self):
  223. """api rejects too many threads to merge"""
  224. threads = []
  225. for _ in range(THREADS_LIMIT + 1):
  226. threads.append(testutils.post_thread(category=self.category).pk)
  227. self.override_acl({
  228. 'can_merge_threads': True,
  229. 'can_close_threads': False,
  230. 'can_edit_threads': False,
  231. 'can_reply_threads': False,
  232. })
  233. response = self.client.post(
  234. self.api_link,
  235. json.dumps({
  236. 'threads': threads,
  237. }),
  238. content_type="application/json",
  239. )
  240. self.assertEqual(response.status_code, 403)
  241. response_json = response.json()
  242. self.assertEqual(
  243. response_json, {
  244. 'detail': "No more than %s threads can be merged at single time." % THREADS_LIMIT,
  245. }
  246. )
  247. def test_merge_no_final_thread(self):
  248. """api rejects merge because no data to merge threads was specified"""
  249. self.override_acl({
  250. 'can_merge_threads': True,
  251. 'can_close_threads': False,
  252. 'can_edit_threads': False,
  253. 'can_reply_threads': False,
  254. })
  255. thread = testutils.post_thread(category=self.category)
  256. response = self.client.post(
  257. self.api_link,
  258. json.dumps({
  259. 'threads': [self.thread.id, thread.id],
  260. }),
  261. content_type="application/json",
  262. )
  263. self.assertEqual(response.status_code, 400)
  264. response_json = response.json()
  265. self.assertEqual(
  266. response_json, {
  267. 'title': ['This field is required.'],
  268. 'category': ['This field is required.'],
  269. }
  270. )
  271. def test_merge_invalid_final_title(self):
  272. """api rejects merge because final thread title was invalid"""
  273. self.override_acl({
  274. 'can_merge_threads': True,
  275. 'can_close_threads': False,
  276. 'can_edit_threads': False,
  277. 'can_reply_threads': False,
  278. })
  279. thread = testutils.post_thread(category=self.category)
  280. response = self.client.post(
  281. self.api_link,
  282. json.dumps({
  283. 'threads': [self.thread.id, thread.id],
  284. 'title': '$$$',
  285. 'category': self.category.id,
  286. }),
  287. content_type="application/json",
  288. )
  289. self.assertEqual(response.status_code, 400)
  290. response_json = response.json()
  291. self.assertEqual(
  292. response_json, {
  293. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  294. }
  295. )
  296. def test_merge_invalid_category(self):
  297. """api rejects merge because final category was invalid"""
  298. self.override_acl({
  299. 'can_merge_threads': True,
  300. 'can_close_threads': False,
  301. 'can_edit_threads': False,
  302. 'can_reply_threads': False,
  303. })
  304. thread = testutils.post_thread(category=self.category)
  305. response = self.client.post(
  306. self.api_link,
  307. json.dumps({
  308. 'threads': [self.thread.id, thread.id],
  309. 'title': 'Valid thread title',
  310. 'category': self.category_b.id,
  311. }),
  312. content_type="application/json",
  313. )
  314. self.assertEqual(response.status_code, 400)
  315. response_json = response.json()
  316. self.assertEqual(
  317. response_json, {
  318. 'category': ["Requested category could not be found."],
  319. }
  320. )
  321. def test_merge_unallowed_start_thread(self):
  322. """api rejects merge because category isn't allowing starting threads"""
  323. self.override_acl({
  324. 'can_merge_threads': True,
  325. 'can_close_threads': False,
  326. 'can_edit_threads': False,
  327. 'can_reply_threads': False,
  328. 'can_start_threads': 0,
  329. })
  330. thread = testutils.post_thread(category=self.category)
  331. response = self.client.post(
  332. self.api_link,
  333. json.dumps({
  334. 'threads': [self.thread.id, thread.id],
  335. 'title': 'Valid thread title',
  336. 'category': self.category.id,
  337. }),
  338. content_type="application/json",
  339. )
  340. self.assertEqual(response.status_code, 400)
  341. response_json = response.json()
  342. self.assertEqual(
  343. response_json, {
  344. 'category': ["You can't create new threads in selected category."],
  345. }
  346. )
  347. def test_merge_invalid_weight(self):
  348. """api rejects merge because final weight was invalid"""
  349. self.override_acl({
  350. 'can_merge_threads': True,
  351. 'can_close_threads': False,
  352. 'can_edit_threads': False,
  353. 'can_reply_threads': False,
  354. })
  355. thread = testutils.post_thread(category=self.category)
  356. response = self.client.post(
  357. self.api_link,
  358. json.dumps({
  359. 'threads': [self.thread.id, thread.id],
  360. 'title': 'Valid thread title',
  361. 'category': self.category.id,
  362. 'weight': 4,
  363. }),
  364. content_type="application/json",
  365. )
  366. self.assertEqual(response.status_code, 400)
  367. response_json = response.json()
  368. self.assertEqual(
  369. response_json, {
  370. 'weight': ["Ensure this value is less than or equal to 2."],
  371. }
  372. )
  373. def test_merge_unallowed_global_weight(self):
  374. """api rejects merge because global weight was unallowed"""
  375. self.override_acl({
  376. 'can_merge_threads': True,
  377. 'can_close_threads': False,
  378. 'can_edit_threads': False,
  379. 'can_reply_threads': False,
  380. })
  381. thread = testutils.post_thread(category=self.category)
  382. response = self.client.post(
  383. self.api_link,
  384. json.dumps({
  385. 'threads': [self.thread.id, thread.id],
  386. 'title': 'Valid thread title',
  387. 'category': self.category.id,
  388. 'weight': 2,
  389. }),
  390. content_type="application/json",
  391. )
  392. self.assertEqual(response.status_code, 400)
  393. response_json = response.json()
  394. self.assertEqual(
  395. response_json, {
  396. 'weight': ["You don't have permission to pin threads globally in this category."],
  397. }
  398. )
  399. def test_merge_unallowed_local_weight(self):
  400. """api rejects merge because local weight was unallowed"""
  401. self.override_acl({
  402. 'can_merge_threads': True,
  403. 'can_close_threads': False,
  404. 'can_edit_threads': False,
  405. 'can_reply_threads': False,
  406. })
  407. thread = testutils.post_thread(category=self.category)
  408. response = self.client.post(
  409. self.api_link,
  410. json.dumps({
  411. 'threads': [self.thread.id, thread.id],
  412. 'title': 'Valid thread title',
  413. 'category': self.category.id,
  414. 'weight': 1,
  415. }),
  416. content_type="application/json",
  417. )
  418. self.assertEqual(response.status_code, 400)
  419. response_json = response.json()
  420. self.assertEqual(
  421. response_json, {
  422. 'weight': ["You don't have permission to pin threads in this category."],
  423. }
  424. )
  425. def test_merge_allowed_local_weight(self):
  426. """api allows local weight"""
  427. self.override_acl({
  428. 'can_merge_threads': True,
  429. 'can_close_threads': False,
  430. 'can_edit_threads': False,
  431. 'can_reply_threads': False,
  432. 'can_pin_threads': 1,
  433. })
  434. thread = testutils.post_thread(category=self.category)
  435. response = self.client.post(
  436. self.api_link,
  437. json.dumps({
  438. 'threads': [self.thread.id, thread.id],
  439. 'title': '$$$',
  440. 'category': self.category.id,
  441. 'weight': 1,
  442. }),
  443. content_type="application/json",
  444. )
  445. self.assertEqual(response.status_code, 400)
  446. response_json = response.json()
  447. self.assertEqual(
  448. response_json, {
  449. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  450. }
  451. )
  452. def test_merge_allowed_global_weight(self):
  453. """api allows global weight"""
  454. self.override_acl({
  455. 'can_merge_threads': True,
  456. 'can_close_threads': False,
  457. 'can_edit_threads': False,
  458. 'can_reply_threads': False,
  459. 'can_pin_threads': 2,
  460. })
  461. thread = testutils.post_thread(category=self.category)
  462. response = self.client.post(
  463. self.api_link,
  464. json.dumps({
  465. 'threads': [self.thread.id, thread.id],
  466. 'title': '$$$',
  467. 'category': self.category.id,
  468. 'weight': 2,
  469. }),
  470. content_type="application/json",
  471. )
  472. self.assertEqual(response.status_code, 400)
  473. response_json = response.json()
  474. self.assertEqual(
  475. response_json, {
  476. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  477. }
  478. )
  479. def test_merge_unallowed_close(self):
  480. """api rejects merge because closing thread was unallowed"""
  481. self.override_acl({
  482. 'can_merge_threads': True,
  483. 'can_close_threads': False,
  484. 'can_edit_threads': False,
  485. 'can_reply_threads': False,
  486. })
  487. thread = testutils.post_thread(category=self.category)
  488. response = self.client.post(
  489. self.api_link,
  490. json.dumps({
  491. 'threads': [self.thread.id, thread.id],
  492. 'title': 'Valid thread title',
  493. 'category': self.category.id,
  494. 'is_closed': True,
  495. }),
  496. content_type="application/json",
  497. )
  498. self.assertEqual(response.status_code, 400)
  499. response_json = response.json()
  500. self.assertEqual(
  501. response_json, {
  502. 'is_closed': ["You don't have permission to close threads in this category."],
  503. }
  504. )
  505. def test_merge_with_close(self):
  506. """api allows for closing thread"""
  507. self.override_acl({
  508. 'can_merge_threads': True,
  509. 'can_edit_threads': False,
  510. 'can_reply_threads': False,
  511. 'can_close_threads': True,
  512. })
  513. thread = testutils.post_thread(category=self.category)
  514. response = self.client.post(
  515. self.api_link,
  516. json.dumps({
  517. 'threads': [self.thread.id, thread.id],
  518. 'title': '$$$',
  519. 'category': self.category.id,
  520. 'weight': 0,
  521. 'is_closed': True,
  522. }),
  523. content_type="application/json",
  524. )
  525. self.assertEqual(response.status_code, 400)
  526. response_json = response.json()
  527. self.assertEqual(
  528. response_json, {
  529. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  530. }
  531. )
  532. def test_merge_unallowed_hidden(self):
  533. """api rejects merge because hidden thread was unallowed"""
  534. self.override_acl({
  535. 'can_merge_threads': True,
  536. 'can_close_threads': False,
  537. 'can_edit_threads': False,
  538. 'can_reply_threads': False,
  539. 'can_hide_threads': 0,
  540. })
  541. thread = testutils.post_thread(category=self.category)
  542. response = self.client.post(
  543. self.api_link,
  544. json.dumps({
  545. 'threads': [self.thread.id, thread.id],
  546. 'title': 'Valid thread title',
  547. 'category': self.category.id,
  548. 'is_hidden': True,
  549. }),
  550. content_type="application/json",
  551. )
  552. self.assertEqual(response.status_code, 400)
  553. response_json = response.json()
  554. self.assertEqual(
  555. response_json, {
  556. 'is_hidden': ["You don't have permission to hide threads in this category."],
  557. }
  558. )
  559. def test_merge_with_hide(self):
  560. """api allows for hiding thread"""
  561. self.override_acl({
  562. 'can_merge_threads': True,
  563. 'can_close_threads': False,
  564. 'can_edit_threads': False,
  565. 'can_reply_threads': False,
  566. 'can_hide_threads': 1,
  567. })
  568. thread = testutils.post_thread(category=self.category)
  569. response = self.client.post(
  570. self.api_link,
  571. json.dumps({
  572. 'threads': [self.thread.id, thread.id],
  573. 'title': '$$$',
  574. 'category': self.category.id,
  575. 'weight': 0,
  576. 'is_hidden': True,
  577. }),
  578. content_type="application/json",
  579. )
  580. self.assertEqual(response.status_code, 400)
  581. response_json = response.json()
  582. self.assertEqual(
  583. response_json, {
  584. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  585. }
  586. )
  587. def test_merge(self):
  588. """api performs basic merge"""
  589. posts_ids = [p.id for p in Post.objects.all()]
  590. self.override_acl({
  591. 'can_merge_threads': True,
  592. 'can_close_threads': False,
  593. 'can_edit_threads': False,
  594. 'can_reply_threads': False,
  595. })
  596. thread = testutils.post_thread(category=self.category)
  597. response = self.client.post(
  598. self.api_link,
  599. json.dumps({
  600. 'threads': [self.thread.id, thread.id],
  601. 'title': 'Merged thread!',
  602. 'category': self.category.id,
  603. }),
  604. content_type="application/json",
  605. )
  606. self.assertEqual(response.status_code, 200)
  607. # is response json with new thread?
  608. response_json = response.json()
  609. new_thread = Thread.objects.get(pk=response_json['id'])
  610. new_thread.is_read = False
  611. new_thread.subscription = None
  612. add_acl(self.user, new_thread.category)
  613. add_acl(self.user, new_thread)
  614. self.assertEqual(response_json, ThreadsListSerializer(new_thread).data)
  615. # did posts move to new thread?
  616. for post in Post.objects.filter(id__in=posts_ids):
  617. self.assertEqual(post.thread_id, new_thread.id)
  618. # are old threads gone?
  619. self.assertEqual([t.pk for t in Thread.objects.all()], [new_thread.pk])
  620. def test_merge_kitchensink(self):
  621. """api performs merge"""
  622. posts_ids = [p.id for p in Post.objects.all()]
  623. self.override_acl({
  624. 'can_merge_threads': True,
  625. 'can_close_threads': True,
  626. 'can_hide_threads': 1,
  627. 'can_pin_threads': 2,
  628. })
  629. thread = testutils.post_thread(category=self.category)
  630. poststracker.save_read(self.user, self.thread.first_post)
  631. poststracker.save_read(self.user, thread.first_post)
  632. response = self.client.post(
  633. self.api_link,
  634. json.dumps({
  635. 'threads': [self.thread.id, thread.id],
  636. 'title': 'Merged thread!',
  637. 'category': self.category.id,
  638. 'is_closed': 1,
  639. 'is_hidden': 1,
  640. 'weight': 2,
  641. }),
  642. content_type="application/json",
  643. )
  644. self.assertEqual(response.status_code, 200)
  645. # is response json with new thread?
  646. response_json = response.json()
  647. new_thread = Thread.objects.get(pk=response_json['id'])
  648. new_thread.is_read = False
  649. new_thread.subscription = None
  650. self.assertEqual(new_thread.weight, 2)
  651. self.assertTrue(new_thread.is_closed)
  652. self.assertTrue(new_thread.is_hidden)
  653. add_acl(self.user, new_thread.category)
  654. add_acl(self.user, new_thread)
  655. self.assertEqual(response_json, ThreadsListSerializer(new_thread).data)
  656. # did posts move to new thread?
  657. for post in Post.objects.filter(id__in=posts_ids):
  658. self.assertEqual(post.thread_id, new_thread.id)
  659. # are old threads gone?
  660. self.assertEqual([t.pk for t in Thread.objects.all()], [new_thread.pk])
  661. # posts reads are kept
  662. postread_set = self.user.postread_set.order_by('post_id')
  663. self.assertEqual(
  664. list(postread_set.values_list('post_id', flat=True)),
  665. [self.thread.first_post_id, thread.first_post_id]
  666. )
  667. self.assertEqual(postread_set.filter(thread=new_thread).count(), 2)
  668. self.assertEqual(postread_set.filter(category=self.category).count(), 2)
  669. def test_merge_threads_kept_poll(self):
  670. """api merges two threads successfully, keeping poll from old thread"""
  671. self.override_acl({'can_merge_threads': True})
  672. other_thread = testutils.post_thread(self.category)
  673. poll = testutils.post_poll(other_thread, self.user)
  674. response = self.client.post(
  675. self.api_link,
  676. json.dumps({
  677. 'threads': [self.thread.id, other_thread.id],
  678. 'title': 'Merged thread!',
  679. 'category': self.category.id,
  680. }),
  681. content_type="application/json",
  682. )
  683. self.assertEqual(response.status_code, 200)
  684. response_json = response.json()
  685. new_thread = Thread.objects.get(pk=response_json['id'])
  686. # poll and its votes were kept
  687. self.assertEqual(Poll.objects.filter(pk=poll.pk, thread=new_thread).count(), 1)
  688. self.assertEqual(PollVote.objects.filter(poll=poll, thread=new_thread).count(), 4)
  689. self.assertEqual(Poll.objects.count(), 1)
  690. self.assertEqual(PollVote.objects.count(), 4)
  691. def test_merge_threads_moved_poll(self):
  692. """api merges two threads successfully, moving poll from other thread"""
  693. self.override_acl({'can_merge_threads': True})
  694. other_thread = testutils.post_thread(self.category)
  695. poll = testutils.post_poll(self.thread, self.user)
  696. response = self.client.post(
  697. self.api_link,
  698. json.dumps({
  699. 'threads': [self.thread.id, other_thread.id],
  700. 'title': 'Merged thread!',
  701. 'category': self.category.id,
  702. }),
  703. content_type="application/json",
  704. )
  705. self.assertEqual(response.status_code, 200)
  706. response_json = response.json()
  707. new_thread = Thread.objects.get(pk=response_json['id'])
  708. # poll and its votes were kept
  709. self.assertEqual(Poll.objects.filter(pk=poll.pk, thread=new_thread).count(), 1)
  710. self.assertEqual(PollVote.objects.filter(poll=poll, thread=new_thread).count(), 4)
  711. self.assertEqual(Poll.objects.count(), 1)
  712. self.assertEqual(PollVote.objects.count(), 4)
  713. def test_threads_merge_conflict(self):
  714. """api errors on merge conflict, returning list of available polls"""
  715. self.override_acl({'can_merge_threads': True})
  716. other_thread = testutils.post_thread(self.category)
  717. poll = testutils.post_poll(self.thread, self.user)
  718. other_poll = testutils.post_poll(other_thread, self.user)
  719. response = self.client.post(
  720. self.api_link,
  721. json.dumps({
  722. 'threads': [self.thread.id, other_thread.id],
  723. 'title': 'Merged thread!',
  724. 'category': self.category.id,
  725. }),
  726. content_type="application/json",
  727. )
  728. self.assertEqual(response.status_code, 400)
  729. self.assertEqual(
  730. response.json(), {
  731. 'polls': [
  732. [0, "Delete all polls"],
  733. [poll.pk, poll.question],
  734. [other_poll.pk, other_poll.question],
  735. ],
  736. }
  737. )
  738. # polls and votes were untouched
  739. self.assertEqual(Poll.objects.count(), 2)
  740. self.assertEqual(PollVote.objects.count(), 8)
  741. def test_threads_merge_conflict_invalid_resolution(self):
  742. """api errors on invalid merge conflict resolution"""
  743. self.override_acl({'can_merge_threads': True})
  744. other_thread = testutils.post_thread(self.category)
  745. testutils.post_poll(self.thread, self.user)
  746. testutils.post_poll(other_thread, self.user)
  747. response = self.client.post(
  748. self.api_link,
  749. json.dumps({
  750. 'threads': [self.thread.id, other_thread.id],
  751. 'title': 'Merged thread!',
  752. 'category': self.category.id,
  753. 'poll': 'dsa7dsadsa9789',
  754. }),
  755. content_type="application/json",
  756. )
  757. self.assertEqual(response.status_code, 400)
  758. self.assertEqual(response.json(), {
  759. 'detail': "Invalid choice.",
  760. })
  761. # polls and votes were untouched
  762. self.assertEqual(Poll.objects.count(), 2)
  763. self.assertEqual(PollVote.objects.count(), 8)
  764. def test_threads_merge_conflict_delete_all(self):
  765. """api deletes all polls when delete all choice is selected"""
  766. self.override_acl({'can_merge_threads': True})
  767. other_thread = testutils.post_thread(self.category)
  768. testutils.post_poll(self.thread, self.user)
  769. testutils.post_poll(other_thread, self.user)
  770. response = self.client.post(
  771. self.api_link,
  772. json.dumps({
  773. 'threads': [self.thread.id, other_thread.id],
  774. 'title': 'Merged thread!',
  775. 'category': self.category.id,
  776. 'poll': 0,
  777. }),
  778. content_type="application/json",
  779. )
  780. self.assertEqual(response.status_code, 200)
  781. # polls and votes are gone
  782. self.assertEqual(Poll.objects.count(), 0)
  783. self.assertEqual(PollVote.objects.count(), 0)
  784. def test_threads_merge_conflict_keep_first_poll(self):
  785. """api deletes other poll on merge"""
  786. self.override_acl({'can_merge_threads': True})
  787. other_thread = testutils.post_thread(self.category)
  788. poll = testutils.post_poll(self.thread, self.user)
  789. other_poll = testutils.post_poll(other_thread, self.user)
  790. response = self.client.post(
  791. self.api_link,
  792. json.dumps({
  793. 'threads': [self.thread.id, other_thread.id],
  794. 'title': 'Merged thread!',
  795. 'category': self.category.id,
  796. 'poll': poll.pk,
  797. }),
  798. content_type="application/json",
  799. )
  800. self.assertEqual(response.status_code, 200)
  801. # other poll and its votes are gone
  802. self.assertEqual(Poll.objects.count(), 1)
  803. self.assertEqual(PollVote.objects.count(), 4)
  804. Poll.objects.get(pk=poll.pk)
  805. with self.assertRaises(Poll.DoesNotExist):
  806. Poll.objects.get(pk=other_poll.pk)
  807. def test_threads_merge_conflict_keep_other_poll(self):
  808. """api deletes first poll on merge"""
  809. self.override_acl({'can_merge_threads': True})
  810. other_thread = testutils.post_thread(self.category)
  811. poll = testutils.post_poll(self.thread, self.user)
  812. other_poll = testutils.post_poll(other_thread, self.user)
  813. response = self.client.post(
  814. self.api_link,
  815. json.dumps({
  816. 'threads': [self.thread.id, other_thread.id],
  817. 'title': 'Merged thread!',
  818. 'category': self.category.id,
  819. 'poll': other_poll.pk,
  820. }),
  821. content_type="application/json",
  822. )
  823. self.assertEqual(response.status_code, 200)
  824. # other poll and its votes are gone
  825. self.assertEqual(Poll.objects.count(), 1)
  826. self.assertEqual(PollVote.objects.count(), 4)
  827. Poll.objects.get(pk=other_poll.pk)
  828. with self.assertRaises(Poll.DoesNotExist):
  829. Poll.objects.get(pk=poll.pk)