test_thread_postmerge_api.py 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540
  1. # -*- coding: utf-8 -*-
  2. from __future__ import unicode_literals
  3. import json
  4. from django.urls import reverse
  5. from misago.acl.testutils import override_acl
  6. from misago.categories.models import Category
  7. from misago.readtracker import poststracker
  8. from misago.threads import testutils
  9. from misago.threads.models import Post, Thread
  10. from misago.threads.serializers.moderation import POSTS_LIMIT
  11. from misago.users.testutils import AuthenticatedUserTestCase
  12. class ThreadPostMergeApiTestCase(AuthenticatedUserTestCase):
  13. def setUp(self):
  14. super(ThreadPostMergeApiTestCase, self).setUp()
  15. self.category = Category.objects.get(slug='first-category')
  16. self.thread = testutils.post_thread(category=self.category)
  17. self.post = testutils.reply_thread(self.thread, poster=self.user)
  18. self.api_link = reverse(
  19. 'misago:api:thread-post-merge', kwargs={
  20. 'thread_pk': self.thread.pk,
  21. }
  22. )
  23. self.override_acl()
  24. def refresh_thread(self):
  25. self.thread = Thread.objects.get(pk=self.thread.pk)
  26. def override_acl(self, extra_acl=None):
  27. new_acl = self.user.acl_cache
  28. new_acl['categories'][self.category.pk].update({
  29. 'can_see': 1,
  30. 'can_browse': 1,
  31. 'can_start_threads': 0,
  32. 'can_reply_threads': 0,
  33. 'can_edit_posts': 1,
  34. 'can_approve_content': 0,
  35. 'can_merge_posts': 1,
  36. })
  37. if extra_acl:
  38. new_acl['categories'][self.category.pk].update(extra_acl)
  39. override_acl(self.user, new_acl)
  40. def test_anonymous_user(self):
  41. """you need to authenticate to merge posts"""
  42. self.logout_user()
  43. response = self.client.post(
  44. self.api_link,
  45. json.dumps({}),
  46. content_type="application/json",
  47. )
  48. self.assertEqual(response.status_code, 403)
  49. def test_no_permission(self):
  50. """api validates permission to merge"""
  51. self.override_acl({'can_merge_posts': 0})
  52. response = self.client.post(
  53. self.api_link,
  54. json.dumps({}),
  55. content_type="application/json",
  56. )
  57. self.assertContains(response, "You can't merge posts in this thread.", status_code=403)
  58. def test_empty_data_json(self):
  59. """api handles empty json data"""
  60. response = self.client.post(
  61. self.api_link, json.dumps({}), content_type="application/json"
  62. )
  63. self.assertContains(
  64. response, "You have to select at least two posts to merge.", status_code=400
  65. )
  66. def test_empty_data_form(self):
  67. """api handles empty form data"""
  68. response = self.client.post(self.api_link, {})
  69. self.assertContains(
  70. response, "You have to select at least two posts to merge.", status_code=400
  71. )
  72. def test_invalid_data(self):
  73. """api handles post that is invalid type"""
  74. self.override_acl()
  75. response = self.client.post(self.api_link, '[]', content_type="application/json")
  76. self.assertContains(response, "Invalid data. Expected a dictionary", status_code=400)
  77. self.override_acl()
  78. response = self.client.post(self.api_link, '123', content_type="application/json")
  79. self.assertContains(response, "Invalid data. Expected a dictionary", status_code=400)
  80. self.override_acl()
  81. response = self.client.post(self.api_link, '"string"', content_type="application/json")
  82. self.assertContains(response, "Invalid data. Expected a dictionary", status_code=400)
  83. self.override_acl()
  84. response = self.client.post(self.api_link, 'malformed', content_type="application/json")
  85. self.assertContains(response, "JSON parse error", status_code=400)
  86. def test_no_posts_ids(self):
  87. """api rejects no posts ids"""
  88. response = self.client.post(
  89. self.api_link,
  90. json.dumps({
  91. 'posts': []
  92. }),
  93. content_type="application/json",
  94. )
  95. self.assertContains(
  96. response, "You have to select at least two posts to merge.", status_code=400
  97. )
  98. def test_invalid_posts_data(self):
  99. """api handles invalid data"""
  100. response = self.client.post(
  101. self.api_link,
  102. json.dumps({
  103. 'posts': 'string'
  104. }),
  105. content_type="application/json",
  106. )
  107. self.assertContains(
  108. response, "Expected a list of items but got type", status_code=400
  109. )
  110. def test_invalid_posts_ids(self):
  111. """api handles invalid post id"""
  112. response = self.client.post(
  113. self.api_link,
  114. json.dumps({
  115. 'posts': [1, 2, 'string']
  116. }),
  117. content_type="application/json",
  118. )
  119. self.assertContains(
  120. response, "One or more post ids received were invalid.", status_code=400
  121. )
  122. def test_one_post_id(self):
  123. """api rejects one post id"""
  124. response = self.client.post(
  125. self.api_link,
  126. json.dumps({
  127. 'posts': [1]
  128. }),
  129. content_type="application/json",
  130. )
  131. self.assertContains(
  132. response, "You have to select at least two posts to merge.", status_code=400
  133. )
  134. def test_merge_limit(self):
  135. """api rejects more posts than merge limit"""
  136. response = self.client.post(
  137. self.api_link,
  138. json.dumps({
  139. 'posts': list(range(POSTS_LIMIT + 1))
  140. }),
  141. content_type="application/json",
  142. )
  143. self.assertContains(
  144. response, "No more than {} posts can be merged".format(POSTS_LIMIT), status_code=400
  145. )
  146. def test_merge_event(self):
  147. """api recjects events"""
  148. event = testutils.reply_thread(self.thread, is_event=True, poster=self.user)
  149. response = self.client.post(
  150. self.api_link,
  151. json.dumps({
  152. 'posts': [self.post.pk, event.pk]
  153. }),
  154. content_type="application/json",
  155. )
  156. self.assertContains(response, "Events can't be merged.", status_code=400)
  157. def test_merge_notfound_pk(self):
  158. """api recjects nonexistant pk's"""
  159. response = self.client.post(
  160. self.api_link,
  161. json.dumps({
  162. 'posts': [self.post.pk, self.post.pk * 1000]
  163. }),
  164. content_type="application/json",
  165. )
  166. self.assertContains(
  167. response, "One or more posts to merge could not be found.", status_code=400
  168. )
  169. def test_merge_cross_threads(self):
  170. """api recjects attempt to merge with post made in other thread"""
  171. other_thread = testutils.post_thread(category=self.category)
  172. other_post = testutils.reply_thread(other_thread, poster=self.user)
  173. response = self.client.post(
  174. self.api_link,
  175. json.dumps({
  176. 'posts': [self.post.pk, other_post.pk]
  177. }),
  178. content_type="application/json",
  179. )
  180. self.assertContains(
  181. response, "One or more posts to merge could not be found.", status_code=400
  182. )
  183. def test_merge_authenticated_with_guest_post(self):
  184. """api recjects attempt to merge with post made by deleted user"""
  185. other_post = testutils.reply_thread(self.thread)
  186. response = self.client.post(
  187. self.api_link,
  188. json.dumps({
  189. 'posts': [self.post.pk, other_post.pk]
  190. }),
  191. content_type="application/json",
  192. )
  193. self.assertContains(
  194. response, "Posts made by different users can't be merged.", status_code=400
  195. )
  196. def test_merge_guest_with_authenticated_post(self):
  197. """api recjects attempt to merge with post made by deleted user"""
  198. other_post = testutils.reply_thread(self.thread)
  199. response = self.client.post(
  200. self.api_link,
  201. json.dumps({
  202. 'posts': [other_post.pk, self.post.pk]
  203. }),
  204. content_type="application/json",
  205. )
  206. self.assertContains(
  207. response, "Posts made by different users can't be merged.", status_code=400
  208. )
  209. def test_merge_guest_posts_different_usernames(self):
  210. """api recjects attempt to merge posts made by different guests"""
  211. response = self.client.post(
  212. self.api_link,
  213. json.dumps({
  214. 'posts': [
  215. testutils.reply_thread(self.thread, poster="Bob").pk,
  216. testutils.reply_thread(self.thread, poster="Miku").pk,
  217. ]
  218. }),
  219. content_type="application/json",
  220. )
  221. self.assertContains(
  222. response, "Posts made by different users can't be merged.", status_code=400
  223. )
  224. def test_merge_different_visibility(self):
  225. """api recjects attempt to merge posts with different visibility"""
  226. self.override_acl({'can_hide_posts': 1})
  227. response = self.client.post(
  228. self.api_link,
  229. json.dumps({
  230. 'posts': [
  231. testutils.reply_thread(self.thread, poster=self.user, is_hidden=True).pk,
  232. testutils.reply_thread(self.thread, poster=self.user, is_hidden=False).pk,
  233. ]
  234. }),
  235. content_type="application/json",
  236. )
  237. self.assertContains(
  238. response, "Posts with different visibility can't be merged.", status_code=400
  239. )
  240. def test_merge_different_approval(self):
  241. """api recjects attempt to merge posts with different approval"""
  242. self.override_acl({'can_approve_content': 1})
  243. response = self.client.post(
  244. self.api_link,
  245. json.dumps({
  246. 'posts': [
  247. testutils.reply_thread(self.thread, poster=self.user, is_unapproved=True).pk,
  248. testutils.reply_thread(self.thread, poster=self.user, is_unapproved=False).pk,
  249. ]
  250. }),
  251. content_type="application/json",
  252. )
  253. self.assertContains(
  254. response, "Posts with different visibility can't be merged.", status_code=400
  255. )
  256. def test_closed_thread(self):
  257. """api validates permission to merge in closed thread"""
  258. self.thread.is_closed = True
  259. self.thread.save()
  260. posts = [
  261. testutils.reply_thread(self.thread, poster=self.user).pk,
  262. testutils.reply_thread(self.thread, poster=self.user).pk,
  263. ]
  264. response = self.client.post(
  265. self.api_link,
  266. json.dumps({'posts': posts}),
  267. content_type="application/json",
  268. )
  269. self.assertContains(
  270. response,
  271. "This thread is closed. You can't merge posts in it.",
  272. status_code=400,
  273. )
  274. # allow closing threads
  275. self.override_acl({'can_close_threads': 1})
  276. response = self.client.post(
  277. self.api_link,
  278. json.dumps({'posts': posts}),
  279. content_type="application/json",
  280. )
  281. self.assertEqual(response.status_code, 200)
  282. def test_closed_category(self):
  283. """api validates permission to merge in closed category"""
  284. self.category.is_closed = True
  285. self.category.save()
  286. posts = [
  287. testutils.reply_thread(self.thread, poster=self.user).pk,
  288. testutils.reply_thread(self.thread, poster=self.user).pk,
  289. ]
  290. response = self.client.post(
  291. self.api_link,
  292. json.dumps({'posts': posts}),
  293. content_type="application/json",
  294. )
  295. self.assertContains(
  296. response,
  297. "This category is closed. You can't merge posts in it.",
  298. status_code=400,
  299. )
  300. # allow closing threads
  301. self.override_acl({'can_close_threads': 1})
  302. response = self.client.post(
  303. self.api_link,
  304. json.dumps({'posts': posts}),
  305. content_type="application/json",
  306. )
  307. self.assertEqual(response.status_code, 200)
  308. def test_merge_best_answer_first_post(self):
  309. """api recjects attempt to merge best_answer with first post"""
  310. self.thread.first_post.poster = self.user
  311. self.thread.first_post.save()
  312. self.post.poster = self.user
  313. self.post.save()
  314. self.thread.set_best_answer(self.user, self.post)
  315. self.thread.save()
  316. response = self.client.post(
  317. self.api_link,
  318. json.dumps({
  319. 'posts': [
  320. self.thread.first_post.pk,
  321. self.post.pk,
  322. ]
  323. }),
  324. content_type="application/json",
  325. )
  326. self.assertEqual(response.status_code, 400)
  327. self.assertEqual(response.json(), {
  328. 'detail': "Post marked as best answer can't be merged with thread's first post."
  329. })
  330. def test_merge_posts(self):
  331. """api merges two posts"""
  332. post_a = testutils.reply_thread(self.thread, poster=self.user, message="Battęry")
  333. post_b = testutils.reply_thread(self.thread, poster=self.user, message="Hórse")
  334. thread_replies = self.thread.replies
  335. response = self.client.post(
  336. self.api_link,
  337. json.dumps({
  338. 'posts': [post_a.pk, post_b.pk]
  339. }),
  340. content_type="application/json",
  341. )
  342. self.assertEqual(response.status_code, 200)
  343. self.refresh_thread()
  344. self.assertEqual(self.thread.replies, thread_replies - 1)
  345. with self.assertRaises(Post.DoesNotExist):
  346. Post.objects.get(pk=post_b.pk)
  347. merged_post = Post.objects.get(pk=post_a.pk)
  348. self.assertEqual(merged_post.parsed, '{}\n{}'.format(post_a.parsed, post_b.parsed))
  349. def test_merge_guest_posts(self):
  350. """api recjects attempt to merge posts made by same guest"""
  351. response = self.client.post(
  352. self.api_link,
  353. json.dumps({
  354. 'posts': [
  355. testutils.reply_thread(self.thread, poster="Bob").pk,
  356. testutils.reply_thread(self.thread, poster="Bob").pk,
  357. ]
  358. }),
  359. content_type="application/json",
  360. )
  361. self.assertEqual(response.status_code, 200)
  362. def test_merge_hidden_posts(self):
  363. """api merges two hidden posts"""
  364. self.override_acl({'can_hide_posts': 1})
  365. response = self.client.post(
  366. self.api_link,
  367. json.dumps({
  368. 'posts': [
  369. testutils.reply_thread(self.thread, poster=self.user, is_hidden=True).pk,
  370. testutils.reply_thread(self.thread, poster=self.user, is_hidden=True).pk,
  371. ]
  372. }),
  373. content_type="application/json",
  374. )
  375. self.assertEqual(response.status_code, 200)
  376. def test_merge_unapproved_posts(self):
  377. """api merges two unapproved posts"""
  378. self.override_acl({'can_approve_content': 1})
  379. response = self.client.post(
  380. self.api_link,
  381. json.dumps({
  382. 'posts': [
  383. testutils.reply_thread(self.thread, poster=self.user, is_unapproved=True).pk,
  384. testutils.reply_thread(self.thread, poster=self.user, is_unapproved=True).pk,
  385. ]
  386. }),
  387. content_type="application/json",
  388. )
  389. self.assertEqual(response.status_code, 200)
  390. def test_merge_with_hidden_thread(self):
  391. """api recjects attempt to merge posts with different visibility"""
  392. self.thread.first_post.is_hidden = True
  393. self.thread.first_post.poster = self.user
  394. self.thread.first_post.save()
  395. post_visible = testutils.reply_thread(self.thread, poster=self.user, is_hidden=False)
  396. self.override_acl({'can_hide_threads': 1})
  397. response = self.client.post(
  398. self.api_link,
  399. json.dumps({
  400. 'posts': [self.thread.first_post.pk, post_visible.pk]
  401. }),
  402. content_type="application/json",
  403. )
  404. self.assertEqual(response.status_code, 200)
  405. def test_merge_best_answer(self):
  406. """api merges best answer with other post"""
  407. best_answer = testutils.reply_thread(self.thread, poster="Bob")
  408. self.thread.set_best_answer(self.user, best_answer)
  409. self.thread.save()
  410. response = self.client.post(
  411. self.api_link,
  412. json.dumps({
  413. 'posts': [
  414. best_answer.pk,
  415. testutils.reply_thread(self.thread, poster="Bob").pk,
  416. ]
  417. }),
  418. content_type="application/json",
  419. )
  420. self.assertEqual(response.status_code, 200)
  421. self.refresh_thread()
  422. self.assertEqual(self.thread.best_answer, best_answer)
  423. def test_merge_best_answer_in(self):
  424. """api merges best answer into other post"""
  425. other_post = testutils.reply_thread(self.thread, poster="Bob")
  426. best_answer = testutils.reply_thread(self.thread, poster="Bob")
  427. self.thread.set_best_answer(self.user, best_answer)
  428. self.thread.save()
  429. response = self.client.post(
  430. self.api_link,
  431. json.dumps({
  432. 'posts': [
  433. best_answer.pk,
  434. other_post.pk,
  435. ]
  436. }),
  437. content_type="application/json",
  438. )
  439. self.assertEqual(response.status_code, 200)
  440. self.refresh_thread()
  441. self.assertEqual(self.thread.best_answer, other_post)
  442. def test_merge_remove_reads(self):
  443. """two posts merge removes read tracker from post"""
  444. post_a = testutils.reply_thread(self.thread, poster=self.user, message="Battęry")
  445. post_b = testutils.reply_thread(self.thread, poster=self.user, message="Hórse")
  446. poststracker.save_read(self.user, post_a)
  447. poststracker.save_read(self.user, post_b)
  448. response = self.client.post(
  449. self.api_link,
  450. json.dumps({
  451. 'posts': [post_a.pk, post_b.pk]
  452. }),
  453. content_type="application/json",
  454. )
  455. self.assertEqual(response.status_code, 200)
  456. # both post's were removed from readtracker
  457. self.assertEqual(self.user.postread_set.count(), 0)