test_thread_editreply_api.py 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529
  1. from __future__ import unicode_literals
  2. from datetime import timedelta
  3. from django.test.client import BOUNDARY, MULTIPART_CONTENT, encode_multipart
  4. from django.urls import reverse
  5. from django.utils import timezone
  6. from misago.acl.testutils import override_acl
  7. from misago.categories.models import Category
  8. from misago.threads import testutils
  9. from misago.threads.models import Post, Thread
  10. from misago.users.testutils import AuthenticatedUserTestCase
  11. class EditReplyTests(AuthenticatedUserTestCase):
  12. def setUp(self):
  13. super(EditReplyTests, self).setUp()
  14. self.category = Category.objects.get(slug='first-category')
  15. self.thread = testutils.post_thread(category=self.category)
  16. self.post = testutils.reply_thread(self.thread, poster=self.user)
  17. self.api_link = reverse(
  18. 'misago:api:thread-post-detail',
  19. kwargs={
  20. 'thread_pk': self.thread.pk,
  21. 'pk': self.post.pk,
  22. }
  23. )
  24. def override_acl(self, extra_acl=None):
  25. new_acl = self.user.acl_cache
  26. new_acl['categories'][self.category.pk].update({
  27. 'can_see': 1,
  28. 'can_browse': 1,
  29. 'can_start_threads': 0,
  30. 'can_reply_threads': 0,
  31. 'can_edit_posts': 1,
  32. })
  33. if extra_acl:
  34. new_acl['categories'][self.category.pk].update(extra_acl)
  35. override_acl(self.user, new_acl)
  36. def put(self, url, data=None):
  37. content = encode_multipart(BOUNDARY, data or {})
  38. return self.client.put(url, content, content_type=MULTIPART_CONTENT)
  39. def test_cant_edit_reply_as_guest(self):
  40. """user has to be authenticated to be able to edit reply"""
  41. self.logout_user()
  42. response = self.put(self.api_link)
  43. self.assertEqual(response.status_code, 403)
  44. def test_thread_visibility(self):
  45. """thread's visibility is validated"""
  46. self.override_acl({'can_see': 0})
  47. response = self.put(self.api_link)
  48. self.assertEqual(response.status_code, 404)
  49. self.override_acl({'can_browse': 0})
  50. response = self.put(self.api_link)
  51. self.assertEqual(response.status_code, 404)
  52. self.override_acl({'can_see_all_threads': 0})
  53. response = self.put(self.api_link)
  54. self.assertEqual(response.status_code, 404)
  55. def test_cant_edit_reply(self):
  56. """permission to edit reply is validated"""
  57. self.override_acl({'can_edit_posts': 0})
  58. response = self.put(self.api_link)
  59. self.assertContains(response, "You can't edit posts in this category.", status_code=403)
  60. def test_cant_edit_other_user_reply(self):
  61. """permission to edit reply by other users is validated"""
  62. self.override_acl({'can_edit_posts': 1})
  63. self.post.poster = None
  64. self.post.save()
  65. response = self.put(self.api_link)
  66. self.assertContains(
  67. response, "You can't edit other users posts in this category.", status_code=403
  68. )
  69. def test_edit_too_old(self):
  70. """permission to edit reply within timelimit is validated"""
  71. self.override_acl({
  72. 'can_edit_posts': 1,
  73. 'post_edit_time': 1,
  74. })
  75. self.post.posted_on = timezone.now() - timedelta(minutes=5)
  76. self.post.save()
  77. response = self.put(self.api_link)
  78. self.assertContains(
  79. response, "You can't edit posts that are older than 1 minute.", status_code=403
  80. )
  81. def test_closed_category(self):
  82. """permssion to edit reply in closed category is validated"""
  83. self.override_acl({'can_close_threads': 0})
  84. self.category.is_closed = True
  85. self.category.save()
  86. response = self.put(self.api_link)
  87. self.assertContains(
  88. response, "This category is closed. You can't edit posts in it.", status_code=403
  89. )
  90. # allow to post in closed category
  91. self.override_acl({'can_close_threads': 1})
  92. response = self.put(self.api_link)
  93. self.assertEqual(response.status_code, 400)
  94. def test_closed_thread(self):
  95. """permssion to edit reply in closed thread is validated"""
  96. self.override_acl({'can_close_threads': 0})
  97. self.thread.is_closed = True
  98. self.thread.save()
  99. response = self.put(self.api_link)
  100. self.assertContains(
  101. response, "This thread is closed. You can't edit posts in it.", status_code=403
  102. )
  103. # allow to post in closed thread
  104. self.override_acl({'can_close_threads': 1})
  105. response = self.put(self.api_link)
  106. self.assertEqual(response.status_code, 400)
  107. def test_protected_post(self):
  108. """permssion to edit protected post is validated"""
  109. self.override_acl({'can_protect_posts': 0})
  110. self.post.is_protected = True
  111. self.post.save()
  112. response = self.put(self.api_link)
  113. self.assertContains(
  114. response, "This post is protected. You can't edit it.", status_code=403
  115. )
  116. # allow to post in closed thread
  117. self.override_acl({'can_protect_posts': 1})
  118. response = self.put(self.api_link)
  119. self.assertEqual(response.status_code, 400)
  120. def test_empty_data(self):
  121. """no data sent handling has no showstoppers"""
  122. self.override_acl()
  123. response = self.put(self.api_link, data={})
  124. self.assertContains(response, "You have to enter a message.", status_code=400)
  125. def test_invalid_data(self):
  126. """api errors for invalid request data"""
  127. self.override_acl()
  128. response = self.client.put(
  129. self.api_link,
  130. 'false',
  131. content_type="application/json",
  132. )
  133. self.assertContains(response, "Invalid data.", status_code=400)
  134. def test_edit_event(self):
  135. """events can't be edited"""
  136. self.override_acl()
  137. self.post.is_event = True
  138. self.post.save()
  139. response = self.put(self.api_link, data={})
  140. self.assertContains(response, "Events can't be edited.", status_code=403)
  141. def test_post_is_validated(self):
  142. """post is validated"""
  143. self.override_acl()
  144. response = self.put(
  145. self.api_link, data={
  146. 'post': "a",
  147. }
  148. )
  149. self.assertEqual(response.status_code, 400)
  150. self.assertEqual(
  151. response.json(), {
  152. 'post': ["Posted message should be at least 5 characters long (it has 1)."],
  153. }
  154. )
  155. def test_edit_reply_no_change(self):
  156. """endpoint isn't bumping edits count if no change was made to post's body"""
  157. self.override_acl()
  158. self.assertEqual(self.post.edits_record.count(), 0)
  159. response = self.put(self.api_link, data={'post': self.post.original})
  160. self.assertEqual(response.status_code, 200)
  161. self.override_acl()
  162. response = self.client.get(self.thread.get_absolute_url())
  163. self.assertContains(response, self.post.parsed)
  164. post = self.thread.post_set.order_by('id').last()
  165. self.assertEqual(post.edits, 0)
  166. self.assertEqual(post.original, self.post.original)
  167. self.assertIsNone(post.last_editor_id, self.user.id)
  168. self.assertIsNone(post.last_editor_name, self.user.username)
  169. self.assertIsNone(post.last_editor_slug, self.user.slug)
  170. self.assertEqual(self.post.edits_record.count(), 0)
  171. def test_edit_reply(self):
  172. """endpoint updates reply"""
  173. self.override_acl()
  174. self.assertEqual(self.post.edits_record.count(), 0)
  175. response = self.put(self.api_link, data={'post': "This is test edit!"})
  176. self.assertEqual(response.status_code, 200)
  177. self.override_acl()
  178. response = self.client.get(self.thread.get_absolute_url())
  179. self.assertContains(response, "<p>This is test edit!</p>")
  180. self.assertEqual(self.user.audittrail_set.count(), 1)
  181. post = self.thread.post_set.order_by('id').last()
  182. self.assertEqual(post.edits, 1)
  183. self.assertEqual(post.original, "This is test edit!")
  184. self.assertEqual(post.last_editor_id, self.user.id)
  185. self.assertEqual(post.last_editor_name, self.user.username)
  186. self.assertEqual(post.last_editor_slug, self.user.slug)
  187. self.assertEqual(self.post.edits_record.count(), 1)
  188. post_edit = post.edits_record.last()
  189. self.assertEqual(post_edit.edited_from, self.post.original)
  190. self.assertEqual(post_edit.edited_to, post.original)
  191. self.assertEqual(post_edit.editor_id, self.user.id)
  192. self.assertEqual(post_edit.editor_name, self.user.username)
  193. self.assertEqual(post_edit.editor_slug, self.user.slug)
  194. def test_edit_first_post_hidden(self):
  195. """endpoint updates hidden thread's first post"""
  196. self.override_acl({'can_hide_threads': 1, 'can_edit_posts': 2})
  197. self.thread.is_hidden = True
  198. self.thread.save()
  199. self.thread.first_post.is_hidden = True
  200. self.thread.first_post.save()
  201. api_link = reverse(
  202. 'misago:api:thread-post-detail',
  203. kwargs={
  204. 'thread_pk': self.thread.pk,
  205. 'pk': self.thread.first_post.pk,
  206. }
  207. )
  208. response = self.put(api_link, data={'post': "This is test edit!"})
  209. self.assertEqual(response.status_code, 200)
  210. def test_protect_post(self):
  211. """can protect post"""
  212. self.override_acl({'can_protect_posts': 1})
  213. response = self.put(
  214. self.api_link, data={
  215. 'post': "Lorem ipsum dolor met!",
  216. 'protect': 1,
  217. }
  218. )
  219. self.assertEqual(response.status_code, 200)
  220. post = self.user.post_set.order_by('id').last()
  221. self.assertTrue(post.is_protected)
  222. def test_protect_post_no_permission(self):
  223. """cant protect post without permission"""
  224. self.override_acl({'can_protect_posts': 0})
  225. response = self.put(
  226. self.api_link, data={
  227. 'post': "Lorem ipsum dolor met!",
  228. 'protect': 1,
  229. }
  230. )
  231. self.assertEqual(response.status_code, 200)
  232. post = self.user.post_set.order_by('id').last()
  233. self.assertFalse(post.is_protected)
  234. def test_post_unicode(self):
  235. """unicode characters can be posted"""
  236. self.override_acl()
  237. response = self.put(
  238. self.api_link, data={
  239. 'post': "Chrzążczyżewoszyce, powiat Łękółody.",
  240. }
  241. )
  242. self.assertEqual(response.status_code, 200)
  243. def test_reply_category_moderation_queue(self):
  244. """edit sends reply to queue due to category setup"""
  245. self.category.require_edits_approval = True
  246. self.category.save()
  247. response = self.put(
  248. self.api_link, data={
  249. 'post': "Lorem ipsum dolor met!",
  250. }
  251. )
  252. self.assertEqual(response.status_code, 200)
  253. post = self.user.post_set.all()[:1][0]
  254. self.assertTrue(post.is_unapproved)
  255. def test_reply_category_moderation_queue_bypass(self):
  256. """bypass moderation queue due to user's acl"""
  257. override_acl(self.user, {'can_approve_content': 1})
  258. self.category.require_edits_approval = True
  259. self.category.save()
  260. response = self.put(
  261. self.api_link, data={
  262. 'post': "Lorem ipsum dolor met!",
  263. }
  264. )
  265. self.assertEqual(response.status_code, 200)
  266. post = self.user.post_set.all()[:1][0]
  267. self.assertFalse(post.is_unapproved)
  268. def test_reply_user_moderation_queue(self):
  269. """edit sends reply to queue due to user acl"""
  270. self.override_acl({'require_edits_approval': 1})
  271. response = self.put(
  272. self.api_link, data={
  273. 'post': "Lorem ipsum dolor met!",
  274. }
  275. )
  276. self.assertEqual(response.status_code, 200)
  277. post = self.user.post_set.all()[:1][0]
  278. self.assertTrue(post.is_unapproved)
  279. def test_reply_user_moderation_queue_bypass(self):
  280. """bypass moderation queue due to user's acl"""
  281. override_acl(self.user, {'can_approve_content': 1})
  282. self.override_acl({'require_edits_approval': 1})
  283. response = self.put(
  284. self.api_link, data={
  285. 'post': "Lorem ipsum dolor met!",
  286. }
  287. )
  288. self.assertEqual(response.status_code, 200)
  289. post = self.user.post_set.all()[:1][0]
  290. self.assertFalse(post.is_unapproved)
  291. def test_reply_omit_other_moderation_queues(self):
  292. """other queues are omitted"""
  293. self.category.require_threads_approval = True
  294. self.category.require_replies_approval = True
  295. self.category.save()
  296. self.override_acl({
  297. 'require_threads_approval': 1,
  298. 'require_replies_approval': 1,
  299. })
  300. response = self.put(
  301. self.api_link, data={
  302. 'post': "Lorem ipsum dolor met!",
  303. }
  304. )
  305. self.assertEqual(response.status_code, 200)
  306. post = self.user.post_set.all()[:1][0]
  307. self.assertFalse(post.is_unapproved)
  308. def setUpFirstReplyTest(self):
  309. self.post = self.thread.first_post
  310. self.post.poster = self.user
  311. self.post.save()
  312. self.api_link = reverse(
  313. 'misago:api:thread-post-detail',
  314. kwargs={
  315. 'thread_pk': self.thread.pk,
  316. 'pk': self.post.pk,
  317. }
  318. )
  319. def test_first_reply_category_moderation_queue(self):
  320. """edit sends thread to queue due to category setup"""
  321. self.setUpFirstReplyTest()
  322. self.category.require_edits_approval = True
  323. self.category.save()
  324. response = self.put(
  325. self.api_link, data={
  326. 'post': "Lorem ipsum dolor met!",
  327. }
  328. )
  329. self.assertEqual(response.status_code, 200)
  330. thread = Thread.objects.get(pk=self.thread.pk)
  331. self.assertTrue(thread.is_unapproved)
  332. self.assertTrue(thread.has_unapproved_posts)
  333. post = Post.objects.get(pk=self.post.pk)
  334. self.assertTrue(post.is_unapproved)
  335. def test_first_reply_category_moderation_queue_bypass(self):
  336. """bypass moderation queue due to user's acl"""
  337. self.setUpFirstReplyTest()
  338. override_acl(self.user, {'can_approve_content': 1})
  339. self.category.require_edits_approval = True
  340. self.category.save()
  341. response = self.put(
  342. self.api_link, data={
  343. 'post': "Lorem ipsum dolor met!",
  344. }
  345. )
  346. self.assertEqual(response.status_code, 200)
  347. thread = Thread.objects.get(pk=self.thread.pk)
  348. self.assertFalse(thread.is_unapproved)
  349. self.assertFalse(thread.has_unapproved_posts)
  350. post = Post.objects.get(pk=self.post.pk)
  351. self.assertFalse(post.is_unapproved)
  352. def test_first_reply_user_moderation_queue(self):
  353. """edit sends thread to queue due to user acl"""
  354. self.setUpFirstReplyTest()
  355. self.override_acl({'require_edits_approval': 1})
  356. response = self.put(
  357. self.api_link, data={
  358. 'post': "Lorem ipsum dolor met!",
  359. }
  360. )
  361. self.assertEqual(response.status_code, 200)
  362. thread = Thread.objects.get(pk=self.thread.pk)
  363. self.assertTrue(thread.is_unapproved)
  364. self.assertTrue(thread.has_unapproved_posts)
  365. post = Post.objects.get(pk=self.post.pk)
  366. self.assertTrue(post.is_unapproved)
  367. def test_first_reply_user_moderation_queue_bypass(self):
  368. """bypass moderation queue due to user's acl"""
  369. self.setUpFirstReplyTest()
  370. override_acl(self.user, {'can_approve_content': 1})
  371. self.override_acl({'require_edits_approval': 1})
  372. response = self.put(
  373. self.api_link, data={
  374. 'post': "Lorem ipsum dolor met!",
  375. }
  376. )
  377. self.assertEqual(response.status_code, 200)
  378. thread = Thread.objects.get(pk=self.thread.pk)
  379. self.assertFalse(thread.is_unapproved)
  380. self.assertFalse(thread.has_unapproved_posts)
  381. post = Post.objects.get(pk=self.post.pk)
  382. self.assertFalse(post.is_unapproved)
  383. def test_first_reply_omit_other_moderation_queues(self):
  384. """other queues are omitted"""
  385. self.setUpFirstReplyTest()
  386. self.category.require_threads_approval = True
  387. self.category.require_replies_approval = True
  388. self.category.save()
  389. self.override_acl({
  390. 'require_threads_approval': 1,
  391. 'require_replies_approval': 1,
  392. })
  393. response = self.put(
  394. self.api_link, data={
  395. 'post': "Lorem ipsum dolor met!",
  396. }
  397. )
  398. self.assertEqual(response.status_code, 200)
  399. thread = Thread.objects.get(pk=self.thread.pk)
  400. self.assertFalse(thread.is_unapproved)
  401. self.assertFalse(thread.has_unapproved_posts)
  402. post = Post.objects.get(pk=self.post.pk)
  403. self.assertFalse(post.is_unapproved)