test_thread_editreply_api.py 18 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548
  1. # -*- coding: utf-8 -*-
  2. from __future__ import unicode_literals
  3. from datetime import timedelta
  4. from django.test.client import BOUNDARY, MULTIPART_CONTENT, encode_multipart
  5. from django.urls import reverse
  6. from django.utils import timezone
  7. from misago.acl.testutils import override_acl
  8. from misago.categories.models import Category
  9. from misago.threads import testutils
  10. from misago.threads.models import Post, Thread
  11. from misago.users.testutils import AuthenticatedUserTestCase
  12. class EditReplyTests(AuthenticatedUserTestCase):
  13. def setUp(self):
  14. super(EditReplyTests, self).setUp()
  15. self.category = Category.objects.get(slug='first-category')
  16. self.thread = testutils.post_thread(category=self.category)
  17. self.post = testutils.reply_thread(self.thread, poster=self.user)
  18. self.api_link = reverse(
  19. 'misago:api:thread-post-detail',
  20. kwargs={
  21. 'thread_pk': self.thread.pk,
  22. 'pk': self.post.pk,
  23. }
  24. )
  25. def override_acl(self, extra_acl=None):
  26. new_acl = self.user.acl_cache
  27. new_acl['categories'][self.category.pk].update({
  28. 'can_see': 1,
  29. 'can_browse': 1,
  30. 'can_start_threads': 0,
  31. 'can_reply_threads': 0,
  32. 'can_edit_posts': 1,
  33. })
  34. if extra_acl:
  35. new_acl['categories'][self.category.pk].update(extra_acl)
  36. override_acl(self.user, new_acl)
  37. def put(self, url, data=None):
  38. content = encode_multipart(BOUNDARY, data or {})
  39. return self.client.put(url, content, content_type=MULTIPART_CONTENT)
  40. def test_cant_edit_reply_as_guest(self):
  41. """user has to be authenticated to be able to edit reply"""
  42. self.logout_user()
  43. response = self.put(self.api_link)
  44. self.assertEqual(response.status_code, 403)
  45. def test_thread_visibility(self):
  46. """thread's visibility is validated"""
  47. self.override_acl({'can_see': 0})
  48. response = self.put(self.api_link)
  49. self.assertEqual(response.status_code, 404)
  50. self.override_acl({'can_browse': 0})
  51. response = self.put(self.api_link)
  52. self.assertEqual(response.status_code, 404)
  53. self.override_acl({'can_see_all_threads': 0})
  54. response = self.put(self.api_link)
  55. self.assertEqual(response.status_code, 404)
  56. def test_cant_edit_reply(self):
  57. """permission to edit reply is validated"""
  58. self.override_acl({'can_edit_posts': 0})
  59. response = self.put(self.api_link)
  60. self.assertEqual(response.status_code, 403)
  61. self.assertEqual(response.json(), {
  62. 'detail': "You can't edit posts in this category.",
  63. })
  64. def test_cant_edit_other_user_reply(self):
  65. """permission to edit reply by other users is validated"""
  66. self.override_acl({'can_edit_posts': 1})
  67. self.post.poster = None
  68. self.post.save()
  69. response = self.put(self.api_link)
  70. self.assertEqual(response.status_code, 403)
  71. self.assertEqual(response.json(), {
  72. 'detail': "You can't edit other users posts in this category.",
  73. })
  74. def test_edit_too_old(self):
  75. """permission to edit reply within timelimit is validated"""
  76. self.override_acl({
  77. 'can_edit_posts': 1,
  78. 'post_edit_time': 1,
  79. })
  80. self.post.posted_on = timezone.now() - timedelta(minutes=5)
  81. self.post.save()
  82. response = self.put(self.api_link)
  83. self.assertEqual(response.status_code, 403)
  84. self.assertEqual(response.json(), {
  85. 'detail': "You can't edit posts that are older than 1 minute.",
  86. })
  87. def test_closed_category(self):
  88. """permssion to edit reply in closed category is validated"""
  89. self.override_acl({'can_close_threads': 0})
  90. self.category.is_closed = True
  91. self.category.save()
  92. response = self.put(self.api_link)
  93. self.assertEqual(response.status_code, 403)
  94. self.assertEqual(response.json(), {
  95. 'detail': "This category is closed. You can't edit posts in it.",
  96. })
  97. # allow to post in closed category
  98. self.override_acl({'can_close_threads': 1})
  99. response = self.put(self.api_link)
  100. self.assertEqual(response.status_code, 400)
  101. self.assertEqual(response.json(), {
  102. 'post': ['You have to enter a message.'],
  103. })
  104. def test_closed_thread(self):
  105. """permssion to edit reply in closed thread is validated"""
  106. self.override_acl({'can_close_threads': 0})
  107. self.thread.is_closed = True
  108. self.thread.save()
  109. response = self.put(self.api_link)
  110. self.assertEqual(response.status_code, 403)
  111. self.assertEqual(response.json(), {
  112. 'detail': "This thread is closed. You can't edit posts in it.",
  113. })
  114. # allow to post in closed thread
  115. self.override_acl({'can_close_threads': 1})
  116. response = self.put(self.api_link)
  117. self.assertEqual(response.status_code, 400)
  118. self.assertEqual(response.json(), {
  119. 'post': ['You have to enter a message.'],
  120. })
  121. def test_protected_post(self):
  122. """permssion to edit protected post is validated"""
  123. self.override_acl({'can_protect_posts': 0})
  124. self.post.is_protected = True
  125. self.post.save()
  126. response = self.put(self.api_link)
  127. self.assertEqual(response.status_code, 403)
  128. self.assertEqual(response.json(), {
  129. 'detail': "This post is protected. You can't edit it.",
  130. })
  131. # allow to post in closed thread
  132. self.override_acl({'can_protect_posts': 1})
  133. response = self.put(self.api_link)
  134. self.assertEqual(response.status_code, 400)
  135. self.assertEqual(response.json(), {
  136. 'post': ['You have to enter a message.'],
  137. })
  138. def test_empty_data(self):
  139. """no data sent handling has no showstoppers"""
  140. self.override_acl()
  141. response = self.put(self.api_link, data={})
  142. self.assertEqual(response.status_code, 400)
  143. self.assertEqual(response.json(), {
  144. 'post': ['You have to enter a message.'],
  145. })
  146. def test_invalid_data(self):
  147. """api errors for invalid request data"""
  148. self.override_acl()
  149. response = self.client.put(self.api_link,'false', content_type="application/json")
  150. self.assertEqual(response.status_code, 400)
  151. self.assertEqual(response.json(), {
  152. 'non_field_errors': ['Invalid data. Expected a dictionary, but got bool.'],
  153. })
  154. def test_edit_event(self):
  155. """events can't be edited"""
  156. self.override_acl()
  157. self.post.is_event = True
  158. self.post.save()
  159. response = self.put(self.api_link, data={})
  160. self.assertEqual(response.status_code, 403)
  161. self.assertEqual(response.json(), {
  162. 'detail': "Events can't be edited.",
  163. })
  164. def test_post_is_validated(self):
  165. """post is validated"""
  166. self.override_acl()
  167. response = self.put(
  168. self.api_link, data={
  169. 'post': "a",
  170. }
  171. )
  172. self.assertEqual(response.status_code, 400)
  173. self.assertEqual(
  174. response.json(), {
  175. 'post': ["Posted message should be at least 5 characters long (it has 1)."],
  176. }
  177. )
  178. def test_edit_reply_no_change(self):
  179. """endpoint isn't bumping edits count if no change was made to post's body"""
  180. self.override_acl()
  181. self.assertEqual(self.post.edits_record.count(), 0)
  182. response = self.put(self.api_link, data={'post': self.post.original})
  183. self.assertEqual(response.status_code, 200)
  184. self.override_acl()
  185. response = self.client.get(self.thread.get_absolute_url())
  186. self.assertContains(response, self.post.parsed)
  187. post = self.thread.post_set.order_by('id').last()
  188. self.assertEqual(post.edits, 0)
  189. self.assertEqual(post.original, self.post.original)
  190. self.assertIsNone(post.last_editor_id, self.user.id)
  191. self.assertIsNone(post.last_editor_name, self.user.username)
  192. self.assertIsNone(post.last_editor_slug, self.user.slug)
  193. self.assertEqual(self.post.edits_record.count(), 0)
  194. def test_edit_reply(self):
  195. """endpoint updates reply"""
  196. self.override_acl()
  197. self.assertEqual(self.post.edits_record.count(), 0)
  198. response = self.put(self.api_link, data={'post': "This is test edit!"})
  199. self.assertEqual(response.status_code, 200)
  200. self.override_acl()
  201. response = self.client.get(self.thread.get_absolute_url())
  202. self.assertContains(response, "<p>This is test edit!</p>")
  203. post = self.thread.post_set.order_by('id').last()
  204. self.assertEqual(post.edits, 1)
  205. self.assertEqual(post.original, "This is test edit!")
  206. self.assertEqual(post.last_editor_id, self.user.id)
  207. self.assertEqual(post.last_editor_name, self.user.username)
  208. self.assertEqual(post.last_editor_slug, self.user.slug)
  209. self.assertEqual(self.post.edits_record.count(), 1)
  210. post_edit = post.edits_record.last()
  211. self.assertEqual(post_edit.edited_from, self.post.original)
  212. self.assertEqual(post_edit.edited_to, post.original)
  213. self.assertEqual(post_edit.editor_id, self.user.id)
  214. self.assertEqual(post_edit.editor_name, self.user.username)
  215. self.assertEqual(post_edit.editor_slug, self.user.slug)
  216. def test_edit_first_post_hidden(self):
  217. """endpoint updates hidden thread's first post"""
  218. self.override_acl({'can_hide_threads': 1, 'can_edit_posts': 2})
  219. self.thread.is_hidden = True
  220. self.thread.save()
  221. self.thread.first_post.is_hidden = True
  222. self.thread.first_post.save()
  223. api_link = reverse(
  224. 'misago:api:thread-post-detail',
  225. kwargs={
  226. 'thread_pk': self.thread.pk,
  227. 'pk': self.thread.first_post.pk,
  228. }
  229. )
  230. response = self.put(api_link, data={'post': "This is test edit!"})
  231. self.assertEqual(response.status_code, 200)
  232. def test_protect_post(self):
  233. """can protect post"""
  234. self.override_acl({'can_protect_posts': 1})
  235. response = self.put(
  236. self.api_link, data={
  237. 'post': "Lorem ipsum dolor met!",
  238. 'protect': 1,
  239. }
  240. )
  241. self.assertEqual(response.status_code, 200)
  242. post = self.user.post_set.order_by('id').last()
  243. self.assertTrue(post.is_protected)
  244. def test_protect_post_no_permission(self):
  245. """cant protect post without permission"""
  246. self.override_acl({'can_protect_posts': 0})
  247. response = self.put(
  248. self.api_link, data={
  249. 'post': "Lorem ipsum dolor met!",
  250. 'protect': 1,
  251. }
  252. )
  253. self.assertEqual(response.status_code, 200)
  254. post = self.user.post_set.order_by('id').last()
  255. self.assertFalse(post.is_protected)
  256. def test_post_unicode(self):
  257. """unicode characters can be posted"""
  258. self.override_acl()
  259. response = self.put(
  260. self.api_link, data={
  261. 'post': "Chrzążczyżewoszyce, powiat Łękółody.",
  262. }
  263. )
  264. self.assertEqual(response.status_code, 200)
  265. def test_reply_category_moderation_queue(self):
  266. """edit sends reply to queue due to category setup"""
  267. self.category.require_edits_approval = True
  268. self.category.save()
  269. response = self.put(
  270. self.api_link, data={
  271. 'post': "Lorem ipsum dolor met!",
  272. }
  273. )
  274. self.assertEqual(response.status_code, 200)
  275. post = self.user.post_set.all()[:1][0]
  276. self.assertTrue(post.is_unapproved)
  277. def test_reply_category_moderation_queue_bypass(self):
  278. """bypass moderation queue due to user's acl"""
  279. override_acl(self.user, {'can_approve_content': 1})
  280. self.category.require_edits_approval = True
  281. self.category.save()
  282. response = self.put(
  283. self.api_link, data={
  284. 'post': "Lorem ipsum dolor met!",
  285. }
  286. )
  287. self.assertEqual(response.status_code, 200)
  288. post = self.user.post_set.all()[:1][0]
  289. self.assertFalse(post.is_unapproved)
  290. def test_reply_user_moderation_queue(self):
  291. """edit sends reply to queue due to user acl"""
  292. self.override_acl({'require_edits_approval': 1})
  293. response = self.put(
  294. self.api_link, data={
  295. 'post': "Lorem ipsum dolor met!",
  296. }
  297. )
  298. self.assertEqual(response.status_code, 200)
  299. post = self.user.post_set.all()[:1][0]
  300. self.assertTrue(post.is_unapproved)
  301. def test_reply_user_moderation_queue_bypass(self):
  302. """bypass moderation queue due to user's acl"""
  303. override_acl(self.user, {'can_approve_content': 1})
  304. self.override_acl({'require_edits_approval': 1})
  305. response = self.put(
  306. self.api_link, data={
  307. 'post': "Lorem ipsum dolor met!",
  308. }
  309. )
  310. self.assertEqual(response.status_code, 200)
  311. post = self.user.post_set.all()[:1][0]
  312. self.assertFalse(post.is_unapproved)
  313. def test_reply_omit_other_moderation_queues(self):
  314. """other queues are omitted"""
  315. self.category.require_threads_approval = True
  316. self.category.require_replies_approval = True
  317. self.category.save()
  318. self.override_acl({
  319. 'require_threads_approval': 1,
  320. 'require_replies_approval': 1,
  321. })
  322. response = self.put(
  323. self.api_link, data={
  324. 'post': "Lorem ipsum dolor met!",
  325. }
  326. )
  327. self.assertEqual(response.status_code, 200)
  328. post = self.user.post_set.all()[:1][0]
  329. self.assertFalse(post.is_unapproved)
  330. def setUpFirstReplyTest(self):
  331. self.post = self.thread.first_post
  332. self.post.poster = self.user
  333. self.post.save()
  334. self.api_link = reverse(
  335. 'misago:api:thread-post-detail',
  336. kwargs={
  337. 'thread_pk': self.thread.pk,
  338. 'pk': self.post.pk,
  339. }
  340. )
  341. def test_first_reply_category_moderation_queue(self):
  342. """edit sends thread to queue due to category setup"""
  343. self.setUpFirstReplyTest()
  344. self.category.require_edits_approval = True
  345. self.category.save()
  346. response = self.put(
  347. self.api_link, data={
  348. 'post': "Lorem ipsum dolor met!",
  349. }
  350. )
  351. self.assertEqual(response.status_code, 200)
  352. thread = Thread.objects.get(pk=self.thread.pk)
  353. self.assertTrue(thread.is_unapproved)
  354. self.assertTrue(thread.has_unapproved_posts)
  355. post = Post.objects.get(pk=self.post.pk)
  356. self.assertTrue(post.is_unapproved)
  357. def test_first_reply_category_moderation_queue_bypass(self):
  358. """bypass moderation queue due to user's acl"""
  359. self.setUpFirstReplyTest()
  360. override_acl(self.user, {'can_approve_content': 1})
  361. self.category.require_edits_approval = True
  362. self.category.save()
  363. response = self.put(
  364. self.api_link, data={
  365. 'post': "Lorem ipsum dolor met!",
  366. }
  367. )
  368. self.assertEqual(response.status_code, 200)
  369. thread = Thread.objects.get(pk=self.thread.pk)
  370. self.assertFalse(thread.is_unapproved)
  371. self.assertFalse(thread.has_unapproved_posts)
  372. post = Post.objects.get(pk=self.post.pk)
  373. self.assertFalse(post.is_unapproved)
  374. def test_first_reply_user_moderation_queue(self):
  375. """edit sends thread to queue due to user acl"""
  376. self.setUpFirstReplyTest()
  377. self.override_acl({'require_edits_approval': 1})
  378. response = self.put(
  379. self.api_link, data={
  380. 'post': "Lorem ipsum dolor met!",
  381. }
  382. )
  383. self.assertEqual(response.status_code, 200)
  384. thread = Thread.objects.get(pk=self.thread.pk)
  385. self.assertTrue(thread.is_unapproved)
  386. self.assertTrue(thread.has_unapproved_posts)
  387. post = Post.objects.get(pk=self.post.pk)
  388. self.assertTrue(post.is_unapproved)
  389. def test_first_reply_user_moderation_queue_bypass(self):
  390. """bypass moderation queue due to user's acl"""
  391. self.setUpFirstReplyTest()
  392. override_acl(self.user, {'can_approve_content': 1})
  393. self.override_acl({'require_edits_approval': 1})
  394. response = self.put(
  395. self.api_link, data={
  396. 'post': "Lorem ipsum dolor met!",
  397. }
  398. )
  399. self.assertEqual(response.status_code, 200)
  400. thread = Thread.objects.get(pk=self.thread.pk)
  401. self.assertFalse(thread.is_unapproved)
  402. self.assertFalse(thread.has_unapproved_posts)
  403. post = Post.objects.get(pk=self.post.pk)
  404. self.assertFalse(post.is_unapproved)
  405. def test_first_reply_omit_other_moderation_queues(self):
  406. """other queues are omitted"""
  407. self.setUpFirstReplyTest()
  408. self.category.require_threads_approval = True
  409. self.category.require_replies_approval = True
  410. self.category.save()
  411. self.override_acl({
  412. 'require_threads_approval': 1,
  413. 'require_replies_approval': 1,
  414. })
  415. response = self.put(
  416. self.api_link, data={
  417. 'post': "Lorem ipsum dolor met!",
  418. }
  419. )
  420. self.assertEqual(response.status_code, 200)
  421. thread = Thread.objects.get(pk=self.thread.pk)
  422. self.assertFalse(thread.is_unapproved)
  423. self.assertFalse(thread.has_unapproved_posts)
  424. post = Post.objects.get(pk=self.post.pk)
  425. self.assertFalse(post.is_unapproved)