test_thread_editreply_api.py 17 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527
  1. from datetime import timedelta
  2. from django.test.client import BOUNDARY, MULTIPART_CONTENT, encode_multipart
  3. from django.urls import reverse
  4. from django.utils import timezone
  5. from misago.acl.testutils import override_acl
  6. from misago.categories.models import Category
  7. from misago.threads import testutils
  8. from misago.threads.models import Post, Thread
  9. from misago.users.testutils import AuthenticatedUserTestCase
  10. class EditReplyTests(AuthenticatedUserTestCase):
  11. def setUp(self):
  12. super(EditReplyTests, self).setUp()
  13. self.category = Category.objects.get(slug='first-category')
  14. self.thread = testutils.post_thread(category=self.category)
  15. self.post = testutils.reply_thread(self.thread, poster=self.user)
  16. self.api_link = reverse(
  17. 'misago:api:thread-post-detail',
  18. kwargs={
  19. 'thread_pk': self.thread.pk,
  20. 'pk': self.post.pk,
  21. }
  22. )
  23. def override_acl(self, extra_acl=None):
  24. new_acl = self.user.acl_cache
  25. new_acl['categories'][self.category.pk].update({
  26. 'can_see': 1,
  27. 'can_browse': 1,
  28. 'can_start_threads': 0,
  29. 'can_reply_threads': 0,
  30. 'can_edit_posts': 1,
  31. })
  32. if extra_acl:
  33. new_acl['categories'][self.category.pk].update(extra_acl)
  34. override_acl(self.user, new_acl)
  35. def put(self, url, data=None):
  36. content = encode_multipart(BOUNDARY, data or {})
  37. return self.client.put(url, content, content_type=MULTIPART_CONTENT)
  38. def test_cant_edit_reply_as_guest(self):
  39. """user has to be authenticated to be able to edit reply"""
  40. self.logout_user()
  41. response = self.put(self.api_link)
  42. self.assertEqual(response.status_code, 403)
  43. def test_thread_visibility(self):
  44. """thread's visibility is validated"""
  45. self.override_acl({'can_see': 0})
  46. response = self.put(self.api_link)
  47. self.assertEqual(response.status_code, 404)
  48. self.override_acl({'can_browse': 0})
  49. response = self.put(self.api_link)
  50. self.assertEqual(response.status_code, 404)
  51. self.override_acl({'can_see_all_threads': 0})
  52. response = self.put(self.api_link)
  53. self.assertEqual(response.status_code, 404)
  54. def test_cant_edit_reply(self):
  55. """permission to edit reply is validated"""
  56. self.override_acl({'can_edit_posts': 0})
  57. response = self.put(self.api_link)
  58. self.assertContains(response, "You can't edit posts in this category.", status_code=403)
  59. def test_cant_edit_other_user_reply(self):
  60. """permission to edit reply by other users is validated"""
  61. self.override_acl({'can_edit_posts': 1})
  62. self.post.poster = None
  63. self.post.save()
  64. response = self.put(self.api_link)
  65. self.assertContains(
  66. response, "You can't edit other users posts in this category.", status_code=403
  67. )
  68. def test_edit_too_old(self):
  69. """permission to edit reply within timelimit is validated"""
  70. self.override_acl({
  71. 'can_edit_posts': 1,
  72. 'post_edit_time': 1,
  73. })
  74. self.post.posted_on = timezone.now() - timedelta(minutes=5)
  75. self.post.save()
  76. response = self.put(self.api_link)
  77. self.assertContains(
  78. response, "You can't edit posts that are older than 1 minute.", status_code=403
  79. )
  80. def test_closed_category(self):
  81. """permssion to edit reply in closed category is validated"""
  82. self.override_acl({'can_close_threads': 0})
  83. self.category.is_closed = True
  84. self.category.save()
  85. response = self.put(self.api_link)
  86. self.assertContains(
  87. response, "This category is closed. You can't edit posts in it.", status_code=403
  88. )
  89. # allow to post in closed category
  90. self.override_acl({'can_close_threads': 1})
  91. response = self.put(self.api_link)
  92. self.assertEqual(response.status_code, 400)
  93. def test_closed_thread(self):
  94. """permssion to edit reply in closed thread is validated"""
  95. self.override_acl({'can_close_threads': 0})
  96. self.thread.is_closed = True
  97. self.thread.save()
  98. response = self.put(self.api_link)
  99. self.assertContains(
  100. response, "This thread is closed. You can't edit posts in it.", status_code=403
  101. )
  102. # allow to post in closed thread
  103. self.override_acl({'can_close_threads': 1})
  104. response = self.put(self.api_link)
  105. self.assertEqual(response.status_code, 400)
  106. def test_protected_post(self):
  107. """permssion to edit protected post is validated"""
  108. self.override_acl({'can_protect_posts': 0})
  109. self.post.is_protected = True
  110. self.post.save()
  111. response = self.put(self.api_link)
  112. self.assertContains(
  113. response, "This post is protected. You can't edit it.", status_code=403
  114. )
  115. # allow to post in closed thread
  116. self.override_acl({'can_protect_posts': 1})
  117. response = self.put(self.api_link)
  118. self.assertEqual(response.status_code, 400)
  119. def test_empty_data(self):
  120. """no data sent handling has no showstoppers"""
  121. self.override_acl()
  122. response = self.put(self.api_link, data={})
  123. self.assertContains(response, "You have to enter a message.", status_code=400)
  124. def test_invalid_data(self):
  125. """api errors for invalid request data"""
  126. self.override_acl()
  127. response = self.client.put(
  128. self.api_link,
  129. 'false',
  130. content_type="application/json",
  131. )
  132. self.assertContains(response, "Invalid data.", status_code=400)
  133. def test_edit_event(self):
  134. """events can't be edited"""
  135. self.override_acl()
  136. self.post.is_event = True
  137. self.post.save()
  138. response = self.put(self.api_link, data={})
  139. self.assertContains(response, "Events can't be edited.", status_code=403)
  140. def test_post_is_validated(self):
  141. """post is validated"""
  142. self.override_acl()
  143. response = self.put(
  144. self.api_link, data={
  145. 'post': "a",
  146. }
  147. )
  148. self.assertEqual(response.status_code, 400)
  149. self.assertEqual(
  150. response.json(), {
  151. 'post': ["Posted message should be at least 5 characters long (it has 1)."],
  152. }
  153. )
  154. def test_edit_reply_no_change(self):
  155. """endpoint isn't bumping edits count if no change was made to post's body"""
  156. self.override_acl()
  157. self.assertEqual(self.post.edits_record.count(), 0)
  158. response = self.put(self.api_link, data={'post': self.post.original})
  159. self.assertEqual(response.status_code, 200)
  160. self.override_acl()
  161. response = self.client.get(self.thread.get_absolute_url())
  162. self.assertContains(response, self.post.parsed)
  163. post = self.thread.post_set.order_by('id').last()
  164. self.assertEqual(post.edits, 0)
  165. self.assertEqual(post.original, self.post.original)
  166. self.assertIsNone(post.last_editor_id, self.user.id)
  167. self.assertIsNone(post.last_editor_name, self.user.username)
  168. self.assertIsNone(post.last_editor_slug, self.user.slug)
  169. self.assertEqual(self.post.edits_record.count(), 0)
  170. def test_edit_reply(self):
  171. """endpoint updates reply"""
  172. self.override_acl()
  173. self.assertEqual(self.post.edits_record.count(), 0)
  174. response = self.put(self.api_link, data={'post': "This is test edit!"})
  175. self.assertEqual(response.status_code, 200)
  176. self.override_acl()
  177. response = self.client.get(self.thread.get_absolute_url())
  178. self.assertContains(response, "<p>This is test edit!</p>")
  179. self.assertEqual(self.user.audittrail_set.count(), 1)
  180. post = self.thread.post_set.order_by('id').last()
  181. self.assertEqual(post.edits, 1)
  182. self.assertEqual(post.original, "This is test edit!")
  183. self.assertEqual(post.last_editor_id, self.user.id)
  184. self.assertEqual(post.last_editor_name, self.user.username)
  185. self.assertEqual(post.last_editor_slug, self.user.slug)
  186. self.assertEqual(self.post.edits_record.count(), 1)
  187. post_edit = post.edits_record.last()
  188. self.assertEqual(post_edit.edited_from, self.post.original)
  189. self.assertEqual(post_edit.edited_to, post.original)
  190. self.assertEqual(post_edit.editor_id, self.user.id)
  191. self.assertEqual(post_edit.editor_name, self.user.username)
  192. self.assertEqual(post_edit.editor_slug, self.user.slug)
  193. def test_edit_first_post_hidden(self):
  194. """endpoint updates hidden thread's first post"""
  195. self.override_acl({'can_hide_threads': 1, 'can_edit_posts': 2})
  196. self.thread.is_hidden = True
  197. self.thread.save()
  198. self.thread.first_post.is_hidden = True
  199. self.thread.first_post.save()
  200. api_link = reverse(
  201. 'misago:api:thread-post-detail',
  202. kwargs={
  203. 'thread_pk': self.thread.pk,
  204. 'pk': self.thread.first_post.pk,
  205. }
  206. )
  207. response = self.put(api_link, data={'post': "This is test edit!"})
  208. self.assertEqual(response.status_code, 200)
  209. def test_protect_post(self):
  210. """can protect post"""
  211. self.override_acl({'can_protect_posts': 1})
  212. response = self.put(
  213. self.api_link, data={
  214. 'post': "Lorem ipsum dolor met!",
  215. 'protect': 1,
  216. }
  217. )
  218. self.assertEqual(response.status_code, 200)
  219. post = self.user.post_set.order_by('id').last()
  220. self.assertTrue(post.is_protected)
  221. def test_protect_post_no_permission(self):
  222. """cant protect post without permission"""
  223. self.override_acl({'can_protect_posts': 0})
  224. response = self.put(
  225. self.api_link, data={
  226. 'post': "Lorem ipsum dolor met!",
  227. 'protect': 1,
  228. }
  229. )
  230. self.assertEqual(response.status_code, 200)
  231. post = self.user.post_set.order_by('id').last()
  232. self.assertFalse(post.is_protected)
  233. def test_post_unicode(self):
  234. """unicode characters can be posted"""
  235. self.override_acl()
  236. response = self.put(
  237. self.api_link, data={
  238. 'post': "Chrzążczyżewoszyce, powiat Łękółody.",
  239. }
  240. )
  241. self.assertEqual(response.status_code, 200)
  242. def test_reply_category_moderation_queue(self):
  243. """edit sends reply to queue due to category setup"""
  244. self.category.require_edits_approval = True
  245. self.category.save()
  246. response = self.put(
  247. self.api_link, data={
  248. 'post': "Lorem ipsum dolor met!",
  249. }
  250. )
  251. self.assertEqual(response.status_code, 200)
  252. post = self.user.post_set.all()[:1][0]
  253. self.assertTrue(post.is_unapproved)
  254. def test_reply_category_moderation_queue_bypass(self):
  255. """bypass moderation queue due to user's acl"""
  256. override_acl(self.user, {'can_approve_content': 1})
  257. self.category.require_edits_approval = True
  258. self.category.save()
  259. response = self.put(
  260. self.api_link, data={
  261. 'post': "Lorem ipsum dolor met!",
  262. }
  263. )
  264. self.assertEqual(response.status_code, 200)
  265. post = self.user.post_set.all()[:1][0]
  266. self.assertFalse(post.is_unapproved)
  267. def test_reply_user_moderation_queue(self):
  268. """edit sends reply to queue due to user acl"""
  269. self.override_acl({'require_edits_approval': 1})
  270. response = self.put(
  271. self.api_link, data={
  272. 'post': "Lorem ipsum dolor met!",
  273. }
  274. )
  275. self.assertEqual(response.status_code, 200)
  276. post = self.user.post_set.all()[:1][0]
  277. self.assertTrue(post.is_unapproved)
  278. def test_reply_user_moderation_queue_bypass(self):
  279. """bypass moderation queue due to user's acl"""
  280. override_acl(self.user, {'can_approve_content': 1})
  281. self.override_acl({'require_edits_approval': 1})
  282. response = self.put(
  283. self.api_link, data={
  284. 'post': "Lorem ipsum dolor met!",
  285. }
  286. )
  287. self.assertEqual(response.status_code, 200)
  288. post = self.user.post_set.all()[:1][0]
  289. self.assertFalse(post.is_unapproved)
  290. def test_reply_omit_other_moderation_queues(self):
  291. """other queues are omitted"""
  292. self.category.require_threads_approval = True
  293. self.category.require_replies_approval = True
  294. self.category.save()
  295. self.override_acl({
  296. 'require_threads_approval': 1,
  297. 'require_replies_approval': 1,
  298. })
  299. response = self.put(
  300. self.api_link, data={
  301. 'post': "Lorem ipsum dolor met!",
  302. }
  303. )
  304. self.assertEqual(response.status_code, 200)
  305. post = self.user.post_set.all()[:1][0]
  306. self.assertFalse(post.is_unapproved)
  307. def setUpFirstReplyTest(self):
  308. self.post = self.thread.first_post
  309. self.post.poster = self.user
  310. self.post.save()
  311. self.api_link = reverse(
  312. 'misago:api:thread-post-detail',
  313. kwargs={
  314. 'thread_pk': self.thread.pk,
  315. 'pk': self.post.pk,
  316. }
  317. )
  318. def test_first_reply_category_moderation_queue(self):
  319. """edit sends thread to queue due to category setup"""
  320. self.setUpFirstReplyTest()
  321. self.category.require_edits_approval = True
  322. self.category.save()
  323. response = self.put(
  324. self.api_link, data={
  325. 'post': "Lorem ipsum dolor met!",
  326. }
  327. )
  328. self.assertEqual(response.status_code, 200)
  329. thread = Thread.objects.get(pk=self.thread.pk)
  330. self.assertTrue(thread.is_unapproved)
  331. self.assertTrue(thread.has_unapproved_posts)
  332. post = Post.objects.get(pk=self.post.pk)
  333. self.assertTrue(post.is_unapproved)
  334. def test_first_reply_category_moderation_queue_bypass(self):
  335. """bypass moderation queue due to user's acl"""
  336. self.setUpFirstReplyTest()
  337. override_acl(self.user, {'can_approve_content': 1})
  338. self.category.require_edits_approval = True
  339. self.category.save()
  340. response = self.put(
  341. self.api_link, data={
  342. 'post': "Lorem ipsum dolor met!",
  343. }
  344. )
  345. self.assertEqual(response.status_code, 200)
  346. thread = Thread.objects.get(pk=self.thread.pk)
  347. self.assertFalse(thread.is_unapproved)
  348. self.assertFalse(thread.has_unapproved_posts)
  349. post = Post.objects.get(pk=self.post.pk)
  350. self.assertFalse(post.is_unapproved)
  351. def test_first_reply_user_moderation_queue(self):
  352. """edit sends thread to queue due to user acl"""
  353. self.setUpFirstReplyTest()
  354. self.override_acl({'require_edits_approval': 1})
  355. response = self.put(
  356. self.api_link, data={
  357. 'post': "Lorem ipsum dolor met!",
  358. }
  359. )
  360. self.assertEqual(response.status_code, 200)
  361. thread = Thread.objects.get(pk=self.thread.pk)
  362. self.assertTrue(thread.is_unapproved)
  363. self.assertTrue(thread.has_unapproved_posts)
  364. post = Post.objects.get(pk=self.post.pk)
  365. self.assertTrue(post.is_unapproved)
  366. def test_first_reply_user_moderation_queue_bypass(self):
  367. """bypass moderation queue due to user's acl"""
  368. self.setUpFirstReplyTest()
  369. override_acl(self.user, {'can_approve_content': 1})
  370. self.override_acl({'require_edits_approval': 1})
  371. response = self.put(
  372. self.api_link, data={
  373. 'post': "Lorem ipsum dolor met!",
  374. }
  375. )
  376. self.assertEqual(response.status_code, 200)
  377. thread = Thread.objects.get(pk=self.thread.pk)
  378. self.assertFalse(thread.is_unapproved)
  379. self.assertFalse(thread.has_unapproved_posts)
  380. post = Post.objects.get(pk=self.post.pk)
  381. self.assertFalse(post.is_unapproved)
  382. def test_first_reply_omit_other_moderation_queues(self):
  383. """other queues are omitted"""
  384. self.setUpFirstReplyTest()
  385. self.category.require_threads_approval = True
  386. self.category.require_replies_approval = True
  387. self.category.save()
  388. self.override_acl({
  389. 'require_threads_approval': 1,
  390. 'require_replies_approval': 1,
  391. })
  392. response = self.put(
  393. self.api_link, data={
  394. 'post': "Lorem ipsum dolor met!",
  395. }
  396. )
  397. self.assertEqual(response.status_code, 200)
  398. thread = Thread.objects.get(pk=self.thread.pk)
  399. self.assertFalse(thread.is_unapproved)
  400. self.assertFalse(thread.has_unapproved_posts)
  401. post = Post.objects.get(pk=self.post.pk)
  402. self.assertFalse(post.is_unapproved)