1234567891011121314151617181920212223242526272829303132333435363738394041424344454647484950515253545556575859606162636465666768697071727374757677787980818283848586878889909192939495969798991001011021031041051061071081091101111121131141151161171181191201211221231241251261271281291301311321331341351361371381391401411421431441451461471481491501511521531541551561571581591601611621631641651661671681691701711721731741751761771781791801811821831841851861871881891901911921931941951961971981992002012022032042052062072082092102112122132142152162172182192202212222232242252262272282292302312322332342352362372382392402412422432442452462472482492502512522532542552562572582592602612622632642652662672682692702712722732742752762772782792802812822832842852862872882892902912922932942952962972982993003013023033043053063073083093103113123133143153163173183193203213223233243253263273283293303313323333343353363373383393403413423433443453463473483493503513523533543553563573583593603613623633643653663673683693703713723733743753763773783793803813823833843853863873883893903913923933943953963973983994004014024034044054064074084094104114124134144154164174184194204214224234244254264274284294304314324334344354364374384394404414424434444454464474484494504514524534544554564574584594604614624634644654664674684694704714724734744754764774784794804814824834844854864874884894904914924934944954964974984995005015025035045055065075085095105115125135145155165175185195205215225235245255265275285295305315325335345355365375385395405415425435445455465475485495505515525535545555565575585595605615625635645655665675685695705715725735745755765775785795805815825835845855865875885895905915925935945955965975985996006016026036046056066076086096106116126136146156166176186196206216226236246256266276286296306316326336346356366376386396406416426436446456466476486496506516526536546556566576586596606616626636646656666676686696706716726736746756766776786796806816826836846856866876886896906916926936946956966976986997007017027037047057067077087097107117127137147157167177187197207217227237247257267277287297307317327337347357367377387397407417427437447457467477487497507517527537547557567577587597607617627637647657667677687697707717727737747757767777787797807817827837847857867877887897907917927937947957967977987998008018028038048058068078088098108118128138148158168178188198208218228238248258268278288298308318328338348358368378388398408418428438448458468478488498508518528538548558568578588598608618628638648658668678688698708718728738748758768778788798808818828838848858868878888898908918928938948958968978988999009019029039049059069079089099109119129139149159169179189199209219229239249259269279289299309319329339349359369379389399409419429439449459469479489499509519529539549559569579589599609619629639649659669679689699709719729739749759769779789799809819829839849859869879889899909919929939949959969979989991000100110021003100410051006100710081009101010111012101310141015101610171018101910201021102210231024102510261027102810291030103110321033103410351036103710381039104010411042104310441045104610471048104910501051105210531054105510561057105810591060106110621063106410651066106710681069107010711072107310741075107610771078107910801081108210831084108510861087108810891090109110921093109410951096109710981099110011011102110311041105110611071108110911101111111211131114111511161117111811191120112111221123112411251126112711281129113011311132113311341135113611371138113911401141114211431144114511461147114811491150115111521153115411551156115711581159116011611162116311641165116611671168116911701171117211731174117511761177117811791180118111821183118411851186118711881189119011911192119311941195119611971198119912001201120212031204120512061207120812091210121112121213121412151216121712181219122012211222122312241225122612271228122912301231123212331234123512361237123812391240124112421243124412451246124712481249125012511252125312541255125612571258125912601261126212631264126512661267126812691270127112721273127412751276127712781279128012811282128312841285128612871288128912901291129212931294129512961297129812991300130113021303130413051306130713081309131013111312131313141315131613171318131913201321132213231324132513261327132813291330133113321333133413351336133713381339134013411342134313441345134613471348134913501351135213531354135513561357135813591360136113621363136413651366136713681369137013711372137313741375137613771378137913801381138213831384138513861387138813891390139113921393139413951396139713981399140014011402140314041405140614071408140914101411141214131414141514161417141814191420142114221423142414251426142714281429143014311432143314341435143614371438143914401441144214431444144514461447144814491450145114521453145414551456145714581459146014611462146314641465146614671468146914701471147214731474147514761477147814791480148114821483148414851486148714881489149014911492149314941495149614971498149915001501150215031504150515061507150815091510151115121513151415151516151715181519152015211522152315241525152615271528152915301531153215331534153515361537153815391540154115421543154415451546154715481549155015511552155315541555155615571558155915601561156215631564156515661567156815691570157115721573157415751576157715781579158015811582158315841585158615871588158915901591159215931594159515961597159815991600160116021603160416051606160716081609161016111612161316141615161616171618161916201621162216231624162516261627162816291630163116321633163416351636163716381639164016411642164316441645164616471648164916501651165216531654165516561657165816591660166116621663166416651666166716681669167016711672167316741675167616771678167916801681168216831684168516861687168816891690169116921693169416951696169716981699170017011702170317041705170617071708170917101711171217131714171517161717171817191720172117221723172417251726172717281729173017311732173317341735173617371738173917401741174217431744174517461747174817491750175117521753175417551756175717581759176017611762176317641765176617671768176917701771177217731774177517761777177817791780178117821783178417851786178717881789179017911792179317941795179617971798179918001801180218031804180518061807180818091810181118121813181418151816181718181819182018211822182318241825182618271828182918301831183218331834183518361837183818391840184118421843184418451846184718481849185018511852185318541855185618571858185918601861186218631864186518661867186818691870187118721873187418751876187718781879188018811882188318841885188618871888188918901891189218931894189518961897189818991900190119021903190419051906190719081909191019111912191319141915191619171918191919201921192219231924192519261927192819291930193119321933193419351936193719381939194019411942194319441945194619471948194919501951195219531954195519561957195819591960196119621963196419651966196719681969197019711972197319741975197619771978197919801981198219831984198519861987198819891990199119921993199419951996199719981999200020012002200320042005200620072008200920102011201220132014201520162017201820192020202120222023202420252026202720282029203020312032203320342035203620372038203920402041204220432044204520462047204820492050205120522053205420552056205720582059206020612062206320642065206620672068206920702071207220732074207520762077207820792080208120822083208420852086208720882089209020912092209320942095209620972098209921002101210221032104210521062107210821092110211121122113211421152116211721182119212021212122212321242125212621272128212921302131213221332134213521362137213821392140214121422143214421452146214721482149215021512152215321542155215621572158215921602161216221632164216521662167216821692170217121722173217421752176217721782179218021812182218321842185218621872188218921902191219221932194219521962197219821992200220122022203220422052206220722082209221022112212221322142215221622172218221922202221222222232224222522262227222822292230223122322233223422352236223722382239224022412242224322442245224622472248224922502251225222532254225522562257225822592260226122622263226422652266226722682269227022712272227322742275227622772278227922802281228222832284228522862287228822892290229122922293229422952296229722982299230023012302230323042305230623072308230923102311231223132314231523162317231823192320232123222323232423252326232723282329233023312332233323342335233623372338233923402341234223432344234523462347234823492350235123522353235423552356235723582359236023612362236323642365236623672368236923702371237223732374237523762377237823792380238123822383238423852386238723882389239023912392239323942395239623972398239924002401240224032404240524062407240824092410241124122413241424152416241724182419242024212422242324242425242624272428242924302431243224332434243524362437243824392440244124422443244424452446 |
- import json
- from datetime import timedelta
- from django.utils import six, timezone
- from misago.acl.testutils import override_acl
- from misago.categories.models import Category
- from misago.readtracker import poststracker
- from misago.threads import testutils
- from misago.threads.models import Thread
- from .test_threads_api import ThreadsApiTestCase
- class ThreadPatchApiTestCase(ThreadsApiTestCase):
- def patch(self, api_link, ops):
- return self.client.patch(api_link, json.dumps(ops), content_type="application/json")
- class ThreadAddAclApiTests(ThreadPatchApiTestCase):
- def test_add_acl_true(self):
- """api adds current thread's acl to response"""
- response = self.patch(self.api_link, [
- {
- 'op': 'add',
- 'path': 'acl',
- 'value': True,
- },
- ])
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertTrue(response_json['acl'])
- def test_add_acl_false(self):
- """if value is false, api won't add acl to the response, but will set empty key"""
- response = self.patch(self.api_link, [
- {
- 'op': 'add',
- 'path': 'acl',
- 'value': False,
- },
- ])
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertIsNone(response_json['acl'])
- class ThreadChangeTitleApiTests(ThreadPatchApiTestCase):
- def test_change_thread_title(self):
- """api makes it possible to change thread title"""
- self.override_acl({'can_edit_threads': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'title',
- 'value': "Lorem ipsum change!",
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertEqual(response_json['title'], "Lorem ipsum change!")
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['title'], "Lorem ipsum change!")
- def test_change_thread_title_no_permission(self):
- """api validates permission to change title"""
- self.override_acl({'can_edit_threads': 0})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'title',
- 'value': "Lorem ipsum change!",
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't edit threads in this category."
- })
- def test_change_thread_title_closed_category_no_permission(self):
- """api test permission to edit thread title in closed category"""
- self.override_acl({
- 'can_edit_threads': 2,
- 'can_close_threads': 0
- })
- self.category.is_closed = True
- self.category.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'title',
- 'value': "Lorem ipsum change!",
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This category is closed. You can't edit threads in it."
- })
- def test_change_thread_title_closed_thread_no_permission(self):
- """api test permission to edit closed thread title"""
- self.override_acl({
- 'can_edit_threads': 2,
- 'can_close_threads': 0
- })
- self.thread.is_closed = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'title',
- 'value': "Lorem ipsum change!",
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This thread is closed. You can't edit it."
- })
- def test_change_thread_title_after_edit_time(self):
- """api cleans, validates and rejects too short title"""
- self.override_acl({'thread_edit_time': 1, 'can_edit_threads': 1})
- self.thread.started_on = timezone.now() - timedelta(minutes=10)
- self.thread.starter = self.user
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'title',
- 'value': "Lorem ipsum change!",
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't edit threads that are older than 1 minute."
- })
- def test_change_thread_title_invalid(self):
- """api cleans, validates and rejects too short title"""
- self.override_acl({'can_edit_threads': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'title',
- 'value': 12,
- },
- ]
- )
- self.assertEqual(response.status_code, 400)
- self.assertEqual(response.json(), {
- 'detail': ["Thread title should be at least 5 characters long (it has 2)."]
- })
- class ThreadPinGloballyApiTests(ThreadPatchApiTestCase):
- def test_pin_thread(self):
- """api makes it possible to pin globally thread"""
- self.override_acl({'can_pin_threads': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 2,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertEqual(response_json['weight'], 2)
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 2)
- def test_pin_thread_closed_category_no_permission(self):
- """api checks if category is closed"""
- self.override_acl({
- 'can_pin_threads': 2,
- 'can_close_threads': 0,
- })
- self.category.is_closed = True
- self.category.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 2,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This category is closed. You can't change threads weights in it."
- })
- def test_pin_thread_closed_no_permission(self):
- """api checks if thread is closed"""
- self.override_acl({
- 'can_pin_threads': 2,
- 'can_close_threads': 0,
- })
- self.thread.is_closed = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 2,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This thread is closed. You can't change its weight."
- })
- def test_unpin_thread(self):
- """api makes it possible to unpin thread"""
- self.thread.weight = 2
- self.thread.save()
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 2)
- self.override_acl({'can_pin_threads': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 0,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertEqual(response_json['weight'], 0)
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 0)
- def test_pin_thread_no_permission(self):
- """api pin thread globally with no permission fails"""
- self.override_acl({'can_pin_threads': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 2,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't pin threads globally in this category."
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 0)
- def test_unpin_thread_no_permission(self):
- """api unpin thread with no permission fails"""
- self.thread.weight = 2
- self.thread.save()
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 2)
- self.override_acl({'can_pin_threads': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 1,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't change globally pinned threads weights in this category."
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 2)
- class ThreadPinLocallyApiTests(ThreadPatchApiTestCase):
- def test_pin_thread(self):
- """api makes it possible to pin locally thread"""
- self.override_acl({'can_pin_threads': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 1,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertEqual(response_json['weight'], 1)
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 1)
- def test_unpin_thread(self):
- """api makes it possible to unpin thread"""
- self.thread.weight = 1
- self.thread.save()
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 1)
- self.override_acl({'can_pin_threads': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 0,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertEqual(response_json['weight'], 0)
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 0)
- def test_pin_thread_no_permission(self):
- """api pin thread locally with no permission fails"""
- self.override_acl({'can_pin_threads': 0})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 1,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't change threads weights in this category."
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 0)
- def test_unpin_thread_no_permission(self):
- """api unpin thread with no permission fails"""
- self.thread.weight = 1
- self.thread.save()
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 1)
- self.override_acl({'can_pin_threads': 0})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'weight',
- 'value': 0,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't change threads weights in this category."
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['weight'], 1)
- class ThreadMoveApiTests(ThreadPatchApiTestCase):
- def setUp(self):
- super(ThreadMoveApiTests, self).setUp()
- Category(
- name='Category B',
- slug='category-b',
- ).insert_at(
- self.category,
- position='last-child',
- save=True,
- )
- self.category_b = Category.objects.get(slug='category-b')
- def override_other_acl(self, acl):
- other_category_acl = self.user.acl_cache['categories'][self.category.pk].copy()
- other_category_acl.update({
- 'can_see': 1,
- 'can_browse': 1,
- 'can_see_all_threads': 1,
- 'can_see_own_threads': 0,
- 'can_hide_threads': 0,
- 'can_approve_content': 0,
- })
- other_category_acl.update(acl)
- categories_acl = self.user.acl_cache['categories']
- categories_acl[self.category_b.pk] = other_category_acl
- visible_categories = [self.category.pk]
- if other_category_acl['can_see']:
- visible_categories.append(self.category_b.pk)
- override_acl(
- self.user, {
- 'visible_categories': visible_categories,
- 'categories': categories_acl,
- }
- )
- def test_move_thread_no_top(self):
- """api moves thread to other category, sets no top category"""
- self.override_acl({'can_move_threads': True})
- self.override_other_acl({'can_start_threads': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- {
- 'op': 'add',
- 'path': 'top-category',
- 'value': self.category_b.pk,
- },
- {
- 'op': 'replace',
- 'path': 'flatten-categories',
- 'value': None,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- reponse_json = response.json()
- self.assertEqual(reponse_json['category'], self.category_b.pk)
- self.override_other_acl({})
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['category']['id'], self.category_b.pk)
- def test_move_thread_with_top(self):
- """api moves thread to other category, sets top"""
- self.override_acl({'can_move_threads': True})
- self.override_other_acl({'can_start_threads': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- {
- 'op': 'add',
- 'path': 'top-category',
- 'value': Category.objects.root_category().pk,
- },
- {
- 'op': 'replace',
- 'path': 'flatten-categories',
- 'value': None,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- reponse_json = response.json()
- self.assertEqual(reponse_json['category'], self.category_b.pk)
- self.override_other_acl({})
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['category']['id'], self.category_b.pk)
- def test_move_thread_reads(self):
- """api moves thread reads together with thread"""
- self.override_acl({'can_move_threads': True})
- self.override_other_acl({'can_start_threads': 2})
- poststracker.save_read(self.user, self.thread.first_post)
- self.assertEqual(self.user.postread_set.count(), 1)
- self.user.postread_set.get(category=self.category)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- {
- 'op': 'add',
- 'path': 'top-category',
- 'value': self.category_b.pk,
- },
- {
- 'op': 'replace',
- 'path': 'flatten-categories',
- 'value': None,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- # thread read was moved to new category
- postreads = self.user.postread_set.filter(post__is_event=False).order_by('id')
- self.assertEqual(postreads.count(), 1)
- postreads.get(category=self.category_b)
- def test_move_thread_subscriptions(self):
- """api moves thread subscriptions together with thread"""
- self.override_acl({'can_move_threads': True})
- self.override_other_acl({'can_start_threads': 2})
- self.user.subscription_set.create(
- thread=self.thread,
- category=self.thread.category,
- last_read_on=self.thread.last_post_on,
- send_email=False,
- )
- self.assertEqual(self.user.subscription_set.count(), 1)
- self.user.subscription_set.get(category=self.category)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- {
- 'op': 'add',
- 'path': 'top-category',
- 'value': self.category_b.pk,
- },
- {
- 'op': 'replace',
- 'path': 'flatten-categories',
- 'value': None,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- # thread read was moved to new category
- self.assertEqual(self.user.subscription_set.count(), 1)
- self.user.subscription_set.get(category=self.category_b)
- def test_move_thread_no_permission(self):
- """api move thread to other category with no permission fails"""
- self.override_acl({'can_move_threads': False})
- self.override_other_acl({})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't move threads in this category."
- })
-
- self.override_other_acl({})
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['category']['id'], self.category.pk)
- def test_move_thread_closed_category_no_permission(self):
- """api move thread from closed category with no permission fails"""
- self.override_acl({
- 'can_move_threads': True,
- 'can_close_threads': False,
- })
- self.override_other_acl({})
- self.category.is_closed = True
- self.category.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This category is closed. You can't move it's threads."
- })
- def test_move_closed_thread_no_permission(self):
- """api move closed thread with no permission fails"""
- self.override_acl({
- 'can_move_threads': True,
- 'can_close_threads': False,
- })
- self.override_other_acl({})
- self.thread.is_closed = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This thread is closed. You can't move it."
- })
- def test_move_thread_no_category_access(self):
- """api move thread to category with no access fails"""
- self.override_acl({'can_move_threads': True})
- self.override_other_acl({'can_see': False})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- ]
- )
- self.assertEqual(response.status_code, 404)
- self.assertEqual(response.json(), {
- 'detail': "NOT FOUND"
- })
- self.override_other_acl({})
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['category']['id'], self.category.pk)
- def test_move_thread_no_category_browse(self):
- """api move thread to category with no browsing access fails"""
- self.override_acl({'can_move_threads': True})
- self.override_other_acl({'can_browse': False})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': 'You don\'t have permission to browse "Category B" contents.'
- })
- self.override_other_acl({})
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['category']['id'], self.category.pk)
- def test_move_thread_no_category_start_threads(self):
- """api move thread to category with no posting access fails"""
- self.override_acl({'can_move_threads': True})
- self.override_other_acl({'can_start_threads': False})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.category_b.pk,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You don't have permission to start new threads in this category."
- })
- self.override_other_acl({})
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['category']['id'], self.category.pk)
- def test_move_thread_same_category(self):
- """api move thread to category it's already in fails"""
- self.override_acl({'can_move_threads': True})
- self.override_other_acl({'can_start_threads': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'category',
- 'value': self.thread.category_id,
- },
- ]
- )
- self.assertEqual(response.status_code, 400)
- self.assertEqual(response.json(), {
- 'detail': ["You can't move thread to the category it's already in."]
- })
- self.override_other_acl({})
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['category']['id'], self.category.pk)
- def test_thread_flatten_categories(self):
- """api flatten thread categories"""
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'flatten-categories',
- 'value': None,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertEqual(response_json['category'], self.category.pk)
- class ThreadCloseApiTests(ThreadPatchApiTestCase):
- def test_close_thread(self):
- """api makes it possible to close thread"""
- self.override_acl({'can_close_threads': True})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-closed',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertTrue(response_json['is_closed'])
- thread_json = self.get_thread_json()
- self.assertTrue(thread_json['is_closed'])
- def test_open_thread(self):
- """api makes it possible to open thread"""
- self.thread.is_closed = True
- self.thread.save()
- thread_json = self.get_thread_json()
- self.assertTrue(thread_json['is_closed'])
- self.override_acl({'can_close_threads': True})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-closed',
- 'value': False,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertFalse(response_json['is_closed'])
- thread_json = self.get_thread_json()
- self.assertFalse(thread_json['is_closed'])
- def test_close_thread_no_permission(self):
- """api close thread with no permission fails"""
- self.override_acl({'can_close_threads': False})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-closed',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You don't have permission to close this thread."
- })
- thread_json = self.get_thread_json()
- self.assertFalse(thread_json['is_closed'])
- def test_open_thread_no_permission(self):
- """api open thread with no permission fails"""
- self.thread.is_closed = True
- self.thread.save()
- thread_json = self.get_thread_json()
- self.assertTrue(thread_json['is_closed'])
- self.override_acl({'can_close_threads': False})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-closed',
- 'value': False,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You don't have permission to open this thread."
- })
- thread_json = self.get_thread_json()
- self.assertTrue(thread_json['is_closed'])
- class ThreadApproveApiTests(ThreadPatchApiTestCase):
- def test_approve_thread(self):
- """api makes it possible to approve thread"""
- self.thread.first_post.is_unapproved = True
- self.thread.first_post.save()
- self.thread.synchronize()
- self.thread.save()
- self.assertTrue(self.thread.is_unapproved)
- self.assertTrue(self.thread.has_unapproved_posts)
- self.override_acl({'can_approve_content': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-unapproved',
- 'value': False,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- response_json = response.json()
- self.assertFalse(response_json['is_unapproved'])
- self.assertFalse(response_json['has_unapproved_posts'])
- thread_json = self.get_thread_json()
- self.assertFalse(thread_json['is_unapproved'])
- self.assertFalse(thread_json['has_unapproved_posts'])
- thread = Thread.objects.get(pk=self.thread.pk)
- self.assertFalse(thread.is_unapproved)
- self.assertFalse(thread.has_unapproved_posts)
- def test_approve_thread_category_closed_no_permission(self):
- """api checks permission for approving threads in closed categories"""
- self.thread.first_post.is_unapproved = True
- self.thread.first_post.save()
- self.thread.synchronize()
- self.thread.save()
- self.assertTrue(self.thread.is_unapproved)
- self.assertTrue(self.thread.has_unapproved_posts)
- self.category.is_closed = True
- self.category.save()
- self.override_acl({
- 'can_approve_content': 1,
- 'can_close_threads': 0,
- })
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-unapproved',
- 'value': False,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This category is closed. You can't approve threads in it."
- })
- def test_approve_thread_closed_no_permission(self):
- """api checks permission for approving posts in closed categories"""
- self.thread.first_post.is_unapproved = True
- self.thread.first_post.save()
- self.thread.synchronize()
- self.thread.save()
- self.assertTrue(self.thread.is_unapproved)
- self.assertTrue(self.thread.has_unapproved_posts)
- self.thread.is_closed = True
- self.thread.save()
- self.override_acl({
- 'can_approve_content': 1,
- 'can_close_threads': 0,
- })
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-unapproved',
- 'value': False,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This thread is closed. You can't approve it."
- })
- def test_unapprove_thread(self):
- """api returns permission error on approval removal"""
- self.override_acl({'can_approve_content': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-unapproved',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "Content approval can't be reversed."
- })
- class ThreadHideApiTests(ThreadPatchApiTestCase):
- def test_hide_thread(self):
- """api makes it possible to hide thread"""
- self.override_acl({'can_hide_threads': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- reponse_json = response.json()
- self.assertTrue(reponse_json['is_hidden'])
- self.override_acl({'can_hide_threads': 1})
- thread_json = self.get_thread_json()
- self.assertTrue(thread_json['is_hidden'])
- def test_hide_thread_no_permission(self):
- """api hide thread with no permission fails"""
- self.override_acl({'can_hide_threads': 0})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't hide threads in this category."
- })
- thread_json = self.get_thread_json()
- self.assertFalse(thread_json['is_hidden'])
- def test_hide_non_owned_thread(self):
- """api forbids non-moderator from hiding other users threads"""
- self.override_acl({
- 'can_hide_own_threads': 1,
- 'can_hide_threads': 0
- })
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't hide other users theads in this category."
- })
- def test_hide_owned_thread_no_time(self):
- """api forbids non-moderator from hiding other users threads"""
- self.override_acl({
- 'can_hide_own_threads': 1,
- 'can_hide_threads': 0,
- 'thread_edit_time': 1,
- })
- self.thread.started_on = timezone.now() - timedelta(minutes=5)
- self.thread.starter = self.user
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "You can't hide threads that are older than 1 minute."
- })
- def test_hide_closed_category_no_permission(self):
- """api test permission to hide thread in closed category"""
- self.override_acl({
- 'can_hide_threads': 1,
- 'can_close_threads': 0
- })
- self.category.is_closed = True
- self.category.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This category is closed. You can't hide threads in it."
- })
- def test_hide_closed_thread_no_permission(self):
- """api test permission to hide closed thread"""
- self.override_acl({
- 'can_hide_threads': 1,
- 'can_close_threads': 0
- })
- self.thread.is_closed = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This thread is closed. You can't hide it."
- })
- class ThreadUnhideApiTests(ThreadPatchApiTestCase):
- def setUp(self):
- super(ThreadUnhideApiTests, self).setUp()
- self.thread.is_hidden = True
- self.thread.save()
- def test_unhide_thread(self):
- """api makes it possible to unhide thread"""
- self.override_acl({'can_hide_threads': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': False,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- reponse_json = response.json()
- self.assertFalse(reponse_json['is_hidden'])
- self.override_acl({'can_hide_threads': 1})
- thread_json = self.get_thread_json()
- self.assertFalse(thread_json['is_hidden'])
- def test_unhide_thread_no_permission(self):
- """api unhide thread with no permission fails as thread is invisible"""
- self.override_acl({'can_hide_threads': 0})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': True,
- },
- ]
- )
- self.assertEqual(response.status_code, 404)
- def test_unhide_closed_category_no_permission(self):
- """api test permission to unhide thread in closed category"""
- self.override_acl({
- 'can_hide_threads': 1,
- 'can_close_threads': 0
- })
- self.category.is_closed = True
- self.category.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': False,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This category is closed. You can't reveal threads in it."
- })
- def test_unhide_closed_thread_no_permission(self):
- """api test permission to unhide closed thread"""
- self.override_acl({
- 'can_hide_threads': 1,
- 'can_close_threads': 0
- })
- self.thread.is_closed = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'is-hidden',
- 'value': False,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This thread is closed. You can't reveal it."
- })
- class ThreadSubscribeApiTests(ThreadPatchApiTestCase):
- def test_subscribe_thread(self):
- """api makes it possible to subscribe thread"""
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'subscription',
- 'value': 'notify',
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- reponse_json = response.json()
- self.assertFalse(reponse_json['subscription'])
- thread_json = self.get_thread_json()
- self.assertFalse(thread_json['subscription'])
- subscription = self.user.subscription_set.get(thread=self.thread)
- self.assertFalse(subscription.send_email)
- def test_subscribe_thread_with_email(self):
- """api makes it possible to subscribe thread with emails"""
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'subscription',
- 'value': 'email',
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- reponse_json = response.json()
- self.assertTrue(reponse_json['subscription'])
- thread_json = self.get_thread_json()
- self.assertTrue(thread_json['subscription'])
- subscription = self.user.subscription_set.get(thread=self.thread)
- self.assertTrue(subscription.send_email)
- def test_unsubscribe_thread(self):
- """api makes it possible to unsubscribe thread"""
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'subscription',
- 'value': 'remove',
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- reponse_json = response.json()
- self.assertIsNone(reponse_json['subscription'])
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['subscription'])
- self.assertEqual(self.user.subscription_set.count(), 0)
- def test_subscribe_as_guest(self):
- """api makes it impossible to subscribe thread"""
- self.logout_user()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'subscription',
- 'value': 'email',
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- def test_subscribe_nonexistant_thread(self):
- """api makes it impossible to subscribe nonexistant thread"""
- bad_api_link = self.api_link.replace(
- six.text_type(self.thread.pk), six.text_type(self.thread.pk + 9)
- )
- response = self.patch(
- bad_api_link, [
- {
- 'op': 'replace',
- 'path': 'subscription',
- 'value': 'email',
- },
- ]
- )
- self.assertEqual(response.status_code, 404)
- class ThreadMarkBestAnswerApiTests(ThreadPatchApiTestCase):
- def test_mark_best_answer(self):
- """api makes it possible to mark best answer"""
- self.override_acl({'can_mark_best_answers': 2})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- self.assertEqual(response.json(), {
- 'id': self.thread.id,
- 'best_answer': best_answer.id,
- 'best_answer_is_protected': False,
- 'best_answer_marked_on': response.json()['best_answer_marked_on'],
- 'best_answer_marked_by': self.user.id,
- 'best_answer_marked_by_name': self.user.username,
- 'best_answer_marked_by_slug': self.user.slug,
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], best_answer.id)
- self.assertEqual(thread_json['best_answer_is_protected'], False)
- self.assertEqual(
- thread_json['best_answer_marked_on'], response.json()['best_answer_marked_on'])
- self.assertEqual(thread_json['best_answer_marked_by'], self.user.id)
- self.assertEqual(thread_json['best_answer_marked_by_name'], self.user.username)
- self.assertEqual(thread_json['best_answer_marked_by_slug'], self.user.slug)
- def test_mark_best_answer_anonymous(self):
- """api validates that user is authenticated before marking best answer"""
- self.logout_user()
- self.override_acl({'can_mark_best_answers': 2})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This action is not available to guests.",
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_no_permission(self):
- """api validates permission to mark best answers"""
- self.override_acl({'can_mark_best_answers': 0})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- 'You don\'t have permission to mark best answers in the "First category" category.'
- ),
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_not_thread_starter(self):
- """api validates permission to mark best answers in owned thread"""
- self.override_acl({'can_mark_best_answers': 1})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You don't have permission to mark best answer in this thread because you didn't "
- "start it."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- # passing scenario is possible
- self.thread.starter = self.user
- self.thread.save()
- self.override_acl({'can_mark_best_answers': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_mark_best_answer_category_closed(self):
- """api validates permission to mark best answers in closed category"""
- self.override_acl({'can_mark_best_answers': 2, 'can_close_threads': 0})
- best_answer = testutils.reply_thread(self.thread)
- self.category.is_closed = True
- self.category.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- 'You don\'t have permission to mark best answer in this thread because its '
- 'category "First category" is closed.'
- ),
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- # passing scenario is possible
- self.override_acl({'can_mark_best_answers': 2, 'can_close_threads': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_mark_best_answer_thread_closed(self):
- """api validates permission to mark best answers in closed thread"""
- self.override_acl({'can_mark_best_answers': 2, 'can_close_threads': 0})
- best_answer = testutils.reply_thread(self.thread)
- self.thread.is_closed = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You can't mark best answer in this thread because it's closed and you don't have "
- "permission to open it."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- # passing scenario is possible
- self.override_acl({'can_mark_best_answers': 2, 'can_close_threads': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_mark_best_answer_invalid_post_id(self):
- """api validates that post id is int"""
- self.override_acl({'can_mark_best_answers': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': 'd7sd89a7d98sa',
- },
- ]
- )
- self.assertEqual(response.status_code, 400)
- self.assertEqual(response.json(), {
- 'detail': ["A valid integer is required."],
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_post_not_found(self):
- """api validates that post exists"""
- self.override_acl({'can_mark_best_answers': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': self.thread.last_post_id + 1,
- },
- ]
- )
- self.assertEqual(response.status_code, 404)
- self.assertEqual(response.json(), {
- 'detail': "No Post matches the given query.",
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
-
- def test_mark_best_answer_post_invisible(self):
- """api validates post visibility to action author"""
- self.override_acl({'can_mark_best_answers': 2})
- unapproved_post = testutils.reply_thread(self.thread, is_unapproved=True)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': unapproved_post.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 404)
- self.assertEqual(response.json(), {
- 'detail': "NOT FOUND",
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_post_other_thread(self):
- """api validates post belongs to same thread"""
- self.override_acl({'can_mark_best_answers': 2})
- other_thread = testutils.post_thread(self.category)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': other_thread.first_post_id,
- },
- ]
- )
- self.assertEqual(response.status_code, 404)
- self.assertEqual(response.json(), {
- 'detail': "No Post matches the given query.",
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_event_id(self):
- """api validates that post is not an event"""
- self.override_acl({'can_mark_best_answers': 2})
- best_answer = testutils.reply_thread(self.thread)
- best_answer.is_event = True
- best_answer.save()
-
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "Events can't be marked as best answers.",
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_first_post(self):
- """api validates that post is not a first post in thread"""
- self.override_acl({'can_mark_best_answers': 2})
-
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': self.thread.first_post_id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "First post in a thread can't be marked as best answer.",
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_hidden_post(self):
- """api validates that post is not hidden"""
- self.override_acl({'can_mark_best_answers': 2})
-
- best_answer = testutils.reply_thread(self.thread, is_hidden=True)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "Hidden posts can't be marked as best answers.",
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_unapproved_post(self):
- """api validates that post is not unapproved"""
- self.override_acl({'can_mark_best_answers': 2})
-
- best_answer = testutils.reply_thread(self.thread, poster=self.user, is_unapproved=True)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "Unapproved posts can't be marked as best answers.",
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- def test_mark_best_answer_protected_post(self):
- """api respects post protection"""
- self.override_acl({'can_mark_best_answers': 2, 'can_protect_posts': 0})
-
- best_answer = testutils.reply_thread(self.thread, is_protected=True)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You don't have permission to mark this post as best answer because a moderator "
- "has protected it."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- # passing scenario is possible
- self.override_acl({'can_mark_best_answers': 2, 'can_protect_posts': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- class ThreadChangeBestAnswerApiTests(ThreadPatchApiTestCase):
- def setUp(self):
- super(ThreadChangeBestAnswerApiTests, self).setUp()
- self.best_answer = testutils.reply_thread(self.thread)
- self.thread.set_best_answer(self.user, self.best_answer)
- self.thread.save()
- def test_change_best_answer(self):
- """api makes it possible to change best answer"""
- self.override_acl({'can_mark_best_answers': 2, 'can_change_marked_answers': 2})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- self.assertEqual(response.json(), {
- 'id': self.thread.id,
- 'best_answer': best_answer.id,
- 'best_answer_is_protected': False,
- 'best_answer_marked_on': response.json()['best_answer_marked_on'],
- 'best_answer_marked_by': self.user.id,
- 'best_answer_marked_by_name': self.user.username,
- 'best_answer_marked_by_slug': self.user.slug,
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], best_answer.id)
- self.assertEqual(thread_json['best_answer_is_protected'], False)
- self.assertEqual(
- thread_json['best_answer_marked_on'], response.json()['best_answer_marked_on'])
- self.assertEqual(thread_json['best_answer_marked_by'], self.user.id)
- self.assertEqual(thread_json['best_answer_marked_by_name'], self.user.username)
- self.assertEqual(thread_json['best_answer_marked_by_slug'], self.user.slug)
- def test_change_best_answer_same_post(self):
- """api validates if new best answer is same as current one"""
- self.override_acl({'can_mark_best_answers': 2, 'can_change_marked_answers': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "This post is already marked as thread's best answer.",
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- def test_change_best_answer_no_permission_to_mark(self):
- """api validates permission to mark best answers before allowing answer change"""
- self.override_acl({'can_mark_best_answers': 0, 'can_change_marked_answers': 2})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- 'You don\'t have permission to mark best answers in the "First category" category.'
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- def test_change_best_answer_no_permission(self):
- """api validates permission to change best answers"""
- self.override_acl({'can_mark_best_answers': 2, 'can_change_marked_answers': 0})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- 'You don\'t have permission to change this thread\'s marked answer because it\'s '
- 'in the "First category" category.'
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- def test_change_best_answer_not_starter(self):
- """api validates permission to change best answers"""
- self.override_acl({'can_mark_best_answers': 2, 'can_change_marked_answers': 1})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You don't have permission to change this thread's marked answer because you are "
- "not a thread starter."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- # passing scenario is possible
- self.override_acl({'can_mark_best_answers': 2, 'can_change_marked_answers': 1})
-
- self.thread.starter = self.user
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_change_best_answer_timelimit(self):
- """api validates permission for starter to change best answers within timelimit"""
- self.override_acl({
- 'can_mark_best_answers': 2,
- 'can_change_marked_answers': 1,
- 'best_answer_change_time': 5,
- })
- best_answer = testutils.reply_thread(self.thread)
- self.thread.best_answer_marked_on = timezone.now() - timedelta(minutes=6)
- self.thread.starter = self.user
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You don't have permission to change best answer that was marked for more than "
- "5 minutes."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- # passing scenario is possible
- self.override_acl({
- 'can_mark_best_answers': 2,
- 'can_change_marked_answers': 1,
- 'best_answer_change_time': 10,
- })
-
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_change_best_answer_protected(self):
- """api validates permission to change protected best answers"""
- self.override_acl({
- 'can_mark_best_answers': 2,
- 'can_change_marked_answers': 2,
- 'can_protect_posts': 0,
- })
- best_answer = testutils.reply_thread(self.thread)
- self.thread.best_answer_is_protected = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You don't have permission to change this thread's best answer because a "
- "moderator has protected it."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- # passing scenario is possible
- self.override_acl({
- 'can_mark_best_answers': 2,
- 'can_change_marked_answers': 2,
- 'can_protect_posts': 1,
- })
-
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_change_best_answer_post_validation(self):
- """api validates new post'"""
- self.override_acl({
- 'can_mark_best_answers': 2,
- 'can_change_marked_answers': 2,
- })
- best_answer = testutils.reply_thread(self.thread, is_hidden=True)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'replace',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': "Hidden posts can't be marked as best answers.",
- })
-
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- class ThreadUnmarkBestAnswerApiTests(ThreadPatchApiTestCase):
- def setUp(self):
- super(ThreadUnmarkBestAnswerApiTests, self).setUp()
- self.best_answer = testutils.reply_thread(self.thread)
- self.thread.set_best_answer(self.user, self.best_answer)
- self.thread.save()
- def test_unmark_best_answer(self):
- """api makes it possible to unmark best answer"""
- self.override_acl({'can_mark_best_answers': 0, 'can_change_marked_answers': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- self.assertEqual(response.json(), {
- 'id': self.thread.id,
- 'best_answer': None,
- 'best_answer_is_protected': False,
- 'best_answer_marked_on': None,
- 'best_answer_marked_by': None,
- 'best_answer_marked_by_name': None,
- 'best_answer_marked_by_slug': None,
- })
- thread_json = self.get_thread_json()
- self.assertIsNone(thread_json['best_answer'])
- self.assertFalse(thread_json['best_answer_is_protected'])
- self.assertIsNone(thread_json['best_answer_marked_on'])
- self.assertIsNone(thread_json['best_answer_marked_by'])
- self.assertIsNone(thread_json['best_answer_marked_by_name'])
- self.assertIsNone(thread_json['best_answer_marked_by_slug'])
- def test_unmark_best_answer_invalid_post_id(self):
- """api validates that post id is int"""
- self.override_acl({'can_mark_best_answers': 0, 'can_change_marked_answers': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': 'd7sd89a7d98sa',
- },
- ]
- )
- self.assertEqual(response.status_code, 400)
- self.assertEqual(response.json(), {
- 'detail': ["A valid integer is required."],
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- def test_unmark_best_answer_post_not_found(self):
- """api validates that post to unmark exists"""
- self.override_acl({'can_mark_best_answers': 0, 'can_change_marked_answers': 2})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id + 1,
- },
- ]
- )
- self.assertEqual(response.status_code, 404)
- self.assertEqual(response.json(), {
- 'detail': "No Post matches the given query.",
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
-
- def test_unmark_best_answer_wrong_post(self):
- """api validates if post given to unmark is best answer"""
- self.override_acl({'can_mark_best_answers': 0, 'can_change_marked_answers': 2})
- best_answer = testutils.reply_thread(self.thread)
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "This post can't be unmarked because it's not currently marked as best answer."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- def test_unmark_best_answer_no_permission(self):
- """api validates if user has permission to unmark best answers"""
- self.override_acl({'can_mark_best_answers': 0, 'can_change_marked_answers': 0})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- 'You don\'t have permission to unmark threads answers in the "First category" '
- 'category.'
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- def test_unmark_best_answer_not_starter(self):
- """api validates if starter has permission to unmark best answers"""
- self.override_acl({'can_mark_best_answers': 0, 'can_change_marked_answers': 1})
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You don't have permission to unmark this best answer because you are not a "
- "thread starter."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- # passing scenario is possible
- self.override_acl({'can_mark_best_answers': 0, 'can_change_marked_answers': 1})
- self.thread.starter = self.user
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_unmark_best_answer_timelimit(self):
- """api validates if starter has permission to unmark best answer within time limit"""
- self.override_acl({
- 'can_mark_best_answers': 0,
- 'can_change_marked_answers': 1,
- 'best_answer_change_time': 5,
- })
- self.thread.best_answer_marked_on = timezone.now() - timedelta(minutes=6)
- self.thread.starter = self.user
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You don't have permission to unmark best answer that was marked for more than "
- "5 minutes."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- # passing scenario is possible
- self.override_acl({
- 'can_mark_best_answers': 0,
- 'can_change_marked_answers': 1,
- 'best_answer_change_time': 10,
- })
-
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_unmark_best_answer_closed_category(self):
- """api validates if user has permission to unmark best answer in closed category"""
- self.override_acl({
- 'can_mark_best_answers': 0,
- 'can_change_marked_answers': 2,
- 'can_close_threads': 0,
- })
- self.category.is_closed = True
- self.category.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- 'You don\'t have permission to unmark this best answer because its category '
- '"First category" is closed.'
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- # passing scenario is possible
- self.override_acl({
- 'can_mark_best_answers': 0,
- 'can_change_marked_answers': 2,
- 'can_close_threads': 1,
- })
-
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_unmark_best_answer_closed_thread(self):
- """api validates if user has permission to unmark best answer in closed thread"""
- self.override_acl({
- 'can_mark_best_answers': 0,
- 'can_change_marked_answers': 2,
- 'can_close_threads': 0,
- })
- self.thread.is_closed = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You can't unmark this thread's best answer because it's closed and you don't "
- "have permission to open it."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- # passing scenario is possible
- self.override_acl({
- 'can_mark_best_answers': 0,
- 'can_change_marked_answers': 2,
- 'can_close_threads': 1,
- })
-
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
- def test_unmark_best_answer_protected(self):
- """api validates permission to unmark protected best answers"""
- self.override_acl({
- 'can_mark_best_answers': 0,
- 'can_change_marked_answers': 2,
- 'can_protect_posts': 0,
- })
- self.thread.best_answer_is_protected = True
- self.thread.save()
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 403)
- self.assertEqual(response.json(), {
- 'detail': (
- "You don't have permission to unmark this thread's best answer because a "
- "moderator has protected it."
- ),
- })
- thread_json = self.get_thread_json()
- self.assertEqual(thread_json['best_answer'], self.best_answer.id)
- # passing scenario is possible
- self.override_acl({
- 'can_mark_best_answers': 0,
- 'can_change_marked_answers': 2,
- 'can_protect_posts': 1,
- })
-
- response = self.patch(
- self.api_link, [
- {
- 'op': 'remove',
- 'path': 'best-answer',
- 'value': self.best_answer.id,
- },
- ]
- )
- self.assertEqual(response.status_code, 200)
|