test_thread_pollvotes_api.py 19 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588
  1. from datetime import timedelta
  2. from django.contrib.auth import get_user_model
  3. from django.urls import reverse
  4. from django.utils import timezone
  5. from misago.core.utils import serialize_datetime
  6. from misago.threads.models import Poll
  7. from .test_thread_poll_api import ThreadPollApiTestCase
  8. UserModel = get_user_model()
  9. class ThreadGetVotesTests(ThreadPollApiTestCase):
  10. def setUp(self):
  11. super(ThreadGetVotesTests, self).setUp()
  12. self.mock_poll()
  13. self.poll.is_public = True
  14. self.poll.save()
  15. self.api_link = reverse(
  16. 'misago:api:thread-poll-votes',
  17. kwargs={
  18. 'thread_pk': self.thread.pk,
  19. 'pk': self.poll.pk,
  20. }
  21. )
  22. def get_votes_json(self):
  23. choices_votes = {choice['hash']: [] for choice in self.poll.choices}
  24. queryset = self.poll.pollvote_set.order_by('-id').select_related()
  25. for vote in queryset:
  26. choices_votes[vote.choice_hash].append({
  27. 'id': vote.voter_id,
  28. 'username': vote.voter_name,
  29. 'slug': vote.voter_slug,
  30. 'voted_on': serialize_datetime(vote.voted_on),
  31. })
  32. return choices_votes
  33. def test_anonymous(self):
  34. """api allows guests to get poll votes"""
  35. self.logout_user()
  36. votes_json = self.get_votes_json()
  37. response = self.client.get(self.api_link)
  38. self.assertEqual(response.status_code, 200)
  39. self.assertEqual(response.json(), [
  40. {
  41. 'hash': 'aaaaaaaaaaaa',
  42. 'label': 'Alpha',
  43. 'votes': 1,
  44. 'voters': votes_json['aaaaaaaaaaaa'],
  45. },
  46. {
  47. 'hash': 'bbbbbbbbbbbb',
  48. 'label': 'Beta',
  49. 'votes': 0,
  50. 'voters': [],
  51. },
  52. {
  53. 'hash': 'gggggggggggg',
  54. 'label': 'Gamma',
  55. 'votes': 2,
  56. 'voters': votes_json['gggggggggggg'],
  57. },
  58. {
  59. 'hash': 'dddddddddddd',
  60. 'label': 'Delta',
  61. 'votes': 1,
  62. 'voters': votes_json['dddddddddddd'],
  63. },
  64. ])
  65. self.assertEqual(len(votes_json['aaaaaaaaaaaa']), 1)
  66. self.assertEqual(len(votes_json['bbbbbbbbbbbb']), 0)
  67. self.assertEqual(len(votes_json['gggggggggggg']), 2)
  68. self.assertEqual(len(votes_json['dddddddddddd']), 1)
  69. def test_invalid_thread_id(self):
  70. """api validates that thread id is integer"""
  71. api_link = reverse(
  72. 'misago:api:thread-poll-votes',
  73. kwargs={
  74. 'thread_pk': 'kjha6dsa687sa',
  75. 'pk': self.poll.pk,
  76. }
  77. )
  78. response = self.client.get(api_link)
  79. self.assertEqual(response.status_code, 404)
  80. self.assertEqual(response.json(), {'detail': 'NOT FOUND'})
  81. def test_nonexistant_thread_id(self):
  82. """api validates that thread exists"""
  83. api_link = reverse(
  84. 'misago:api:thread-poll-votes',
  85. kwargs={
  86. 'thread_pk': self.thread.pk + 1,
  87. 'pk': self.poll.pk,
  88. }
  89. )
  90. response = self.client.get(api_link)
  91. self.assertEqual(response.status_code, 404)
  92. self.assertEqual(response.json(), {'detail': 'NOT FOUND'})
  93. def test_invalid_poll_id(self):
  94. """api validates that poll id is integer"""
  95. api_link = reverse(
  96. 'misago:api:thread-poll-votes',
  97. kwargs={
  98. 'thread_pk': self.thread.pk,
  99. 'pk': 'sad98as7d97sa98',
  100. }
  101. )
  102. response = self.client.get(api_link)
  103. self.assertEqual(response.status_code, 404)
  104. self.assertEqual(response.json(), {'detail': 'NOT FOUND'})
  105. def test_nonexistant_poll_id(self):
  106. """api validates that poll exists"""
  107. api_link = reverse(
  108. 'misago:api:thread-poll-votes',
  109. kwargs={
  110. 'thread_pk': self.thread.pk,
  111. 'pk': self.poll.pk + 123,
  112. }
  113. )
  114. response = self.client.get(api_link)
  115. self.assertEqual(response.status_code, 404)
  116. self.assertEqual(response.json(), {'detail': 'NOT FOUND'})
  117. def test_no_permission(self):
  118. """api chcecks permission to see poll voters"""
  119. self.override_acl({'can_always_see_poll_voters': False})
  120. self.poll.is_public = False
  121. self.poll.save()
  122. response = self.client.get(self.api_link)
  123. self.assertEqual(response.status_code, 403)
  124. self.assertEqual(response.json(), {
  125. 'detail': "You dont have permission to this poll's voters.",
  126. })
  127. def test_nonpublic_poll(self):
  128. """api validates that poll is public"""
  129. self.logout_user()
  130. self.poll.is_public = False
  131. self.poll.save()
  132. response = self.client.get(self.api_link)
  133. self.assertEqual(response.status_code, 403)
  134. self.assertEqual(response.json(), {
  135. 'detail': "You dont have permission to this poll's voters.",
  136. })
  137. def test_get_votes(self):
  138. """api returns list of voters"""
  139. votes_json = self.get_votes_json()
  140. response = self.client.get(self.api_link)
  141. self.assertEqual(response.status_code, 200)
  142. self.assertEqual(response.json(), [
  143. {
  144. 'hash': 'aaaaaaaaaaaa',
  145. 'label': 'Alpha',
  146. 'votes': 1,
  147. 'voters': votes_json['aaaaaaaaaaaa'],
  148. },
  149. {
  150. 'hash': 'bbbbbbbbbbbb',
  151. 'label': 'Beta',
  152. 'votes': 0,
  153. 'voters': [],
  154. },
  155. {
  156. 'hash': 'gggggggggggg',
  157. 'label': 'Gamma',
  158. 'votes': 2,
  159. 'voters': votes_json['gggggggggggg'],
  160. },
  161. {
  162. 'hash': 'dddddddddddd',
  163. 'label': 'Delta',
  164. 'votes': 1,
  165. 'voters': votes_json['dddddddddddd'],
  166. },
  167. ])
  168. self.assertEqual(len(votes_json['aaaaaaaaaaaa']), 1)
  169. self.assertEqual(len(votes_json['bbbbbbbbbbbb']), 0)
  170. self.assertEqual(len(votes_json['gggggggggggg']), 2)
  171. self.assertEqual(len(votes_json['dddddddddddd']), 1)
  172. def test_get_votes_private_poll(self):
  173. """api returns list of voters on private poll for user with permission"""
  174. self.override_acl({'can_always_see_poll_voters': True})
  175. self.poll.is_public = False
  176. self.poll.save()
  177. votes_json = self.get_votes_json()
  178. response = self.client.get(self.api_link)
  179. self.assertEqual(response.status_code, 200)
  180. self.assertEqual(response.json(), [
  181. {
  182. 'hash': 'aaaaaaaaaaaa',
  183. 'label': 'Alpha',
  184. 'votes': 1,
  185. 'voters': votes_json['aaaaaaaaaaaa'],
  186. },
  187. {
  188. 'hash': 'bbbbbbbbbbbb',
  189. 'label': 'Beta',
  190. 'votes': 0,
  191. 'voters': [],
  192. },
  193. {
  194. 'hash': 'gggggggggggg',
  195. 'label': 'Gamma',
  196. 'votes': 2,
  197. 'voters': votes_json['gggggggggggg'],
  198. },
  199. {
  200. 'hash': 'dddddddddddd',
  201. 'label': 'Delta',
  202. 'votes': 1,
  203. 'voters': votes_json['dddddddddddd'],
  204. },
  205. ])
  206. self.assertEqual(len(votes_json['aaaaaaaaaaaa']), 1)
  207. self.assertEqual(len(votes_json['bbbbbbbbbbbb']), 0)
  208. self.assertEqual(len(votes_json['gggggggggggg']), 2)
  209. self.assertEqual(len(votes_json['dddddddddddd']), 1)
  210. class ThreadPostVotesTests(ThreadPollApiTestCase):
  211. def setUp(self):
  212. super(ThreadPostVotesTests, self).setUp()
  213. self.mock_poll()
  214. self.api_link = reverse(
  215. 'misago:api:thread-poll-votes',
  216. kwargs={
  217. 'thread_pk': self.thread.pk,
  218. 'pk': self.poll.pk,
  219. }
  220. )
  221. def delete_user_votes(self):
  222. self.poll.choices[2]['votes'] = 1
  223. self.poll.choices[3]['votes'] = 0
  224. self.poll.votes = 2
  225. self.poll.save()
  226. self.poll.pollvote_set.filter(voter=self.user).delete()
  227. def test_anonymous(self):
  228. """api requires you to sign in to vote in poll"""
  229. self.logout_user()
  230. response = self.post(self.api_link)
  231. self.assertEqual(response.status_code, 403)
  232. self.assertEqual(response.json(), {
  233. 'detail': "This action is not available to guests.",
  234. })
  235. def test_empty_vote_json(self):
  236. """api validates if vote that user has made was empty"""
  237. self.delete_user_votes()
  238. response = self.client.post(
  239. self.api_link, '[]', content_type='application/json'
  240. )
  241. self.assertEqual(response.status_code, 400)
  242. self.assertEqual(response.json(), {
  243. 'choices': ["You have to make a choice."],
  244. })
  245. def test_empty_vote_form(self):
  246. """api validates if vote that user has made was empty"""
  247. self.delete_user_votes()
  248. response = self.client.post(self.api_link)
  249. self.assertEqual(response.status_code, 400)
  250. self.assertEqual(response.json(), {
  251. 'choices': ["You have to make a choice."],
  252. })
  253. def test_malformed_vote(self):
  254. """api validates if vote that user has made was correctly structured"""
  255. self.delete_user_votes()
  256. response = self.post(self.api_link)
  257. self.assertEqual(response.status_code, 400)
  258. self.assertEqual(response.json(), {
  259. 'choices': ['Expected a list of items but got type "dict".'],
  260. })
  261. response = self.post(self.api_link, data={})
  262. self.assertEqual(response.status_code, 400)
  263. self.assertEqual(response.json(), {
  264. 'choices': ['Expected a list of items but got type "dict".'],
  265. })
  266. response = self.post(self.api_link, data='hello')
  267. self.assertEqual(response.status_code, 400)
  268. self.assertEqual(response.json(), {
  269. 'choices': ['Expected a list of items but got type "str".'],
  270. })
  271. response = self.post(self.api_link, data=123)
  272. self.assertEqual(response.status_code, 400)
  273. self.assertEqual(response.json(), {
  274. 'choices': ['Expected a list of items but got type "int".'],
  275. })
  276. def test_invalid_choices(self):
  277. """api validates if vote that user has made overlaps with allowed votes"""
  278. self.delete_user_votes()
  279. response = self.post(self.api_link, data=['lorem', 'ipsum'])
  280. self.assertEqual(response.status_code, 400)
  281. self.assertEqual(response.json(), {
  282. 'choices': ["One or more of poll choices were invalid."],
  283. })
  284. def test_too_many_choices(self):
  285. """api validates if vote that user has made overlaps with allowed votes"""
  286. self.poll.allowed_choices = 1
  287. self.poll.allow_revotes = True
  288. self.poll.save()
  289. response = self.post(self.api_link, data=['aaaaaaaaaaaa', 'bbbbbbbbbbbb'])
  290. self.assertEqual(response.status_code, 400)
  291. self.assertEqual(response.json(), {
  292. 'choices': ["This poll disallows voting for more than 1 choice."],
  293. })
  294. def test_revote(self):
  295. """api validates if user is trying to change vote in poll that disallows revoting"""
  296. response = self.post(self.api_link, data=['lorem', 'ipsum'])
  297. self.assertEqual(response.status_code, 403)
  298. self.assertEqual(response.json(), {
  299. 'detail': "You have already voted in this poll.",
  300. })
  301. self.delete_user_votes()
  302. response = self.post(self.api_link)
  303. self.assertEqual(response.status_code, 400)
  304. def test_vote_in_closed_thread(self):
  305. """api validates is user has permission to vote poll in closed thread"""
  306. self.override_acl(category={'can_close_threads': 0})
  307. self.thread.is_closed = True
  308. self.thread.save()
  309. self.delete_user_votes()
  310. response = self.post(self.api_link)
  311. self.assertEqual(response.status_code, 403)
  312. self.assertEqual(response.json(), {
  313. 'detail': "This thread is closed. You can't vote in it.",
  314. })
  315. self.override_acl(category={'can_close_threads': 1})
  316. response = self.post(self.api_link)
  317. self.assertEqual(response.status_code, 400)
  318. def test_vote_in_closed_category(self):
  319. """api validates is user has permission to vote poll in closed category"""
  320. self.override_acl(category={'can_close_threads': 0})
  321. self.category.is_closed = True
  322. self.category.save()
  323. self.delete_user_votes()
  324. response = self.post(self.api_link)
  325. self.assertEqual(response.status_code, 403)
  326. self.assertEqual(response.json(), {
  327. 'detail': "This category is closed. You can't vote in it.",
  328. })
  329. self.override_acl(category={'can_close_threads': 1})
  330. response = self.post(self.api_link)
  331. self.assertEqual(response.status_code, 400)
  332. def test_vote_in_finished_poll(self):
  333. """api valdiates if poll has finished before letting user to vote in it"""
  334. self.poll.posted_on = timezone.now() - timedelta(days=15)
  335. self.poll.length = 5
  336. self.poll.save()
  337. self.delete_user_votes()
  338. response = self.post(self.api_link)
  339. self.assertEqual(response.status_code, 403)
  340. self.assertEqual(response.json(), {
  341. 'detail': "This poll is over. You can't vote in it.",
  342. })
  343. self.poll.length = 50
  344. self.poll.save()
  345. response = self.post(self.api_link)
  346. self.assertEqual(response.status_code, 400)
  347. def test_fresh_vote(self):
  348. """api handles first vote in poll"""
  349. self.delete_user_votes()
  350. response = self.post(self.api_link, data=['aaaaaaaaaaaa', 'bbbbbbbbbbbb'])
  351. self.assertEqual(response.status_code, 200)
  352. self.assertEqual(response.json(), {
  353. 'id': self.poll.id,
  354. 'poster': {
  355. 'id': self.user.id,
  356. 'username': self.user.username,
  357. 'slug': self.user.slug,
  358. },
  359. 'posted_on': serialize_datetime(self.poll.posted_on),
  360. 'length': 0,
  361. 'question': "Lorem ipsum dolor met?",
  362. 'allowed_choices': 2,
  363. 'allow_revotes': False,
  364. 'votes': 4,
  365. 'is_public': False,
  366. 'choices': [
  367. {
  368. 'hash': 'aaaaaaaaaaaa',
  369. 'label': 'Alpha',
  370. 'selected': True,
  371. 'votes': 2
  372. },
  373. {
  374. 'hash': 'bbbbbbbbbbbb',
  375. 'label': 'Beta',
  376. 'selected': True,
  377. 'votes': 1
  378. },
  379. {
  380. 'hash': 'gggggggggggg',
  381. 'label': 'Gamma',
  382. 'selected': False,
  383. 'votes': 1
  384. },
  385. {
  386. 'hash': 'dddddddddddd',
  387. 'label': 'Delta',
  388. 'selected': False,
  389. 'votes': 0
  390. },
  391. ],
  392. })
  393. # validate state change
  394. poll = Poll.objects.get(pk=self.poll.pk)
  395. self.assertEqual(poll.votes, 4)
  396. self.assertEqual(poll.choices, [
  397. {
  398. 'hash': 'aaaaaaaaaaaa',
  399. 'label': 'Alpha',
  400. 'votes': 2
  401. },
  402. {
  403. 'hash': 'bbbbbbbbbbbb',
  404. 'label': 'Beta',
  405. 'votes': 1
  406. },
  407. {
  408. 'hash': 'gggggggggggg',
  409. 'label': 'Gamma',
  410. 'votes': 1
  411. },
  412. {
  413. 'hash': 'dddddddddddd',
  414. 'label': 'Delta',
  415. 'votes': 0
  416. },
  417. ])
  418. self.assertEqual(poll.pollvote_set.count(), 4)
  419. # validate poll disallows for revote
  420. response = self.post(self.api_link, data=['aaaaaaaaaaaa'])
  421. self.assertEqual(response.status_code, 403)
  422. self.assertEqual(response.json(), {
  423. 'detail': "You have already voted in this poll.",
  424. })
  425. def test_vote_change(self):
  426. """api handles vote change"""
  427. self.poll.allow_revotes = True
  428. self.poll.save()
  429. response = self.post(self.api_link, data=['aaaaaaaaaaaa', 'bbbbbbbbbbbb'])
  430. self.assertEqual(response.status_code, 200)
  431. self.assertEqual(response.json(), {
  432. 'id': self.poll.id,
  433. 'poster': {
  434. 'id': self.user.id,
  435. 'username': self.user.username,
  436. 'slug': self.user.slug,
  437. },
  438. 'posted_on': serialize_datetime(self.poll.posted_on),
  439. 'length': 0,
  440. 'question': "Lorem ipsum dolor met?",
  441. 'allowed_choices': 2,
  442. 'allow_revotes': True,
  443. 'votes': 4,
  444. 'is_public': False,
  445. 'choices': [
  446. {
  447. 'hash': 'aaaaaaaaaaaa',
  448. 'label': 'Alpha',
  449. 'selected': True,
  450. 'votes': 2
  451. },
  452. {
  453. 'hash': 'bbbbbbbbbbbb',
  454. 'label': 'Beta',
  455. 'selected': True,
  456. 'votes': 1
  457. },
  458. {
  459. 'hash': 'gggggggggggg',
  460. 'label': 'Gamma',
  461. 'selected': False,
  462. 'votes': 1
  463. },
  464. {
  465. 'hash': 'dddddddddddd',
  466. 'label': 'Delta',
  467. 'selected': False,
  468. 'votes': 0
  469. },
  470. ],
  471. })
  472. # validate state change
  473. poll = Poll.objects.get(pk=self.poll.pk)
  474. self.assertEqual(poll.votes, 4)
  475. self.assertEqual(poll.choices, [
  476. {
  477. 'hash': 'aaaaaaaaaaaa',
  478. 'label': 'Alpha',
  479. 'votes': 2
  480. },
  481. {
  482. 'hash': 'bbbbbbbbbbbb',
  483. 'label': 'Beta',
  484. 'votes': 1
  485. },
  486. {
  487. 'hash': 'gggggggggggg',
  488. 'label': 'Gamma',
  489. 'votes': 1
  490. },
  491. {
  492. 'hash': 'dddddddddddd',
  493. 'label': 'Delta',
  494. 'votes': 0
  495. },
  496. ])
  497. self.assertEqual(poll.pollvote_set.count(), 4)
  498. # validate poll allows for revote
  499. response = self.post(self.api_link, data=['aaaaaaaaaaaa'])
  500. self.assertEqual(response.status_code, 200)