test_threads_merge_api.py 31 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501502503504505506507508509510511512513514515516517518519520521522523524525526527528529530531532533534535536537538539540541542543544545546547548549550551552553554555556557558559560561562563564565566567568569570571572573574575576577578579580581582583584585586587588589590591592593594595596597598599600601602603604605606607608609610611612613614615616617618619620621622623624625626627628629630631632633634635636637638639640641642643644645646647648649650651652653654655656657658659660661662663664665666667668669670671672673674675676677678679680681682683684685686687688689690691692693694695696697698699700701702703704705706707708709710711712713714715716717718719720721722723724725726727728729730731732733734735736737738739740741742743744745746747748749750751752753754755756757758759760761762763764765766767768769770771772773774775776777778779780781782783784785786787788789790791792793794795796797798799800801802803804805806807808809810811812813814815816817818819820821822823824825826827828829830831832833834835836837838839840841842843844845846847848849850851852853854855856857858859860861862863864865866867868869870871872873874875876877878879880881882883884885886887888889890891892893894895896897898899900901902903904905906907908909910911912913914915916917918919920921922923924925926927928929930931932933934935936937938939940941942943944945946947948949950951952953954955956957958959960961962963964965966967968
  1. import json
  2. from django.urls import reverse
  3. from misago.acl import add_acl
  4. from misago.acl.testutils import override_acl
  5. from misago.categories.models import Category
  6. from misago.threads import testutils
  7. from misago.threads.serializers.moderation import THREADS_LIMIT
  8. from misago.threads.models import Poll, PollVote, Post, Thread
  9. from misago.threads.serializers import ThreadsListSerializer
  10. from .test_threads_api import ThreadsApiTestCase
  11. class ThreadsMergeApiTests(ThreadsApiTestCase):
  12. def setUp(self):
  13. super(ThreadsMergeApiTests, self).setUp()
  14. self.api_link = reverse('misago:api:thread-merge')
  15. Category(
  16. name='Category B',
  17. slug='category-b',
  18. ).insert_at(
  19. self.category,
  20. position='last-child',
  21. save=True,
  22. )
  23. self.category_b = Category.objects.get(slug='category-b')
  24. def override_other_category(self):
  25. categories = self.user.acl_cache['categories']
  26. visible_categories = self.user.acl_cache['visible_categories']
  27. browseable_categories = self.user.acl_cache['browseable_categories']
  28. visible_categories.append(self.category_b.pk)
  29. browseable_categories.append(self.category_b.pk)
  30. override_acl(
  31. self.user, {
  32. 'visible_categories': visible_categories,
  33. 'browseable_categories': browseable_categories,
  34. 'categories': {
  35. self.category.pk: categories[self.category.pk],
  36. self.category_b.pk: {
  37. 'can_see': 1,
  38. 'can_browse': 1,
  39. 'can_see_all_threads': 1,
  40. 'can_see_own_threads': 0,
  41. 'can_start_threads': 2,
  42. },
  43. },
  44. }
  45. )
  46. def test_merge_no_threads(self):
  47. """api validates if we are trying to merge no threads"""
  48. response = self.client.post(self.api_link, content_type="application/json")
  49. self.assertEqual(response.status_code, 403)
  50. response_json = response.json()
  51. self.assertEqual(
  52. response_json, {
  53. 'detail': "You have to select at least two threads to merge.",
  54. }
  55. )
  56. def test_merge_empty_threads(self):
  57. """api validates if we are trying to empty threads list"""
  58. response = self.client.post(
  59. self.api_link,
  60. json.dumps({
  61. 'threads': [],
  62. }),
  63. content_type="application/json",
  64. )
  65. self.assertEqual(response.status_code, 403)
  66. response_json = response.json()
  67. self.assertEqual(
  68. response_json, {
  69. 'detail': "You have to select at least two threads to merge.",
  70. }
  71. )
  72. def test_merge_invalid_threads(self):
  73. """api validates if we are trying to merge invalid thread ids"""
  74. response = self.client.post(
  75. self.api_link,
  76. json.dumps({
  77. 'threads': 'abcd',
  78. }),
  79. content_type="application/json",
  80. )
  81. self.assertContains(response, "Expected a list of items", status_code=403)
  82. response = self.client.post(
  83. self.api_link,
  84. json.dumps({
  85. 'threads': ['a', '-', 'c'],
  86. }),
  87. content_type="application/json",
  88. )
  89. self.assertEqual(response.status_code, 403)
  90. response_json = response.json()
  91. self.assertEqual(
  92. response_json, {
  93. 'detail': "One or more thread ids received were invalid.",
  94. }
  95. )
  96. def test_merge_single_thread(self):
  97. """api validates if we are trying to merge single thread"""
  98. response = self.client.post(
  99. self.api_link,
  100. json.dumps({
  101. 'threads': [self.thread.id],
  102. }),
  103. content_type="application/json",
  104. )
  105. self.assertEqual(response.status_code, 403)
  106. response_json = response.json()
  107. self.assertEqual(
  108. response_json, {
  109. 'detail': "You have to select at least two threads to merge.",
  110. }
  111. )
  112. def test_merge_with_nonexisting_thread(self):
  113. """api validates if we are trying to merge with invalid thread"""
  114. response = self.client.post(
  115. self.api_link,
  116. json.dumps({
  117. 'threads': [self.thread.id, self.thread.id + 1000],
  118. }),
  119. content_type="application/json",
  120. )
  121. self.assertEqual(response.status_code, 403)
  122. response_json = response.json()
  123. self.assertEqual(
  124. response_json, {
  125. 'detail': "One or more threads to merge could not be found.",
  126. }
  127. )
  128. def test_merge_with_invisible_thread(self):
  129. """api validates if we are trying to merge with inaccesible thread"""
  130. unaccesible_thread = testutils.post_thread(category=self.category_b)
  131. response = self.client.post(
  132. self.api_link,
  133. json.dumps({
  134. 'threads': [self.thread.id, unaccesible_thread.id],
  135. }),
  136. content_type="application/json",
  137. )
  138. self.assertEqual(response.status_code, 403)
  139. response_json = response.json()
  140. self.assertEqual(
  141. response_json, {
  142. 'detail': "One or more threads to merge could not be found.",
  143. }
  144. )
  145. def test_merge_no_permission(self):
  146. """api validates permission to merge threads"""
  147. thread = testutils.post_thread(category=self.category)
  148. response = self.client.post(
  149. self.api_link,
  150. json.dumps({
  151. 'category': self.category.pk,
  152. 'title': 'Lorem ipsum dolor',
  153. 'threads': [self.thread.id, thread.id],
  154. }),
  155. content_type="application/json",
  156. )
  157. self.assertEqual(response.status_code, 403)
  158. response_json = response.json()
  159. self.assertEqual(
  160. response_json, [
  161. {
  162. 'id': thread.pk,
  163. 'title': thread.title,
  164. 'errors': ["You can't merge threads in this category."],
  165. },
  166. {
  167. 'id': self.thread.pk,
  168. 'title': self.thread.title,
  169. 'errors': ["You can't merge threads in this category."],
  170. },
  171. ]
  172. )
  173. def test_thread_category_is_closed(self):
  174. """api validates if thread's category is open"""
  175. self.override_acl({
  176. 'can_merge_threads': 1,
  177. 'can_close_threads': 0,
  178. })
  179. self.override_other_category()
  180. other_thread = testutils.post_thread(self.category)
  181. self.category.is_closed = True
  182. self.category.save()
  183. response = self.client.post(
  184. self.api_link,
  185. json.dumps({
  186. 'category': self.category_b.pk,
  187. 'title': 'Lorem ipsum dolor',
  188. 'threads': [self.thread.id, other_thread.id],
  189. }),
  190. content_type="application/json",
  191. )
  192. self.assertContains(
  193. response,
  194. "This category is closed. You can't merge it's threads.",
  195. status_code=403,
  196. )
  197. def test_thread_is_closed(self):
  198. """api validates if thread is open"""
  199. self.override_acl({
  200. 'can_merge_threads': 1,
  201. 'can_close_threads': 0,
  202. })
  203. self.override_other_category()
  204. other_thread = testutils.post_thread(self.category)
  205. other_thread.is_closed = True
  206. other_thread.save()
  207. response = self.client.post(
  208. self.api_link,
  209. json.dumps({
  210. 'category': self.category_b.pk,
  211. 'title': 'Lorem ipsum dolor',
  212. 'threads': [self.thread.id, other_thread.id],
  213. }),
  214. content_type="application/json",
  215. )
  216. self.assertContains(
  217. response,
  218. "This thread is closed. You can't merge it with other threads.",
  219. status_code=403,
  220. )
  221. def test_merge_too_many_threads(self):
  222. """api rejects too many threads to merge"""
  223. threads = []
  224. for _ in range(THREADS_LIMIT + 1):
  225. threads.append(testutils.post_thread(category=self.category).pk)
  226. self.override_acl({
  227. 'can_merge_threads': True,
  228. 'can_close_threads': False,
  229. 'can_edit_threads': False,
  230. 'can_reply_threads': False,
  231. })
  232. response = self.client.post(
  233. self.api_link,
  234. json.dumps({
  235. 'threads': threads,
  236. }),
  237. content_type="application/json",
  238. )
  239. self.assertEqual(response.status_code, 403)
  240. response_json = response.json()
  241. self.assertEqual(
  242. response_json, {
  243. 'detail': "No more than %s threads can be merged at single time." % THREADS_LIMIT,
  244. }
  245. )
  246. def test_merge_no_final_thread(self):
  247. """api rejects merge because no data to merge threads was specified"""
  248. self.override_acl({
  249. 'can_merge_threads': True,
  250. 'can_close_threads': False,
  251. 'can_edit_threads': False,
  252. 'can_reply_threads': False,
  253. })
  254. thread = testutils.post_thread(category=self.category)
  255. response = self.client.post(
  256. self.api_link,
  257. json.dumps({
  258. 'threads': [self.thread.id, thread.id],
  259. }),
  260. content_type="application/json",
  261. )
  262. self.assertEqual(response.status_code, 400)
  263. response_json = response.json()
  264. self.assertEqual(
  265. response_json, {
  266. 'title': ['This field is required.'],
  267. 'category': ['This field is required.'],
  268. }
  269. )
  270. def test_merge_invalid_final_title(self):
  271. """api rejects merge because final thread title was invalid"""
  272. self.override_acl({
  273. 'can_merge_threads': True,
  274. 'can_close_threads': False,
  275. 'can_edit_threads': False,
  276. 'can_reply_threads': False,
  277. })
  278. thread = testutils.post_thread(category=self.category)
  279. response = self.client.post(
  280. self.api_link,
  281. json.dumps({
  282. 'threads': [self.thread.id, thread.id],
  283. 'title': '$$$',
  284. 'category': self.category.id,
  285. }),
  286. content_type="application/json",
  287. )
  288. self.assertEqual(response.status_code, 400)
  289. response_json = response.json()
  290. self.assertEqual(
  291. response_json, {
  292. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  293. }
  294. )
  295. def test_merge_invalid_category(self):
  296. """api rejects merge because final category was invalid"""
  297. self.override_acl({
  298. 'can_merge_threads': True,
  299. 'can_close_threads': False,
  300. 'can_edit_threads': False,
  301. 'can_reply_threads': False,
  302. })
  303. thread = testutils.post_thread(category=self.category)
  304. response = self.client.post(
  305. self.api_link,
  306. json.dumps({
  307. 'threads': [self.thread.id, thread.id],
  308. 'title': 'Valid thread title',
  309. 'category': self.category_b.id,
  310. }),
  311. content_type="application/json",
  312. )
  313. self.assertEqual(response.status_code, 400)
  314. response_json = response.json()
  315. self.assertEqual(
  316. response_json, {
  317. 'category': ["Requested category could not be found."],
  318. }
  319. )
  320. def test_merge_unallowed_start_thread(self):
  321. """api rejects merge because category isn't allowing starting threads"""
  322. self.override_acl({
  323. 'can_merge_threads': True,
  324. 'can_close_threads': False,
  325. 'can_edit_threads': False,
  326. 'can_reply_threads': False,
  327. 'can_start_threads': 0,
  328. })
  329. thread = testutils.post_thread(category=self.category)
  330. response = self.client.post(
  331. self.api_link,
  332. json.dumps({
  333. 'threads': [self.thread.id, thread.id],
  334. 'title': 'Valid thread title',
  335. 'category': self.category.id,
  336. }),
  337. content_type="application/json",
  338. )
  339. self.assertEqual(response.status_code, 400)
  340. response_json = response.json()
  341. self.assertEqual(
  342. response_json, {
  343. 'category': ["You can't create new threads in selected category."],
  344. }
  345. )
  346. def test_merge_invalid_weight(self):
  347. """api rejects merge because final weight was invalid"""
  348. self.override_acl({
  349. 'can_merge_threads': True,
  350. 'can_close_threads': False,
  351. 'can_edit_threads': False,
  352. 'can_reply_threads': False,
  353. })
  354. thread = testutils.post_thread(category=self.category)
  355. response = self.client.post(
  356. self.api_link,
  357. json.dumps({
  358. 'threads': [self.thread.id, thread.id],
  359. 'title': 'Valid thread title',
  360. 'category': self.category.id,
  361. 'weight': 4,
  362. }),
  363. content_type="application/json",
  364. )
  365. self.assertEqual(response.status_code, 400)
  366. response_json = response.json()
  367. self.assertEqual(
  368. response_json, {
  369. 'weight': ["Ensure this value is less than or equal to 2."],
  370. }
  371. )
  372. def test_merge_unallowed_global_weight(self):
  373. """api rejects merge because global weight was unallowed"""
  374. self.override_acl({
  375. 'can_merge_threads': True,
  376. 'can_close_threads': False,
  377. 'can_edit_threads': False,
  378. 'can_reply_threads': False,
  379. })
  380. thread = testutils.post_thread(category=self.category)
  381. response = self.client.post(
  382. self.api_link,
  383. json.dumps({
  384. 'threads': [self.thread.id, thread.id],
  385. 'title': 'Valid thread title',
  386. 'category': self.category.id,
  387. 'weight': 2,
  388. }),
  389. content_type="application/json",
  390. )
  391. self.assertEqual(response.status_code, 400)
  392. response_json = response.json()
  393. self.assertEqual(
  394. response_json, {
  395. 'weight': ["You don't have permission to pin threads globally in this category."],
  396. }
  397. )
  398. def test_merge_unallowed_local_weight(self):
  399. """api rejects merge because local weight was unallowed"""
  400. self.override_acl({
  401. 'can_merge_threads': True,
  402. 'can_close_threads': False,
  403. 'can_edit_threads': False,
  404. 'can_reply_threads': False,
  405. })
  406. thread = testutils.post_thread(category=self.category)
  407. response = self.client.post(
  408. self.api_link,
  409. json.dumps({
  410. 'threads': [self.thread.id, thread.id],
  411. 'title': 'Valid thread title',
  412. 'category': self.category.id,
  413. 'weight': 1,
  414. }),
  415. content_type="application/json",
  416. )
  417. self.assertEqual(response.status_code, 400)
  418. response_json = response.json()
  419. self.assertEqual(
  420. response_json, {
  421. 'weight': ["You don't have permission to pin threads in this category."],
  422. }
  423. )
  424. def test_merge_allowed_local_weight(self):
  425. """api allows local weight"""
  426. self.override_acl({
  427. 'can_merge_threads': True,
  428. 'can_close_threads': False,
  429. 'can_edit_threads': False,
  430. 'can_reply_threads': False,
  431. 'can_pin_threads': 1,
  432. })
  433. thread = testutils.post_thread(category=self.category)
  434. response = self.client.post(
  435. self.api_link,
  436. json.dumps({
  437. 'threads': [self.thread.id, thread.id],
  438. 'title': '$$$',
  439. 'category': self.category.id,
  440. 'weight': 1,
  441. }),
  442. content_type="application/json",
  443. )
  444. self.assertEqual(response.status_code, 400)
  445. response_json = response.json()
  446. self.assertEqual(
  447. response_json, {
  448. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  449. }
  450. )
  451. def test_merge_allowed_global_weight(self):
  452. """api allows global weight"""
  453. self.override_acl({
  454. 'can_merge_threads': True,
  455. 'can_close_threads': False,
  456. 'can_edit_threads': False,
  457. 'can_reply_threads': False,
  458. 'can_pin_threads': 2,
  459. })
  460. thread = testutils.post_thread(category=self.category)
  461. response = self.client.post(
  462. self.api_link,
  463. json.dumps({
  464. 'threads': [self.thread.id, thread.id],
  465. 'title': '$$$',
  466. 'category': self.category.id,
  467. 'weight': 2,
  468. }),
  469. content_type="application/json",
  470. )
  471. self.assertEqual(response.status_code, 400)
  472. response_json = response.json()
  473. self.assertEqual(
  474. response_json, {
  475. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  476. }
  477. )
  478. def test_merge_unallowed_close(self):
  479. """api rejects merge because closing thread was unallowed"""
  480. self.override_acl({
  481. 'can_merge_threads': True,
  482. 'can_close_threads': False,
  483. 'can_edit_threads': False,
  484. 'can_reply_threads': False,
  485. })
  486. thread = testutils.post_thread(category=self.category)
  487. response = self.client.post(
  488. self.api_link,
  489. json.dumps({
  490. 'threads': [self.thread.id, thread.id],
  491. 'title': 'Valid thread title',
  492. 'category': self.category.id,
  493. 'is_closed': True,
  494. }),
  495. content_type="application/json",
  496. )
  497. self.assertEqual(response.status_code, 400)
  498. response_json = response.json()
  499. self.assertEqual(
  500. response_json, {
  501. 'is_closed': ["You don't have permission to close threads in this category."],
  502. }
  503. )
  504. def test_merge_with_close(self):
  505. """api allows for closing thread"""
  506. self.override_acl({
  507. 'can_merge_threads': True,
  508. 'can_edit_threads': False,
  509. 'can_reply_threads': False,
  510. 'can_close_threads': True,
  511. })
  512. thread = testutils.post_thread(category=self.category)
  513. response = self.client.post(
  514. self.api_link,
  515. json.dumps({
  516. 'threads': [self.thread.id, thread.id],
  517. 'title': '$$$',
  518. 'category': self.category.id,
  519. 'weight': 0,
  520. 'is_closed': True,
  521. }),
  522. content_type="application/json",
  523. )
  524. self.assertEqual(response.status_code, 400)
  525. response_json = response.json()
  526. self.assertEqual(
  527. response_json, {
  528. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  529. }
  530. )
  531. def test_merge_unallowed_hidden(self):
  532. """api rejects merge because hidden thread was unallowed"""
  533. self.override_acl({
  534. 'can_merge_threads': True,
  535. 'can_close_threads': False,
  536. 'can_edit_threads': False,
  537. 'can_reply_threads': False,
  538. 'can_hide_threads': 0,
  539. })
  540. thread = testutils.post_thread(category=self.category)
  541. response = self.client.post(
  542. self.api_link,
  543. json.dumps({
  544. 'threads': [self.thread.id, thread.id],
  545. 'title': 'Valid thread title',
  546. 'category': self.category.id,
  547. 'is_hidden': True,
  548. }),
  549. content_type="application/json",
  550. )
  551. self.assertEqual(response.status_code, 400)
  552. response_json = response.json()
  553. self.assertEqual(
  554. response_json, {
  555. 'is_hidden': ["You don't have permission to hide threads in this category."],
  556. }
  557. )
  558. def test_merge_with_hide(self):
  559. """api allows for hiding thread"""
  560. self.override_acl({
  561. 'can_merge_threads': True,
  562. 'can_close_threads': False,
  563. 'can_edit_threads': False,
  564. 'can_reply_threads': False,
  565. 'can_hide_threads': 1,
  566. })
  567. thread = testutils.post_thread(category=self.category)
  568. response = self.client.post(
  569. self.api_link,
  570. json.dumps({
  571. 'threads': [self.thread.id, thread.id],
  572. 'title': '$$$',
  573. 'category': self.category.id,
  574. 'weight': 0,
  575. 'is_hidden': True,
  576. }),
  577. content_type="application/json",
  578. )
  579. self.assertEqual(response.status_code, 400)
  580. response_json = response.json()
  581. self.assertEqual(
  582. response_json, {
  583. 'title': ["Thread title should be at least 5 characters long (it has 3)."],
  584. }
  585. )
  586. def test_merge(self):
  587. """api performs basic merge"""
  588. posts_ids = [p.id for p in Post.objects.all()]
  589. self.override_acl({
  590. 'can_merge_threads': True,
  591. 'can_close_threads': False,
  592. 'can_edit_threads': False,
  593. 'can_reply_threads': False,
  594. })
  595. thread = testutils.post_thread(category=self.category)
  596. response = self.client.post(
  597. self.api_link,
  598. json.dumps({
  599. 'threads': [self.thread.id, thread.id],
  600. 'title': 'Merged thread!',
  601. 'category': self.category.id,
  602. }),
  603. content_type="application/json",
  604. )
  605. self.assertEqual(response.status_code, 200)
  606. # is response json with new thread?
  607. response_json = response.json()
  608. new_thread = Thread.objects.get(pk=response_json['id'])
  609. new_thread.is_read = False
  610. new_thread.subscription = None
  611. add_acl(self.user, new_thread.category)
  612. add_acl(self.user, new_thread)
  613. self.assertEqual(response_json, ThreadsListSerializer(new_thread).data)
  614. # did posts move to new thread?
  615. for post in Post.objects.filter(id__in=posts_ids):
  616. self.assertEqual(post.thread_id, new_thread.id)
  617. # are old threads gone?
  618. self.assertEqual([t.pk for t in Thread.objects.all()], [new_thread.pk])
  619. def test_merge_kitchensink(self):
  620. """api performs merge"""
  621. posts_ids = [p.id for p in Post.objects.all()]
  622. self.override_acl({
  623. 'can_merge_threads': True,
  624. 'can_close_threads': True,
  625. 'can_hide_threads': 1,
  626. 'can_pin_threads': 2,
  627. })
  628. thread = testutils.post_thread(category=self.category)
  629. response = self.client.post(
  630. self.api_link,
  631. json.dumps({
  632. 'threads': [self.thread.id, thread.id],
  633. 'title': 'Merged thread!',
  634. 'category': self.category.id,
  635. 'is_closed': 1,
  636. 'is_hidden': 1,
  637. 'weight': 2,
  638. }),
  639. content_type="application/json",
  640. )
  641. self.assertEqual(response.status_code, 200)
  642. # is response json with new thread?
  643. response_json = response.json()
  644. new_thread = Thread.objects.get(pk=response_json['id'])
  645. new_thread.is_read = False
  646. new_thread.subscription = None
  647. self.assertEqual(new_thread.weight, 2)
  648. self.assertTrue(new_thread.is_closed)
  649. self.assertTrue(new_thread.is_hidden)
  650. add_acl(self.user, new_thread.category)
  651. add_acl(self.user, new_thread)
  652. self.assertEqual(response_json, ThreadsListSerializer(new_thread).data)
  653. # did posts move to new thread?
  654. for post in Post.objects.filter(id__in=posts_ids):
  655. self.assertEqual(post.thread_id, new_thread.id)
  656. # are old threads gone?
  657. self.assertEqual([t.pk for t in Thread.objects.all()], [new_thread.pk])
  658. def test_merge_threads_kept_poll(self):
  659. """api merges two threads successfully, keeping poll from old thread"""
  660. self.override_acl({'can_merge_threads': True})
  661. other_thread = testutils.post_thread(self.category)
  662. poll = testutils.post_poll(other_thread, self.user)
  663. response = self.client.post(
  664. self.api_link,
  665. json.dumps({
  666. 'threads': [self.thread.id, other_thread.id],
  667. 'title': 'Merged thread!',
  668. 'category': self.category.id,
  669. }),
  670. content_type="application/json",
  671. )
  672. self.assertEqual(response.status_code, 200)
  673. response_json = response.json()
  674. new_thread = Thread.objects.get(pk=response_json['id'])
  675. # poll and its votes were kept
  676. self.assertEqual(Poll.objects.filter(pk=poll.pk, thread=new_thread).count(), 1)
  677. self.assertEqual(PollVote.objects.filter(poll=poll, thread=new_thread).count(), 4)
  678. self.assertEqual(Poll.objects.count(), 1)
  679. self.assertEqual(PollVote.objects.count(), 4)
  680. def test_merge_threads_moved_poll(self):
  681. """api merges two threads successfully, moving poll from other thread"""
  682. self.override_acl({'can_merge_threads': True})
  683. other_thread = testutils.post_thread(self.category)
  684. poll = testutils.post_poll(self.thread, self.user)
  685. response = self.client.post(
  686. self.api_link,
  687. json.dumps({
  688. 'threads': [self.thread.id, other_thread.id],
  689. 'title': 'Merged thread!',
  690. 'category': self.category.id,
  691. }),
  692. content_type="application/json",
  693. )
  694. self.assertEqual(response.status_code, 200)
  695. response_json = response.json()
  696. new_thread = Thread.objects.get(pk=response_json['id'])
  697. # poll and its votes were kept
  698. self.assertEqual(Poll.objects.filter(pk=poll.pk, thread=new_thread).count(), 1)
  699. self.assertEqual(PollVote.objects.filter(poll=poll, thread=new_thread).count(), 4)
  700. self.assertEqual(Poll.objects.count(), 1)
  701. self.assertEqual(PollVote.objects.count(), 4)
  702. def test_threads_merge_conflict(self):
  703. """api errors on merge conflict, returning list of available polls"""
  704. self.override_acl({'can_merge_threads': True})
  705. other_thread = testutils.post_thread(self.category)
  706. poll = testutils.post_poll(self.thread, self.user)
  707. other_poll = testutils.post_poll(other_thread, self.user)
  708. response = self.client.post(
  709. self.api_link,
  710. json.dumps({
  711. 'threads': [self.thread.id, other_thread.id],
  712. 'title': 'Merged thread!',
  713. 'category': self.category.id,
  714. }),
  715. content_type="application/json",
  716. )
  717. self.assertEqual(response.status_code, 400)
  718. self.assertEqual(
  719. response.json(), {
  720. 'polls': [
  721. [0, "Delete all polls"],
  722. [poll.pk, poll.question],
  723. [other_poll.pk, other_poll.question],
  724. ],
  725. }
  726. )
  727. # polls and votes were untouched
  728. self.assertEqual(Poll.objects.count(), 2)
  729. self.assertEqual(PollVote.objects.count(), 8)
  730. def test_threads_merge_conflict_invalid_resolution(self):
  731. """api errors on invalid merge conflict resolution"""
  732. self.override_acl({'can_merge_threads': True})
  733. other_thread = testutils.post_thread(self.category)
  734. testutils.post_poll(self.thread, self.user)
  735. testutils.post_poll(other_thread, self.user)
  736. response = self.client.post(
  737. self.api_link,
  738. json.dumps({
  739. 'threads': [self.thread.id, other_thread.id],
  740. 'title': 'Merged thread!',
  741. 'category': self.category.id,
  742. 'poll': 'dsa7dsadsa9789',
  743. }),
  744. content_type="application/json",
  745. )
  746. self.assertEqual(response.status_code, 400)
  747. self.assertEqual(response.json(), {
  748. 'detail': "Invalid choice.",
  749. })
  750. # polls and votes were untouched
  751. self.assertEqual(Poll.objects.count(), 2)
  752. self.assertEqual(PollVote.objects.count(), 8)
  753. def test_threads_merge_conflict_delete_all(self):
  754. """api deletes all polls when delete all choice is selected"""
  755. self.override_acl({'can_merge_threads': True})
  756. other_thread = testutils.post_thread(self.category)
  757. testutils.post_poll(self.thread, self.user)
  758. testutils.post_poll(other_thread, self.user)
  759. response = self.client.post(
  760. self.api_link,
  761. json.dumps({
  762. 'threads': [self.thread.id, other_thread.id],
  763. 'title': 'Merged thread!',
  764. 'category': self.category.id,
  765. 'poll': 0,
  766. }),
  767. content_type="application/json",
  768. )
  769. self.assertEqual(response.status_code, 200)
  770. # polls and votes are gone
  771. self.assertEqual(Poll.objects.count(), 0)
  772. self.assertEqual(PollVote.objects.count(), 0)
  773. def test_threads_merge_conflict_keep_first_poll(self):
  774. """api deletes other poll on merge"""
  775. self.override_acl({'can_merge_threads': True})
  776. other_thread = testutils.post_thread(self.category)
  777. poll = testutils.post_poll(self.thread, self.user)
  778. other_poll = testutils.post_poll(other_thread, self.user)
  779. response = self.client.post(
  780. self.api_link,
  781. json.dumps({
  782. 'threads': [self.thread.id, other_thread.id],
  783. 'title': 'Merged thread!',
  784. 'category': self.category.id,
  785. 'poll': poll.pk,
  786. }),
  787. content_type="application/json",
  788. )
  789. self.assertEqual(response.status_code, 200)
  790. # other poll and its votes are gone
  791. self.assertEqual(Poll.objects.count(), 1)
  792. self.assertEqual(PollVote.objects.count(), 4)
  793. Poll.objects.get(pk=poll.pk)
  794. with self.assertRaises(Poll.DoesNotExist):
  795. Poll.objects.get(pk=other_poll.pk)
  796. def test_threads_merge_conflict_keep_other_poll(self):
  797. """api deletes first poll on merge"""
  798. self.override_acl({'can_merge_threads': True})
  799. other_thread = testutils.post_thread(self.category)
  800. poll = testutils.post_poll(self.thread, self.user)
  801. other_poll = testutils.post_poll(other_thread, self.user)
  802. response = self.client.post(
  803. self.api_link,
  804. json.dumps({
  805. 'threads': [self.thread.id, other_thread.id],
  806. 'title': 'Merged thread!',
  807. 'category': self.category.id,
  808. 'poll': other_poll.pk,
  809. }),
  810. content_type="application/json",
  811. )
  812. self.assertEqual(response.status_code, 200)
  813. # other poll and its votes are gone
  814. self.assertEqual(Poll.objects.count(), 1)
  815. self.assertEqual(PollVote.objects.count(), 4)
  816. Poll.objects.get(pk=other_poll.pk)
  817. with self.assertRaises(Poll.DoesNotExist):
  818. Poll.objects.get(pk=poll.pk)