test_thread_editreply_api.py 16 KB

123456789101112131415161718192021222324252627282930313233343536373839404142434445464748495051525354555657585960616263646566676869707172737475767778798081828384858687888990919293949596979899100101102103104105106107108109110111112113114115116117118119120121122123124125126127128129130131132133134135136137138139140141142143144145146147148149150151152153154155156157158159160161162163164165166167168169170171172173174175176177178179180181182183184185186187188189190191192193194195196197198199200201202203204205206207208209210211212213214215216217218219220221222223224225226227228229230231232233234235236237238239240241242243244245246247248249250251252253254255256257258259260261262263264265266267268269270271272273274275276277278279280281282283284285286287288289290291292293294295296297298299300301302303304305306307308309310311312313314315316317318319320321322323324325326327328329330331332333334335336337338339340341342343344345346347348349350351352353354355356357358359360361362363364365366367368369370371372373374375376377378379380381382383384385386387388389390391392393394395396397398399400401402403404405406407408409410411412413414415416417418419420421422423424425426427428429430431432433434435436437438439440441442443444445446447448449450451452453454455456457458459460461462463464465466467468469470471472473474475476477478479480481482483484485486487488489490491492493494495496497498499500501
  1. # -*- coding: utf-8 -*-
  2. from __future__ import unicode_literals
  3. from django.test.client import BOUNDARY, MULTIPART_CONTENT, encode_multipart
  4. from django.urls import reverse
  5. from misago.acl.testutils import override_acl
  6. from misago.categories.models import Category
  7. from misago.threads import testutils
  8. from misago.threads.models import Post, Thread
  9. from misago.users.testutils import AuthenticatedUserTestCase
  10. class EditReplyTests(AuthenticatedUserTestCase):
  11. def setUp(self):
  12. super(EditReplyTests, self).setUp()
  13. self.category = Category.objects.get(slug='first-category')
  14. self.thread = testutils.post_thread(category=self.category)
  15. self.post = testutils.reply_thread(self.thread, poster=self.user)
  16. self.api_link = reverse(
  17. 'misago:api:thread-post-detail',
  18. kwargs={
  19. 'thread_pk': self.thread.pk,
  20. 'pk': self.post.pk,
  21. }
  22. )
  23. def override_acl(self, extra_acl=None):
  24. new_acl = self.user.acl_cache
  25. new_acl['categories'][self.category.pk].update({
  26. 'can_see': 1,
  27. 'can_browse': 1,
  28. 'can_start_threads': 0,
  29. 'can_reply_threads': 0,
  30. 'can_edit_posts': 1,
  31. })
  32. if extra_acl:
  33. new_acl['categories'][self.category.pk].update(extra_acl)
  34. override_acl(self.user, new_acl)
  35. def put(self, url, data=None):
  36. content = encode_multipart(BOUNDARY, data or {})
  37. return self.client.put(url, content, content_type=MULTIPART_CONTENT)
  38. def test_cant_edit_reply_as_guest(self):
  39. """user has to be authenticated to be able to edit reply"""
  40. self.logout_user()
  41. response = self.put(self.api_link)
  42. self.assertEqual(response.status_code, 403)
  43. def test_thread_visibility(self):
  44. """thread's visibility is validated"""
  45. self.override_acl({'can_see': 0})
  46. response = self.put(self.api_link)
  47. self.assertEqual(response.status_code, 404)
  48. self.override_acl({'can_browse': 0})
  49. response = self.put(self.api_link)
  50. self.assertEqual(response.status_code, 404)
  51. self.override_acl({'can_see_all_threads': 0})
  52. response = self.put(self.api_link)
  53. self.assertEqual(response.status_code, 404)
  54. def test_cant_edit_reply(self):
  55. """permission to edit reply is validated"""
  56. self.override_acl({'can_edit_posts': 0})
  57. response = self.put(self.api_link)
  58. self.assertContains(response, "You can't edit posts in this category.", status_code=403)
  59. def test_cant_edit_other_user_reply(self):
  60. """permission to edit reply by other users is validated"""
  61. self.override_acl({'can_edit_posts': 1})
  62. self.post.poster = None
  63. self.post.save()
  64. response = self.put(self.api_link)
  65. self.assertContains(
  66. response, "You can't edit other users posts in this category.", status_code=403
  67. )
  68. def test_closed_category(self):
  69. """permssion to edit reply in closed category is validated"""
  70. self.override_acl({'can_close_threads': 0})
  71. self.category.is_closed = True
  72. self.category.save()
  73. response = self.put(self.api_link)
  74. self.assertContains(
  75. response, "This category is closed. You can't edit posts in it.", status_code=403
  76. )
  77. # allow to post in closed category
  78. self.override_acl({'can_close_threads': 1})
  79. response = self.put(self.api_link)
  80. self.assertEqual(response.status_code, 400)
  81. def test_closed_thread(self):
  82. """permssion to edit reply in closed thread is validated"""
  83. self.override_acl({'can_close_threads': 0})
  84. self.thread.is_closed = True
  85. self.thread.save()
  86. response = self.put(self.api_link)
  87. self.assertContains(
  88. response, "This thread is closed. You can't edit posts in it.", status_code=403
  89. )
  90. # allow to post in closed thread
  91. self.override_acl({'can_close_threads': 1})
  92. response = self.put(self.api_link)
  93. self.assertEqual(response.status_code, 400)
  94. def test_protected_post(self):
  95. """permssion to edit protected post is validated"""
  96. self.override_acl({'can_protect_posts': 0})
  97. self.post.is_protected = True
  98. self.post.save()
  99. response = self.put(self.api_link)
  100. self.assertContains(
  101. response, "This post is protected. You can't edit it.", status_code=403
  102. )
  103. # allow to post in closed thread
  104. self.override_acl({'can_protect_posts': 1})
  105. response = self.put(self.api_link)
  106. self.assertEqual(response.status_code, 400)
  107. def test_empty_data(self):
  108. """no data sent handling has no showstoppers"""
  109. self.override_acl()
  110. response = self.put(self.api_link, data={})
  111. self.assertEqual(response.status_code, 400)
  112. self.assertEqual(response.json(), {
  113. 'post': ["You have to enter a message."],
  114. })
  115. def test_edit_event(self):
  116. """events can't be edited"""
  117. self.override_acl()
  118. self.post.is_event = True
  119. self.post.save()
  120. response = self.put(self.api_link, data={})
  121. self.assertContains(response, "Events can't be edited.", status_code=403)
  122. def test_post_is_validated(self):
  123. """post is validated"""
  124. self.override_acl()
  125. response = self.put(
  126. self.api_link, data={
  127. 'post': "a",
  128. }
  129. )
  130. self.assertEqual(response.status_code, 400)
  131. self.assertEqual(
  132. response.json(), {
  133. 'post': ["Posted message should be at least 5 characters long (it has 1)."],
  134. }
  135. )
  136. def test_edit_reply_no_change(self):
  137. """endpoint isn't bumping edits count if no change was made to post's body"""
  138. self.override_acl()
  139. self.assertEqual(self.post.edits_record.count(), 0)
  140. response = self.put(self.api_link, data={'post': self.post.original})
  141. self.assertEqual(response.status_code, 200)
  142. self.override_acl()
  143. response = self.client.get(self.thread.get_absolute_url())
  144. self.assertContains(response, self.post.parsed)
  145. post = self.thread.post_set.order_by('id').last()
  146. self.assertEqual(post.edits, 0)
  147. self.assertEqual(post.original, self.post.original)
  148. self.assertIsNone(post.last_editor_id, self.user.id)
  149. self.assertIsNone(post.last_editor_name, self.user.username)
  150. self.assertIsNone(post.last_editor_slug, self.user.slug)
  151. self.assertEqual(self.post.edits_record.count(), 0)
  152. def test_edit_reply(self):
  153. """endpoint updates reply"""
  154. self.override_acl()
  155. self.assertEqual(self.post.edits_record.count(), 0)
  156. response = self.put(self.api_link, data={'post': "This is test edit!"})
  157. self.assertEqual(response.status_code, 200)
  158. self.override_acl()
  159. response = self.client.get(self.thread.get_absolute_url())
  160. self.assertContains(response, "<p>This is test edit!</p>")
  161. post = self.thread.post_set.order_by('id').last()
  162. self.assertEqual(post.edits, 1)
  163. self.assertEqual(post.original, "This is test edit!")
  164. self.assertEqual(post.last_editor_id, self.user.id)
  165. self.assertEqual(post.last_editor_name, self.user.username)
  166. self.assertEqual(post.last_editor_slug, self.user.slug)
  167. self.assertEqual(self.post.edits_record.count(), 1)
  168. post_edit = post.edits_record.last()
  169. self.assertEqual(post_edit.edited_from, self.post.original)
  170. self.assertEqual(post_edit.edited_to, post.original)
  171. self.assertEqual(post_edit.editor_id, self.user.id)
  172. self.assertEqual(post_edit.editor_name, self.user.username)
  173. self.assertEqual(post_edit.editor_slug, self.user.slug)
  174. def test_edit_first_post_hidden(self):
  175. """endpoint updates hidden thread's first post"""
  176. self.override_acl({'can_hide_threads': 1, 'can_edit_posts': 2})
  177. self.thread.is_hidden = True
  178. self.thread.save()
  179. self.thread.first_post.is_hidden = True
  180. self.thread.first_post.save()
  181. api_link = reverse(
  182. 'misago:api:thread-post-detail',
  183. kwargs={
  184. 'thread_pk': self.thread.pk,
  185. 'pk': self.thread.first_post.pk,
  186. }
  187. )
  188. response = self.put(api_link, data={'post': "This is test edit!"})
  189. self.assertEqual(response.status_code, 200)
  190. def test_protect_post(self):
  191. """can protect post"""
  192. self.override_acl({'can_protect_posts': 1})
  193. response = self.put(
  194. self.api_link, data={
  195. 'post': "Lorem ipsum dolor met!",
  196. 'protect': 1,
  197. }
  198. )
  199. self.assertEqual(response.status_code, 200)
  200. post = self.user.post_set.order_by('id').last()
  201. self.assertTrue(post.is_protected)
  202. def test_protect_post_no_permission(self):
  203. """cant protect post without permission"""
  204. self.override_acl({'can_protect_posts': 0})
  205. response = self.put(
  206. self.api_link, data={
  207. 'post': "Lorem ipsum dolor met!",
  208. 'protect': 1,
  209. }
  210. )
  211. self.assertEqual(response.status_code, 200)
  212. post = self.user.post_set.order_by('id').last()
  213. self.assertFalse(post.is_protected)
  214. def test_post_unicode(self):
  215. """unicode characters can be posted"""
  216. self.override_acl()
  217. response = self.put(
  218. self.api_link, data={
  219. 'post': "Chrzążczyżewoszyce, powiat Łękółody.",
  220. }
  221. )
  222. self.assertEqual(response.status_code, 200)
  223. def test_reply_category_moderation_queue(self):
  224. """edit sends reply to queue due to category setup"""
  225. self.category.require_edits_approval = True
  226. self.category.save()
  227. response = self.put(
  228. self.api_link, data={
  229. 'post': "Lorem ipsum dolor met!",
  230. }
  231. )
  232. self.assertEqual(response.status_code, 200)
  233. post = self.user.post_set.all()[:1][0]
  234. self.assertTrue(post.is_unapproved)
  235. def test_reply_category_moderation_queue_bypass(self):
  236. """bypass moderation queue due to user's acl"""
  237. override_acl(self.user, {'can_approve_content': 1})
  238. self.category.require_edits_approval = True
  239. self.category.save()
  240. response = self.put(
  241. self.api_link, data={
  242. 'post': "Lorem ipsum dolor met!",
  243. }
  244. )
  245. self.assertEqual(response.status_code, 200)
  246. post = self.user.post_set.all()[:1][0]
  247. self.assertFalse(post.is_unapproved)
  248. def test_reply_user_moderation_queue(self):
  249. """edit sends reply to queue due to user acl"""
  250. self.override_acl({'require_edits_approval': 1})
  251. response = self.put(
  252. self.api_link, data={
  253. 'post': "Lorem ipsum dolor met!",
  254. }
  255. )
  256. self.assertEqual(response.status_code, 200)
  257. post = self.user.post_set.all()[:1][0]
  258. self.assertTrue(post.is_unapproved)
  259. def test_reply_user_moderation_queue_bypass(self):
  260. """bypass moderation queue due to user's acl"""
  261. override_acl(self.user, {'can_approve_content': 1})
  262. self.override_acl({'require_edits_approval': 1})
  263. response = self.put(
  264. self.api_link, data={
  265. 'post': "Lorem ipsum dolor met!",
  266. }
  267. )
  268. self.assertEqual(response.status_code, 200)
  269. post = self.user.post_set.all()[:1][0]
  270. self.assertFalse(post.is_unapproved)
  271. def test_reply_omit_other_moderation_queues(self):
  272. """other queues are omitted"""
  273. self.category.require_threads_approval = True
  274. self.category.require_replies_approval = True
  275. self.category.save()
  276. self.override_acl({
  277. 'require_threads_approval': 1,
  278. 'require_replies_approval': 1,
  279. })
  280. response = self.put(
  281. self.api_link, data={
  282. 'post': "Lorem ipsum dolor met!",
  283. }
  284. )
  285. self.assertEqual(response.status_code, 200)
  286. post = self.user.post_set.all()[:1][0]
  287. self.assertFalse(post.is_unapproved)
  288. def setUpFirstReplyTest(self):
  289. self.post = self.thread.first_post
  290. self.post.poster = self.user
  291. self.post.save()
  292. self.api_link = reverse(
  293. 'misago:api:thread-post-detail',
  294. kwargs={
  295. 'thread_pk': self.thread.pk,
  296. 'pk': self.post.pk,
  297. }
  298. )
  299. def test_first_reply_category_moderation_queue(self):
  300. """edit sends thread to queue due to category setup"""
  301. self.setUpFirstReplyTest()
  302. self.category.require_edits_approval = True
  303. self.category.save()
  304. response = self.put(
  305. self.api_link, data={
  306. 'post': "Lorem ipsum dolor met!",
  307. }
  308. )
  309. self.assertEqual(response.status_code, 200)
  310. thread = Thread.objects.get(pk=self.thread.pk)
  311. self.assertTrue(thread.is_unapproved)
  312. self.assertTrue(thread.has_unapproved_posts)
  313. post = Post.objects.get(pk=self.post.pk)
  314. self.assertTrue(post.is_unapproved)
  315. def test_first_reply_category_moderation_queue_bypass(self):
  316. """bypass moderation queue due to user's acl"""
  317. self.setUpFirstReplyTest()
  318. override_acl(self.user, {'can_approve_content': 1})
  319. self.category.require_edits_approval = True
  320. self.category.save()
  321. response = self.put(
  322. self.api_link, data={
  323. 'post': "Lorem ipsum dolor met!",
  324. }
  325. )
  326. self.assertEqual(response.status_code, 200)
  327. thread = Thread.objects.get(pk=self.thread.pk)
  328. self.assertFalse(thread.is_unapproved)
  329. self.assertFalse(thread.has_unapproved_posts)
  330. post = Post.objects.get(pk=self.post.pk)
  331. self.assertFalse(post.is_unapproved)
  332. def test_first_reply_user_moderation_queue(self):
  333. """edit sends thread to queue due to user acl"""
  334. self.setUpFirstReplyTest()
  335. self.override_acl({'require_edits_approval': 1})
  336. response = self.put(
  337. self.api_link, data={
  338. 'post': "Lorem ipsum dolor met!",
  339. }
  340. )
  341. self.assertEqual(response.status_code, 200)
  342. thread = Thread.objects.get(pk=self.thread.pk)
  343. self.assertTrue(thread.is_unapproved)
  344. self.assertTrue(thread.has_unapproved_posts)
  345. post = Post.objects.get(pk=self.post.pk)
  346. self.assertTrue(post.is_unapproved)
  347. def test_first_reply_user_moderation_queue_bypass(self):
  348. """bypass moderation queue due to user's acl"""
  349. self.setUpFirstReplyTest()
  350. override_acl(self.user, {'can_approve_content': 1})
  351. self.override_acl({'require_edits_approval': 1})
  352. response = self.put(
  353. self.api_link, data={
  354. 'post': "Lorem ipsum dolor met!",
  355. }
  356. )
  357. self.assertEqual(response.status_code, 200)
  358. thread = Thread.objects.get(pk=self.thread.pk)
  359. self.assertFalse(thread.is_unapproved)
  360. self.assertFalse(thread.has_unapproved_posts)
  361. post = Post.objects.get(pk=self.post.pk)
  362. self.assertFalse(post.is_unapproved)
  363. def test_first_reply_omit_other_moderation_queues(self):
  364. """other queues are omitted"""
  365. self.setUpFirstReplyTest()
  366. self.category.require_threads_approval = True
  367. self.category.require_replies_approval = True
  368. self.category.save()
  369. self.override_acl({
  370. 'require_threads_approval': 1,
  371. 'require_replies_approval': 1,
  372. })
  373. response = self.put(
  374. self.api_link, data={
  375. 'post': "Lorem ipsum dolor met!",
  376. }
  377. )
  378. self.assertEqual(response.status_code, 200)
  379. thread = Thread.objects.get(pk=self.thread.pk)
  380. self.assertFalse(thread.is_unapproved)
  381. self.assertFalse(thread.has_unapproved_posts)
  382. post = Post.objects.get(pk=self.post.pk)
  383. self.assertFalse(post.is_unapproved)