More defensive edits tracker

misago/apps/threadtype/posting/base.py

@@ -22,6 +22,12 @@ class PostingBaseView(ViewBase):
             self.parents = Forum.objects.forum_parents(self.forum.pk)
 
     def record_edit(self, form, old_name, old_post):
+        self.post.edits += 1
+        self.post.edit_date = timezone.now()
+        self.post.edit_user = self.request.user
+        self.post.edit_user_name = self.request.user.username
+        self.post.edit_user_slug = self.request.user.username_slug
+        self.post.save(force_update=True)
         self.post.change_set.create(
                                     forum=self.forum,
                                     thread=self.thread,

misago/apps/threadtype/posting/editreply.py

@@ -20,7 +20,6 @@ class EditReplyBaseView(PostingBaseView):
                 }
 
     def post_form(self, form):
-        now = timezone.now()
         old_post = self.post.post
 
         changed_thread = False
@@ -50,10 +49,5 @@ class EditReplyBaseView(PostingBaseView):
         if changed_post:
             self.post.post = form.cleaned_data['post']
             self.md, self.post.post_preparsed = post_markdown(self.request, form.cleaned_data['post'])
-            self.post.edits += 1
-            self.post.edit_date = now
-            self.post.edit_user = self.request.user
-            self.post.edit_user_name = self.request.user.username
-            self.post.edit_user_slug = self.request.user.username_slug
             self.post.save(force_update=True)
             self.record_edit(form, self.thread.name, old_post)

misago/apps/threadtype/posting/editthread.py

@@ -22,7 +22,6 @@ class EditThreadBaseView(PostingBaseView):
                 }
 
     def post_form(self, form):
-        now = timezone.now()
         old_name = self.thread.name
         old_post = self.post.post
 
@@ -55,11 +54,6 @@ class EditThreadBaseView(PostingBaseView):
         if changed_post:
             self.post.post = form.cleaned_data['post']
             self.md, self.post.post_preparsed = post_markdown(self.request, form.cleaned_data['post'])
-            self.post.edits += 1
-            self.post.edit_date = now
-            self.post.edit_user = self.request.user
-            self.post.edit_user_name = self.request.user.username
-            self.post.edit_user_slug = self.request.user.username_slug
             self.post.save(force_update=True)
 
         if changed_thread or changed_post: