fix #718: moved polyfill requirement detection to frontend

misago/core/context_processors.py

@@ -39,9 +39,3 @@ def frontend_context(request):
         return {'frontend_context': request.frontend_context}
     else:
         return {}
-
-
-def internet_explorer(request):
-    return {
-        'is_ie': 'Trident/' in request.META.get('HTTP_USER_AGENT', '')
-    }

misago/core/tests/test_context_processors.py

@@ -48,67 +48,6 @@ class SiteAddressTests(TestCase):
             })
 
 
-class InternetExplorerTests(TestCase):
-    def test_internet_explorer(self):
-        """frontend_context returns true if user agent contains 'Trident/'"""
-        IE_USERAGENTS = (
-            'Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; Trident/5.0)',
-            'Mozilla/5.0 (compatible; MSIE 9.0; Windows NT 6.1; WOW64; Trident/5.0; SLCC2; Media Center PC 6.0; InfoPath.3; MS-RTC LM 8; Zune 4.7)',
-            'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; Trident/6.0)',
-            'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; WOW64; Trident/6.0)',
-            'Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.2; Win64; x64; Trident/6.0)',
-            'Mozilla/5.0 (IE 11.0; Windows NT 6.3; Trident/7.0; .NET4.0E; .NET4.0C; rv:11.0) like Gecko',
-            'Mozilla/5.0 (IE 11.0; Windows NT 6.3; WOW64; Trident/7.0; Touch; rv:11.0) like Gecko',
-        )
-
-        NONIE_USERAGENTS = (
-            'Mozilla/5.0 (Windows NT 6.4; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/36.0.1985.143 Safari/537.36 Edge/12.0',
-            'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.9600',
-            'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/42.0.2311.135 Safari/537.36 Edge/12.10240',
-            'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2486.0 Safari/537.36 Edge/13.10547',
-            'Mozilla/5.0 (Windows NT 10.0; Win64; x64; Xbox; Xbox One) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/46.0.2486.0 Safari/537.36 Edge/13.10586',
-            'Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/48.0.2564.82 Safari/537.36 Edge/14.14359',
-            'Mozilla/5.0 (Windows; U; Windows NT 5.0; es-ES; rv:1.8.0.3) Gecko/20060426 Firefox/1.5.0.3',
-            'Mozilla/5.0 (Windows; U; WinNT4.0; en-US; rv:1.7.9) Gecko/20050711 Firefox/1.0.5',
-            'Mozilla/5.0 (Windows; Windows NT 6.1; rv:2.0b2) Gecko/20100720 Firefox/4.0b2',
-            'Mozilla/5.0 (X11; Linux x86_64; rv:2.0b4) Gecko/20100818 Firefox/4.0b4',
-            'Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2) Gecko/20100308 Ubuntu/10.04 (lucid) Firefox/3.6 GTB7.1',
-            'Mozilla/5.0 (Linux; Android 4.1; Galaxy Nexus Build/JRN84D) AppleWebKit/535.19 (KHTML, like Gecko) Chrome/18.0.1025.166 Mobile Safari/535.19',
-            'Mozilla/5.0 (iPhone; U; CPU iPhone OS 5_1_1 like Mac OS X; en) AppleWebKit/534.46.0 (KHTML, like Gecko) CriOS/19.0.1084.60 Mobile/9B206 Safari/7534.48.3',
-            'Mozilla/5.0 (iPad; U; CPU OS 5_1_1 like Mac OS X; en-us) AppleWebKit/534.46.0 (KHTML, like Gecko) CriOS/19.0.1084.60 Mobile/9B206 Safari/7534.48.3',
-            'Mozilla/5.0 (iPad; CPU OS 10_2 like Mac OS X) AppleWebKit/602.1.50 (KHTML, like Gecko) CriOS/55.0.2883.79 Mobile/14C92 Safari/602.1',
-            'Mozilla/5.0 (iPad; U; CPU OS 4_3_5 like Mac OS X; de-de) AppleWebKit/533.17.9 (KHTML, like Gecko)',
-            'Mozilla/5.0 (iPhone; CPU iPhone OS 6_0 like Mac OS X) AppleWebKit/536.26 (KHTML, like Gecko) Mobile/10A5376e',
-        )
-
-        for useragent in IE_USERAGENTS:
-            context = context_processors.internet_explorer(MetaMockRequest({
-                'HTTP_USER_AGENT': useragent
-            }))
-
-            self.assertEqual(context, {'is_ie': True})
-
-        for useragent in NONIE_USERAGENTS:
-            context = context_processors.internet_explorer(MetaMockRequest({
-                'HTTP_USER_AGENT': useragent
-            }))
-
-            self.assertEqual(context, {'is_ie': False})
-
-    def test_no_useragent(self):
-        """no user agent causes no error"""
-        context = context_processors.internet_explorer(MetaMockRequest({}))
-        self.assertEqual(context, {'is_ie': False})
-
-    def test_empty_useragent(self):
-        """empty user agent causes no error"""
-        context = context_processors.internet_explorer(MetaMockRequest({
-            'HTTP_USER_AGENT': ''
-        }))
-
-        self.assertEqual(context, {'is_ie': False})
-
-
 class FrontendContextTests(TestCase):
     def test_frontend_context(self):
         """frontend_context is available in templates"""

misago/project_template/project_name/settings.py

@@ -241,7 +241,6 @@ TEMPLATES = [
                 'django.contrib.messages.context_processors.messages',
 
                 'misago.core.context_processors.site_address',
-                'misago.core.context_processors.internet_explorer',
                 'misago.conf.context_processors.settings',
                 'misago.users.context_processors.user_links',
                 'misago.legal.context_processors.legal_links',

misago/templates/misago/base.html

@@ -43,15 +43,19 @@
 
     <div class="modal fade" id="modal-mount" tabindex="-1" role="dialog" aria-labelledby="misago-modal-label"></div>
 
-    {% if is_ie %}
-    <script src="{% static 'misago/js/es2015.js' %}"></script>
-    {% endif %}
-    <script type="text/javascript" src="{% url 'django-i18n' %}"></script>
+    <script src="{% url 'django-i18n' %}"></script>
     {% if LANGUAGE_CODE != "en-us" %}
-    <script type="text/javascript" src="{% url 'moment-i18n' %}"></script>
+    <script src="{% url 'moment-i18n' %}"></script>
     {% endif %}
-    <script type="text/javascript" src="{% static 'misago/js/vendor.js' %}"></script>
-    <script type="text/javascript" src="{% static 'misago/js/misago.js' %}"></script>
+    <script type="text/javascript">
+      if (!(Object.assign && Array.from)) {
+        var polyfill = document.createElement('script');
+        polyfill.src = '{% static "misago/js/es2015.js" %}';
+        document.getElementsByTagName('head')[0].appendChild(polyfill);
+      }
+    </script>
+    <script src="{% static 'misago/js/vendor.js' %}"></script>
+    <script src="{% static 'misago/js/misago.js' %}"></script>
     {% include "misago/scripts.html" %}
     <script type="text/javascript">
       misago.init({{ frontend_context|as_json }});