Browse Source

Tweak test util and fix regressions in misago.users.tests

rafalp 6 years ago
parent
commit
bf157d8645

+ 0 - 4
misago/acl/test.py

@@ -11,10 +11,6 @@ class patch_user_acl(ContextDecorator, ExitStack):
     """Testing utility that patches get_user_acl results
     """Testing utility that patches get_user_acl results
 
 
     Can be used as decorator or context manager.
     Can be used as decorator or context manager.
-    
-    Accepts one or two arguments:
-    - patch_user_acl(acl_patch)
-    - patch_user_acl(user, acl_patch)
 
 
     Patch should be a dict or callable.
     Patch should be a dict or callable.
     """
     """

+ 2 - 2
misago/users/tests/test_user_details_api.py

@@ -55,13 +55,13 @@ class UserDetailsApiTests(AuthenticatedUserTestCase):
         )
         )
 
 
         # moderator has permission to edit details
         # moderator has permission to edit details
-        with patch_user_acl(self.user, {'can_moderate_profile_details': True}):
+        with patch_user_acl({'can_moderate_profile_details': True}):
             response = self.client.get(api_link)
             response = self.client.get(api_link)
             self.assertEqual(response.status_code, 200)
             self.assertEqual(response.status_code, 200)
             self.assertTrue(response.json()['edit'])
             self.assertTrue(response.json()['edit'])
 
 
         # non-moderator has no permission to edit details
         # non-moderator has no permission to edit details
-        with patch_user_acl(self.user, {'can_moderate_profile_details': False}):
+        with patch_user_acl({'can_moderate_profile_details': False}):
             response = self.client.get(api_link)
             response = self.client.get(api_link)
             self.assertEqual(response.status_code, 200)
             self.assertEqual(response.status_code, 200)
             self.assertFalse(response.json()['edit'])
             self.assertFalse(response.json()['edit'])

+ 2 - 2
misago/users/tests/test_user_editdetails_api.py

@@ -44,12 +44,12 @@ class UserEditDetailsApiTests(AuthenticatedUserTestCase):
         )
         )
 
 
         # moderator has permission to edit details
         # moderator has permission to edit details
-        with patch_user_acl(self.user, {'can_moderate_profile_details': True}):
+        with patch_user_acl({'can_moderate_profile_details': True}):
             response = self.client.get(api_link)
             response = self.client.get(api_link)
             self.assertEqual(response.status_code, 200)
             self.assertEqual(response.status_code, 200)
 
 
         # non-moderator has no permission to edit details
         # non-moderator has no permission to edit details
-        with patch_user_acl(self.user, {'can_moderate_profile_details': False}):
+        with patch_user_acl({'can_moderate_profile_details': False}):
             response = self.client.get(api_link)
             response = self.client.get(api_link)
             self.assertEqual(response.status_code, 403)
             self.assertEqual(response.status_code, 403)