Made tests for setup.py util

misago/core/setup.py

@@ -1,23 +1,19 @@
+import re
 import os
 from optparse import OptionParser
 from django.core import management
 
 
-def get_misago_project_template():
-    misago_path = os.path.dirname(os.path.dirname(__file__))
-    return os.path.join(misago_path, 'project_template')
-
+def validate_project_name(parser, project_name):
+    if project_name[0].isdigit():
+        parser.error("project_name cannot start with digit")
 
-def start_misago_project():
-    parser = OptionParser(usage="usage: %prog project_name")
-    (options, args) = parser.parse_args()
-
-    if len(args) != 1:
-        parser.error("project_name must be specified")
-    project_name = args[0]
     if project_name.startswith("-"):
         parser.error("project_name cannot start with '-'")
 
+    if re.search("[^0-9a-zA-Z]", project_name):
+        parser.error("project_name cannot contain special characters")
+
     # Ensure the given directory name doesn't clash with an existing
     # Python package/module.
     try:
@@ -29,6 +25,23 @@ def start_misago_project():
                      "Python module and cannot be used as a project "
                      "name. Please try another name." % project_name)
 
+    return project_name
+
+
+def get_misago_project_template():
+    misago_path = os.path.dirname(os.path.dirname(__file__))
+    return os.path.join(misago_path, 'project_template')
+
+
+def start_misago_project():
+    parser = OptionParser(usage="usage: %prog project_name")
+    (options, args) = parser.parse_args()
+
+    if len(args) != 1:
+        parser.error("project_name must be specified")
+
+    project_name = validate_project_name(parser, args[0])
+
     argv = ['start-misago.py', 'startproject', project_name,
             '--template=%s' % get_misago_project_template()]
 

misago/core/tests/test_setup.py

@@ -0,0 +1,38 @@
+import os
+from django.test import TestCase
+from misago.core import setup
+
+
+class MockParser(object):
+    def error(self, message):
+        raise ValueError(message)
+
+
+class SetupTests(TestCase):
+    def test_validate_project_name(self):
+        """validate_project_name identifies incorrect names correctly"""
+        mock_parser = MockParser()
+
+        with self.assertRaises(ValueError):
+            setup.validate_project_name(mock_parser, '-lorem')
+
+        with self.assertRaises(ValueError):
+            setup.validate_project_name(mock_parser, 'django')
+
+        with self.assertRaises(ValueError):
+            setup.validate_project_name(mock_parser, 'dja-ngo')
+
+        with self.assertRaises(ValueError):
+            setup.validate_project_name(mock_parser, '123')
+
+        self.assertTrue(setup.validate_project_name(mock_parser, 'myforum'))
+        self.assertTrue(setup.validate_project_name(mock_parser, 'myforum123'))
+
+    def test_get_misago_project_template(self):
+        """get_misago_project_template returns correct path to template"""
+        misago_path = os.path.dirname(
+            os.path.dirname(os.path.dirname(__file__)))
+        test_project_path = os.path.join(misago_path, 'project_template')
+
+        self.assertEqual(unicode(setup.get_misago_project_template()),
+                         unicode(test_project_path))