Browse Source

Merge pull request #1128 from rafalp/move-forms-utils-to-admin

Move forms utils to admin
Rafał Pitoń 6 years ago
parent
commit
a6142cf63c
38 changed files with 123 additions and 121 deletions
  1. 1 1
      misago/admin/forms.py
  2. 0 0
      misago/admin/templatetags/__init__.py
  3. 0 0
      misago/admin/templatetags/misago_admin_forms.py
  4. 1 1
      misago/admin/tests/test_forms.py
  5. 88 0
      misago/admin/tests/test_templatetags.py
  6. 1 1
      misago/categories/forms.py
  7. 1 1
      misago/categories/permissions.py
  8. 1 1
      misago/conf/forms.py
  9. 1 87
      misago/core/tests/test_templatetags.py
  10. 1 1
      misago/search/permissions.py
  11. 1 1
      misago/templates/misago/admin/agreements/form.html
  12. 1 1
      misago/templates/misago/admin/agreements/list.html
  13. 1 1
      misago/templates/misago/admin/attachments/list.html
  14. 1 1
      misago/templates/misago/admin/attachmenttypes/form.html
  15. 1 1
      misago/templates/misago/admin/bans/form.html
  16. 1 1
      misago/templates/misago/admin/bans/list.html
  17. 1 1
      misago/templates/misago/admin/categories/form.html
  18. 1 1
      misago/templates/misago/admin/categoryroles/form.html
  19. 1 1
      misago/templates/misago/admin/conf/group.html
  20. 1 1
      misago/templates/misago/admin/datadownloads/form.html
  21. 1 1
      misago/templates/misago/admin/datadownloads/list.html
  22. 1 1
      misago/templates/misago/admin/ranks/form.html
  23. 1 1
      misago/templates/misago/admin/roles/form.html
  24. 1 1
      misago/templates/misago/admin/users/ban.html
  25. 1 1
      misago/templates/misago/admin/users/delete.html
  26. 1 1
      misago/templates/misago/admin/users/edit.html
  27. 1 1
      misago/templates/misago/admin/users/list.html
  28. 1 1
      misago/templates/misago/admin/users/new.html
  29. 1 1
      misago/templates/misago/admin/warnings/form.html
  30. 1 1
      misago/threads/permissions/attachments.py
  31. 1 1
      misago/threads/permissions/bestanswers.py
  32. 1 1
      misago/threads/permissions/polls.py
  33. 1 1
      misago/threads/permissions/privatethreads.py
  34. 1 1
      misago/threads/permissions/threads.py
  35. 1 1
      misago/users/forms/admin.py
  36. 1 1
      misago/users/permissions/account.py
  37. 1 1
      misago/users/permissions/moderation.py
  38. 1 1
      misago/users/permissions/profiles.py

+ 1 - 1
misago/core/forms.py → misago/admin/forms.py

@@ -1,7 +1,7 @@
 from django.forms import DateTimeField, RadioSelect, TypedChoiceField, ValidationError
 from django.forms import DateTimeField, RadioSelect, TypedChoiceField, ValidationError
 from django.utils.translation import ugettext_lazy as _
 from django.utils.translation import ugettext_lazy as _
 
 
-from .utils import parse_iso8601_string
+from misago.core.utils import parse_iso8601_string
 
 
 
 
 class IsoDateTimeField(DateTimeField):
 class IsoDateTimeField(DateTimeField):

+ 0 - 0
misago/admin/templatetags/__init__.py


+ 0 - 0
misago/core/templatetags/misago_forms.py → misago/admin/templatetags/misago_admin_forms.py


+ 1 - 1
misago/core/tests/test_forms.py → misago/admin/tests/test_forms.py

@@ -1,7 +1,7 @@
 from django import forms
 from django import forms
 from django.test import TestCase
 from django.test import TestCase
 
 
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 
 
 
 
 class YesNoForm(forms.Form):
 class YesNoForm(forms.Form):

+ 88 - 0
misago/admin/tests/test_templatetags.py

@@ -0,0 +1,88 @@
+from django import forms
+from django.template import Context, Template, TemplateSyntaxError
+from django.test import TestCase
+
+
+class TestForm(forms.Form):
+    somefield = forms.CharField(label="Hello!", max_length=255)
+
+
+class FormRowTests(TestCase):
+    def setUp(self):
+        self.context = Context({'form': TestForm()})
+
+    def test_form_row_no_args(self):
+        """form_row with no args renders form row"""
+        tpl_content = """
+{% load misago_admin_forms %}
+
+{% form_row form.somefield %}
+"""
+
+        tpl = Template(tpl_content)
+        render = tpl.render(self.context).strip()
+        self.assertIn('id_somefield', render)
+
+    def test_form_row_with_args(self):
+        """form_row with args renders form row"""
+        tpl_content = """
+{% load misago_admin_forms %}
+
+{% form_row form.somefield "col-md-3" "col-md-9" %}
+"""
+
+        tpl = Template(tpl_content)
+        render = tpl.render(self.context).strip()
+
+        self.assertIn('id_somefield', render)
+        self.assertIn('col-md-3', render)
+        self.assertIn('col-md-9', render)
+
+    def test_form_row_with_value_args(self):
+        """form_row with values args renders form row"""
+        tpl_content = """
+{% load misago_admin_forms %}
+
+{% with label="col-md-3" field="col-md-9" %}
+    {% form_row form.somefield label field %}
+{% endwith %}
+"""
+
+        tpl = Template(tpl_content)
+        render = tpl.render(self.context).strip()
+        self.assertIn('id_somefield', render)
+        self.assertIn('col-md-3', render)
+        self.assertIn('col-md-9', render)
+
+    def test_form_row_with_no_args(self):
+        """form_row with no args raises exception"""
+        tpl_content = """
+{% load misago_admin_forms %}
+
+{% form_row %}
+"""
+
+        with self.assertRaises(TemplateSyntaxError):
+            Template(tpl_content)
+
+    def test_form_row_with_two_args(self):
+        """form_row with two args raises exception"""
+        tpl_content = """
+{% load misago_admin_forms %}
+
+{% form_row form.somefield "col-md-9" %}
+"""
+
+        with self.assertRaises(TemplateSyntaxError):
+            Template(tpl_content)
+
+    def test_form_row_with_four_args(self):
+        """form_row with four args raises exception"""
+        tpl_content = """
+{% load misago_admin_forms %}
+
+{% form_row form.somefield "col-md-9" "col-md-9" "col-md-9" %}
+"""
+
+        with self.assertRaises(TemplateSyntaxError):
+            Template(tpl_content)

+ 1 - 1
misago/categories/forms.py

@@ -5,7 +5,7 @@ from django.db import models
 from django.utils.html import conditional_escape, mark_safe
 from django.utils.html import conditional_escape, mark_safe
 from django.utils.translation import ugettext_lazy as _
 from django.utils.translation import ugettext_lazy as _
 
 
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 from misago.core.validators import validate_sluggable
 from misago.core.validators import validate_sluggable
 from misago.threads.threadtypes import trees_map
 from misago.threads.threadtypes import trees_map
 
 

+ 1 - 1
misago/categories/permissions.py

@@ -6,7 +6,7 @@ from django.utils.translation import ugettext_lazy as _
 
 
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.decorators import return_boolean
 from misago.acl.decorators import return_boolean
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 from misago.users.models import AnonymousUser
 from misago.users.models import AnonymousUser
 
 
 from .models import Category, CategoryRole, RoleCategoryACL
 from .models import Category, CategoryRole, RoleCategoryACL

+ 1 - 1
misago/conf/forms.py

@@ -2,7 +2,7 @@ from django import forms
 from django.utils.translation import ugettext as _
 from django.utils.translation import ugettext as _
 from django.utils.translation import ungettext
 from django.utils.translation import ungettext
 
 
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 
 
 
 
 __ALL__ = ['ChangeSettingsForm']
 __ALL__ = ['ChangeSettingsForm']

+ 1 - 87
misago/core/tests/test_templatetags.py

@@ -1,5 +1,4 @@
-from django import forms
-from django.template import Context, Template, TemplateSyntaxError
+from django.template import Context, Template
 from django.test import TestCase, override_settings
 from django.test import TestCase, override_settings
 
 
 from misago.core.templatetags import misago_batch
 from misago.core.templatetags import misago_batch
@@ -102,91 +101,6 @@ class BatchTests(TestCase):
             self.assertEqual(test_yield, yields[i])
             self.assertEqual(test_yield, yields[i])
 
 
 
 
-class TestForm(forms.Form):
-    somefield = forms.CharField(label="Hello!", max_length=255)
-
-
-class FormRowTests(TestCase):
-    def setUp(self):
-        self.context = Context({'form': TestForm()})
-
-    def test_form_row_no_args(self):
-        """form_row with no args renders form row"""
-        tpl_content = """
-{% load misago_forms %}
-
-{% form_row form.somefield %}
-"""
-
-        tpl = Template(tpl_content)
-        render = tpl.render(self.context).strip()
-        self.assertIn('id_somefield', render)
-
-    def test_form_row_with_args(self):
-        """form_row with args renders form row"""
-        tpl_content = """
-{% load misago_forms %}
-
-{% form_row form.somefield "col-md-3" "col-md-9" %}
-"""
-
-        tpl = Template(tpl_content)
-        render = tpl.render(self.context).strip()
-
-        self.assertIn('id_somefield', render)
-        self.assertIn('col-md-3', render)
-        self.assertIn('col-md-9', render)
-
-    def test_form_row_with_value_args(self):
-        """form_row with values args renders form row"""
-        tpl_content = """
-{% load misago_forms %}
-
-{% with label="col-md-3" field="col-md-9" %}
-    {% form_row form.somefield label field %}
-{% endwith %}
-"""
-
-        tpl = Template(tpl_content)
-        render = tpl.render(self.context).strip()
-        self.assertIn('id_somefield', render)
-        self.assertIn('col-md-3', render)
-        self.assertIn('col-md-9', render)
-
-    def test_form_row_with_no_args(self):
-        """form_row with no args raises exception"""
-        tpl_content = """
-{% load misago_forms %}
-
-{% form_row %}
-"""
-
-        with self.assertRaises(TemplateSyntaxError):
-            Template(tpl_content)
-
-    def test_form_row_with_two_args(self):
-        """form_row with two args raises exception"""
-        tpl_content = """
-{% load misago_forms %}
-
-{% form_row form.somefield "col-md-9" %}
-"""
-
-        with self.assertRaises(TemplateSyntaxError):
-            Template(tpl_content)
-
-    def test_form_row_with_four_args(self):
-        """form_row with four args raises exception"""
-        tpl_content = """
-{% load misago_forms %}
-
-{% form_row form.somefield "col-md-9" "col-md-9" "col-md-9" %}
-"""
-
-        with self.assertRaises(TemplateSyntaxError):
-            Template(tpl_content)
-
-
 class MockUser(object):
 class MockUser(object):
     id = 12
     id = 12
     pk = 12
     pk = 12

+ 1 - 1
misago/search/permissions.py

@@ -3,7 +3,7 @@ from django.utils.translation import ugettext_lazy as _
 
 
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.models import Role
 from misago.acl.models import Role
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 
 
 
 
 class PermissionsForm(forms.Form):
 class PermissionsForm(forms.Form):

+ 1 - 1
misago/templates/misago/admin/agreements/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/agreements/list.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/list.html" %}
 {% extends "misago/admin/generic/list.html" %}
-{% load i18n misago_capture misago_forms %}
+{% load i18n misago_capture misago_admin_forms %}
 
 
 
 
 {% block page-actions %}
 {% block page-actions %}

+ 1 - 1
misago/templates/misago/admin/attachments/list.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/list.html" %}
 {% extends "misago/admin/generic/list.html" %}
-{% load i18n misago_capture misago_forms %}
+{% load i18n misago_capture misago_admin_forms %}
 
 
 
 
 {% block table-header %}
 {% block table-header %}

+ 1 - 1
misago/templates/misago/admin/attachmenttypes/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/bans/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/bans/list.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/list.html" %}
 {% extends "misago/admin/generic/list.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block page-actions %}
 {% block page-actions %}

+ 1 - 1
misago/templates/misago/admin/categories/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/categoryroles/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/conf/group.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/conf/index.html" %}
 {% extends "misago/admin/conf/index.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}{% trans active_group.name %} | {{ block.super }}{% endblock %}
 {% block title %}{% trans active_group.name %} | {{ block.super }}{% endblock %}

+ 1 - 1
misago/templates/misago/admin/datadownloads/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/datadownloads/list.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/list.html" %}
 {% extends "misago/admin/generic/list.html" %}
-{% load i18n misago_avatars misago_forms %}
+{% load i18n misago_avatars misago_admin_forms %}
 
 
 
 
 {% block page-actions %}
 {% block page-actions %}

+ 1 - 1
misago/templates/misago/admin/ranks/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/roles/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/users/ban.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_avatars misago_capture misago_forms %}
+{% load i18n misago_avatars misago_capture misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/users/delete.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_avatars misago_capture misago_forms %}
+{% load i18n misago_avatars misago_capture misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/users/edit.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/users/list.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/list.html" %}
 {% extends "misago/admin/generic/list.html" %}
-{% load i18n misago_avatars misago_forms %}
+{% load i18n misago_avatars misago_admin_forms %}
 
 
 
 
 {% block page-actions %}
 {% block page-actions %}

+ 1 - 1
misago/templates/misago/admin/users/new.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/templates/misago/admin/warnings/form.html

@@ -1,5 +1,5 @@
 {% extends "misago/admin/generic/form.html" %}
 {% extends "misago/admin/generic/form.html" %}
-{% load i18n misago_forms %}
+{% load i18n misago_admin_forms %}
 
 
 
 
 {% block title %}
 {% block title %}

+ 1 - 1
misago/threads/permissions/attachments.py

@@ -3,7 +3,7 @@ from django.utils.translation import ugettext_lazy as _
 
 
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.models import Role
 from misago.acl.models import Role
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 from misago.threads.models import Attachment
 from misago.threads.models import Attachment
 
 
 
 

+ 1 - 1
misago/threads/permissions/bestanswers.py

@@ -5,9 +5,9 @@ from django.utils.translation import ugettext_lazy as _, ungettext
 
 
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.decorators import return_boolean
 from misago.acl.decorators import return_boolean
+from misago.admin.forms import YesNoSwitch
 from misago.categories.models import Category, CategoryRole
 from misago.categories.models import Category, CategoryRole
 from misago.categories.permissions import get_categories_roles
 from misago.categories.permissions import get_categories_roles
-from misago.core.forms import YesNoSwitch
 from misago.threads.models import Post, Thread
 from misago.threads.models import Post, Thread
 
 
 
 

+ 1 - 1
misago/threads/permissions/polls.py

@@ -7,7 +7,7 @@ from django.utils.translation import ungettext
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.decorators import return_boolean
 from misago.acl.decorators import return_boolean
 from misago.acl.models import Role
 from misago.acl.models import Role
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 from misago.threads.models import Poll, Thread
 from misago.threads.models import Poll, Thread
 
 
 
 

+ 1 - 1
misago/threads/permissions/privatethreads.py

@@ -6,9 +6,9 @@ from django.utils.translation import ugettext_lazy as _
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.decorators import return_boolean
 from misago.acl.decorators import return_boolean
 from misago.acl.models import Role
 from misago.acl.models import Role
+from misago.admin.forms import YesNoSwitch
 from misago.categories import PRIVATE_THREADS_ROOT_NAME
 from misago.categories import PRIVATE_THREADS_ROOT_NAME
 from misago.categories.models import Category
 from misago.categories.models import Category
-from misago.core.forms import YesNoSwitch
 from misago.threads.models import Thread
 from misago.threads.models import Thread
 
 
 
 

+ 1 - 1
misago/threads/permissions/threads.py

@@ -8,9 +8,9 @@ from django.utils.translation import ugettext_lazy as _, ungettext
 from misago.acl import add_acl, algebra
 from misago.acl import add_acl, algebra
 from misago.acl.decorators import return_boolean
 from misago.acl.decorators import return_boolean
 from misago.acl.models import Role
 from misago.acl.models import Role
+from misago.admin.forms import YesNoSwitch
 from misago.categories.models import Category, CategoryRole
 from misago.categories.models import Category, CategoryRole
 from misago.categories.permissions import get_categories_roles
 from misago.categories.permissions import get_categories_roles
-from misago.core.forms import YesNoSwitch
 from misago.threads.models import Post, Thread
 from misago.threads.models import Post, Thread
 
 
 
 

+ 1 - 1
misago/users/forms/admin.py

@@ -6,9 +6,9 @@ from django.utils.translation import ugettext_lazy as _
 from django.utils.translation import ungettext
 from django.utils.translation import ungettext
 
 
 from misago.acl.models import Role
 from misago.acl.models import Role
+from misago.admin.forms import IsoDateTimeField, YesNoSwitch
 from misago.conf import settings
 from misago.conf import settings
 from misago.core import threadstore
 from misago.core import threadstore
-from misago.core.forms import IsoDateTimeField, YesNoSwitch
 from misago.core.validators import validate_sluggable
 from misago.core.validators import validate_sluggable
 from misago.users.models import Ban, DataDownload, Rank
 from misago.users.models import Ban, DataDownload, Rank
 from misago.users.profilefields import profilefields
 from misago.users.profilefields import profilefields

+ 1 - 1
misago/users/permissions/account.py

@@ -3,7 +3,7 @@ from django.utils.translation import ugettext_lazy as _
 
 
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.models import Role
 from misago.acl.models import Role
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 
 
 
 
 class PermissionsForm(forms.Form):
 class PermissionsForm(forms.Form):

+ 1 - 1
misago/users/permissions/moderation.py

@@ -10,7 +10,7 @@ from django.utils.translation import ugettext_lazy as _
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.decorators import return_boolean
 from misago.acl.decorators import return_boolean
 from misago.acl.models import Role
 from misago.acl.models import Role
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 from misago.users.bans import get_user_ban
 from misago.users.bans import get_user_ban
 
 
 
 

+ 1 - 1
misago/users/permissions/profiles.py

@@ -6,7 +6,7 @@ from django.utils.translation import ugettext_lazy as _
 from misago.acl import algebra
 from misago.acl import algebra
 from misago.acl.decorators import return_boolean
 from misago.acl.decorators import return_boolean
 from misago.acl.models import Role
 from misago.acl.models import Role
-from misago.core.forms import YesNoSwitch
+from misago.admin.forms import YesNoSwitch
 
 
 from .decorators import authenticated_only
 from .decorators import authenticated_only