Readd default disables to pylint

.pylintrc

@@ -10,7 +10,9 @@ max-line-length=88
 disable=
     abstract-method,
     arguments-differ,
+    attribute-defined-outside-init,
     bad-continuation,
+    duplicate-code,
     expression-not-assigned,
     fixme,
     inconsistent-return-statements,
@@ -18,6 +20,7 @@ disable=
     missing-docstring,
     no-member,
     no-self-use,
+    protected-access,
     redefined-outer-name,
     too-few-public-methods,
     too-many-ancestors,

.travis.yml

@@ -24,4 +24,4 @@ jobs:
         - pip install black pylint pylint-django
       script:
         - black --check devproject misago
-        - pylint misago/acl misago/admin misago/cache
+        - pylint misago/acl misago/admin misago/cache misago/conf misago/core

misago/acl/tests/test_providers.py

@@ -1,4 +1,3 @@
-# pylint: disable=protected-access
 import pytest
 
 from ...conf import settings

misago/cache/test.py

@@ -4,7 +4,6 @@ from .versions import get_cache_versions_from_db
 class assert_invalidates_cache:
     def __init__(self, cache):
         self.cache = cache
-        self.versions = None
 
     def __enter__(self):
         self.versions = get_cache_versions_from_db()

misago/core/apipatch.py

@@ -50,8 +50,7 @@ class ApiPatch:
         patch["detail"] = detail
         if is_errored:
             return Response(patch, status=400)
-        else:
-            return Response(patch)
+        return Response(patch)
 
     def dispatch_bulk(self, request, targets):
         is_errored = False
@@ -79,8 +78,7 @@ class ApiPatch:
 
         if is_errored:
             return Response(result, status=400)
-        else:
-            return Response(result)
+        return Response(result)
 
     def validate_action(self, action):
         if not action.get("op"):

misago/core/context_processors.py

@@ -44,5 +44,4 @@ def momentjs_locale(request):
 def frontend_context(request):
     if request.include_frontend_context:
         return {"frontend_context": request.frontend_context}
-    else:
-        return {}
+    return {}

misago/core/decorators.py

@@ -7,8 +7,7 @@ def ajax_only(f):
     def decorator(request, *args, **kwargs):
         if not request.is_ajax():
             return not_allowed(request)
-        else:
-            return f(request, *args, **kwargs)
+        return f(request, *args, **kwargs)
 
     return decorator
 
@@ -17,8 +16,7 @@ def require_POST(f):
     def decorator(request, *args, **kwargs):
         if not request.method == "POST":
             return not_allowed(request)
-        else:
-            return f(request, *args, **kwargs)
+        return f(request, *args, **kwargs)
 
     return decorator
 

misago/core/errorpages.py

@@ -40,15 +40,13 @@ def banned(request, exception):
 def permission_denied(request, exception):
     if request.is_ajax():
         return _ajax_error(403, exception, _("Permission denied."))
-    else:
-        return _error_page(request, 403, exception)
+    return _error_page(request, 403, exception)
 
 
 def page_not_found(request, exception):
     if request.is_ajax():
         return _ajax_error(404, exception, "Not found.")
-    else:
-        return _error_page(request, 404, exception)
+    return _error_page(request, 404, exception)
 
 
 def social_auth_failed(request, exception):
@@ -61,6 +59,7 @@ def social_auth_failed(request, exception):
         backend_name = exception.backend_name
     except AttributeError:
         pass
+
     try:
         exception_backend = exception.backend
         backend_name = get_social_auth_backend_name(exception_backend.name)
@@ -69,7 +68,8 @@ def social_auth_failed(request, exception):
 
     if isinstance(exception, social_exceptions.NotAllowedToDisconnect):
         message = _(
-            "A problem was encountered when disconnecting your account from the remote site."
+            "A problem was encountered when disconnecting your account "
+            "from the remote site."
         )
         help_text = _(
             "You are not allowed to disconnect your account from the other site, "
@@ -108,10 +108,10 @@ def social_auth_failed(request, exception):
 def csrf_failure(request, reason=""):
     if request.is_ajax():
         return _ajax_error(403, _("Request authentication is invalid."))
-    else:
-        response = render(request, "misago/errorpages/csrf_failure.html")
-        response.status_code = 403
-        return response
+
+    response = render(request, "misago/errorpages/csrf_failure.html")
+    response.status_code = 403
+    return response
 
 
 def not_allowed(request):
@@ -123,8 +123,7 @@ def shared_403_exception_handler(f):
     def page_decorator(request, *args, **kwargs):
         if is_request_to_misago(request):
             return permission_denied(request, *args, **kwargs)
-        else:
-            return f(request, *args, **kwargs)
+        return f(request, *args, **kwargs)
 
     return page_decorator
 
@@ -133,7 +132,6 @@ def shared_404_exception_handler(f):
     def page_decorator(request, *args, **kwargs):
         if is_request_to_misago(request):
             return page_not_found(request, *args, **kwargs)
-        else:
-            return f(request, *args, **kwargs)
+        return f(request, *args, **kwargs)
 
     return page_decorator

misago/core/exceptionhandler.py

@@ -83,8 +83,7 @@ def get_exception_handler(exception):
     for exception_type, handler in EXCEPTION_HANDLERS:
         if isinstance(exception, exception_type):
             return handler
-    else:
-        raise ValueError("%s is not Misago exception" % exception.__class__.__name__)
+    raise ValueError("%s is not a Misago exception" % exception.__class__.__name__)
 
 
 def handle_misago_exception(request, exception):
@@ -103,5 +102,4 @@ def handle_api_exception(exception, context):
             except IndexError:
                 pass
         return response
-    else:
-        return None
+    return None

misago/core/exceptions.py

@@ -1,3 +1,4 @@
+# pylint: disable=super-init-not-called
 from django.core.exceptions import PermissionDenied
 from social_core.exceptions import AuthException
 
@@ -35,10 +36,6 @@ class SocialAuthBanned(AuthException):
 class ExplicitFirstPage(Exception):
     """The url that was used to reach view contained explicit first page"""
 
-    pass
-
 
 class OutdatedSlug(Exception):
     """The url that was used to reach view contained outdated slug"""
-
-    pass

misago/core/middleware.py

@@ -11,8 +11,6 @@ class ExceptionHandlerMiddleware(MiddlewareMixin):
 
         if request_is_to_misago and misago_can_handle_exception:
             return exceptionhandler.handle_misago_exception(request, exception)
-        else:
-            return None
 
 
 class FrontendContextMiddleware(MiddlewareMixin):

misago/core/page.py

@@ -22,7 +22,10 @@ class Page:
         while self._unsorted_list:
             iterations += 1
             if iterations > 512:
-                message = "%s page hierarchy is invalid or too complex  to resolve. Sections left: %s"
+                message = (
+                    "%s page hierarchy is invalid or too complex to resolve. "
+                    "Sections left: %s"
+                )
                 raise ValueError(message % self._unsorted_list)
 
             for index, section in enumerate(self._unsorted_list):
@@ -50,9 +53,9 @@ class Page:
                     new_sorted_list.append(inserted_section)
                     self._sorted_list = new_sorted_list
                     return True
-            else:
-                return False
-        elif before:
+            return False
+
+        if before:
             new_sorted_list = []
             for section in self._sorted_list:
                 if section["link"] == before:
@@ -60,13 +63,11 @@ class Page:
                     new_sorted_list.append(section)
                     self._sorted_list = new_sorted_list
                     return True
-                else:
-                    new_sorted_list.append(section)
-            else:
-                return False
-        else:
-            self._sorted_list.append(inserted_section)
-            return True
+                new_sorted_list.append(section)
+            return False
+
+        self._sorted_list.append(inserted_section)
+        return True
 
     def add_section(
         self,

misago/core/pgutils.py

@@ -1,4 +1,3 @@
-from django.core.paginator import Paginator
 from django.db.models import Index
 
 
@@ -6,11 +5,13 @@ class PgPartialIndex(Index):
     suffix = "part"
     max_name_length = 31
 
-    def __init__(self, fields=[], name=None, where=None):
+    def __init__(self, fields=None, name=None, where=None):
         if not where:
             raise ValueError("partial index requires WHERE clause")
         self.where = where
 
+        fields = fields or []
+
         super().__init__(fields, name)
 
     def set_name_with_model(self, model):
@@ -37,18 +38,18 @@ class PgPartialIndex(Index):
         self.check_name()
 
     def __repr__(self):
-        if self.where is not None:
-            where_items = []
-            for key in sorted(self.where.keys()):
-                where_items.append("=".join([key, repr(self.where[key])]))
-            return "<%(name)s: fields=%(fields)s, where=%(where)s>" % {
-                "name": self.__class__.__name__,
-                "fields": "'%s'" % (", ".join(self.fields)),
-                "where": "'%s'" % (", ".join(where_items)),
-            }
-        else:
+        if self.where is None:
             return super().__repr__()
 
+        where_items = []
+        for key in sorted(self.where.keys()):
+            where_items.append("=".join([key, repr(self.where[key])]))
+        return "<%(name)s: fields=%(fields)s, where=%(where)s>" % {
+            "name": self.__class__.__name__,
+            "fields": "'%s'" % (", ".join(self.fields)),
+            "where": "'%s'" % (", ".join(where_items)),
+        }
+
     def deconstruct(self):
         path, args, kwargs = super().deconstruct()
         kwargs["where"] = self.where

misago/core/shortcuts.py

@@ -16,7 +16,7 @@ def paginate(
 
     if page in (1, "1") and not allow_explicit_first_page:
         raise ExplicitFirstPage()
-    elif not page:
+    if not page:
         page = 1
 
     paginator = paginator or Paginator
@@ -85,5 +85,4 @@ def validate_slug(model, slug):
 def get_int_or_404(value):
     if str(value).isdigit():
         return int(value)
-    else:
-        raise Http404()
+    raise Http404()

misago/core/testproject/urlswitherrorhandlers.py

@@ -1,4 +1,4 @@
-from .urls import *
+from .urls import *  # pylint: disable=wildcard-import, unused-wildcard-import
 
 handler403 = "misago.core.testproject.views.mock_custom_403_error_page"
 handler404 = "misago.core.testproject.views.mock_custom_404_error_page"

misago/core/tests/test_errorpages.py

@@ -66,7 +66,7 @@ class ErrorPageViewsTests(TestCase):
         self.assertContains(response, "page-error-social", status_code=403)
 
     def test_social_failed_message(self):
-        """misago-specific social auth failed exception error page returns 403 with message"""
+        """misago-specific social auth failed error page returns 403 with message"""
         response = self.client.get(reverse("raise-social-auth-failed-message"))
         self.assertContains(response, "page-error-social", status_code=403)
         self.assertContains(
@@ -74,7 +74,7 @@ class ErrorPageViewsTests(TestCase):
         )
 
     def test_social_auth_banned(self):
-        """misago-specific social auth banned exception error page returns 403 with ban message"""
+        """misago-specific social auth banned error page returns 403 with ban message"""
         response = self.client.get(reverse("raise-social-auth-banned"))
         self.assertContains(response, "page-error-social", status_code=403)
         self.assertContains(response, "Banned in auth!", status_code=403)

misago/core/tests/test_jsi18n.py

@@ -30,7 +30,7 @@ class JsI18nUrlTests(TestCase):
                     response = self.client.get(reverse("django-i18n"))
                     if response.status_code != 200:
                         failed_languages.append(language)
-            except:
+            except:  # pylint: disable=bare-except
                 failed_languages.append(language)
 
         if failed_languages:

misago/core/tests/test_utils.py

@@ -95,7 +95,13 @@ PLAINTEXT_FORMAT_CASES = [
     ("Lorem ipsum.\n\nDolor met.", "<p>Lorem ipsum.</p>\n\n<p>Dolor met.</p>"),
     (
         "http://misago-project.org/login/",
-        '<p><a href="http://misago-project.org/login/">http://misago-project.org/login/</a></p>',
+        (
+            '<p>'
+            '<a href="http://misago-project.org/login/">'
+            'http://misago-project.org/login/'
+            '</a>'
+            '</p>'
+        ),
     ),
 ]
 

misago/core/utils.py

@@ -28,13 +28,13 @@ def parse_iso8601_string(value):
     """turns ISO 8601 string into datetime object"""
     value = force_text(value, strings_only=True).rstrip("Z")
 
-    for format in ISO8601_FORMATS:
+    for format_str in ISO8601_FORMATS:
         try:
-            parsed_value = datetime.strptime(value, format)
+            parsed_value = datetime.strptime(value, format_str)
             break
         except ValueError:
             try:
-                parsed_value = datetime.strptime(value[:-6], format)
+                parsed_value = datetime.strptime(value[:-6], format_str)
                 break
             except ValueError:
                 pass
@@ -67,8 +67,7 @@ def clean_return_path(request):
     """return path utility that returns return path from referer or POST"""
     if request.method == "POST" and "return_path" in request.POST:
         return _get_return_path_from_post(request)
-    else:
-        return _get_return_path_from_referer(request)
+    return _get_return_path_from_referer(request)
 
 
 def _get_return_path_from_post(request):