Browse Source

Fix tests

rafalp 6 years ago
parent
commit
96fb2143ac

+ 1 - 1
misago/users/activepostersranking.py

@@ -42,8 +42,8 @@ def build_active_posters_ranking():
 
     queryset = (
         UserModel.objects
-        .filter(is_active=True)
         .annotate(score=Count('post', filter=ranked_posts))
+        .filter(is_active=True, score__gt=0)
         .order_by('-score')
     )[:settings.MISAGO_RANKING_SIZE]
 

+ 0 - 6
misago/users/tests/test_activepostersranking.py

@@ -38,9 +38,6 @@ class TestActivePostersRanking(AuthenticatedUserTestCase):
         # other user
         other_user = UserModel.objects.create_user("OtherUser", "other@user.com", "pass123")
 
-        other_user.posts = 1
-        other_user.save()
-
         post_thread(self.category, poster=other_user)
 
         build_active_posters_ranking()
@@ -53,9 +50,6 @@ class TestActivePostersRanking(AuthenticatedUserTestCase):
         post_thread(self.category, poster=self.user)
         post_thread(self.category, poster=self.user)
 
-        self.user.posts = 2
-        self.user.save()
-
         build_active_posters_ranking()
         ranking = get_active_posters_ranking()