Browse Source

Simplify tests assertions

rafalp 6 years ago
parent
commit
5f1ebd3881
1 changed files with 21 additions and 52 deletions
  1. 21 52
      misago/admin/tests/test_admin_form_templatetags.py

+ 21 - 52
misago/admin/tests/test_admin_form_templatetags.py

@@ -4,68 +4,37 @@ from django.test import TestCase
 
 
 
 
 class TestForm(forms.Form):
 class TestForm(forms.Form):
-    somefield = forms.CharField(label="Hello!", max_length=255)
+    text_field = forms.CharField(label="Hello!", max_length=255)
 
 
 
 
-class FormRowTests(TestCase):
-    def setUp(self):
-        self.context = Context({'form': TestForm()})
-
-    def test_tag_renders_row_with_field(self):
-        tpl_content = """
-{% load misago_admin_form %}
+def render(template_str):
+    base_template = "{%% load misago_admin_form %%} %s"
+    context = Context({'form': TestForm()})
+    template = Template(base_template % template_str)
+    return template.render(context).strip()
 
 
-{% form_row form.somefield %}
-"""
 
 
-        tpl = Template(tpl_content)
-        render = tpl.render(self.context).strip()
-        self.assertIn('id_somefield', render)
+class FormRowTests(TestCase):
+    def test_tag_renders_row_with_field(self):
+        html = render("{% form_row form.text_field %}")
+        self.assertIn('id_text_field', html)
 
 
     def test_tag_with_label_class_option_renders_row_including_css_class(self):
     def test_tag_with_label_class_option_renders_row_including_css_class(self):
-        tpl_content = """
-{% load misago_admin_form %}
-
-{% form_row form.somefield label_class="col-md-3" %}
-"""
-
-        tpl = Template(tpl_content)
-        render = tpl.render(self.context).strip()
-        self.assertIn('id_somefield', render)
-        self.assertIn('col-md-3', render)
+        html = render('{% form_row form.text_field label_class="col-md-3" %}')
+        self.assertIn('id_text_field', html)
+        self.assertIn('col-md-3', html)
 
 
     def test_tag_with_field_class_option_renders_row_including_css_class(self):
     def test_tag_with_field_class_option_renders_row_including_css_class(self):
-        tpl_content = """
-{% load misago_admin_form %}
-
-{% form_row form.somefield field_class="col-md-9" %}
-"""
-
-        tpl = Template(tpl_content)
-        render = tpl.render(self.context).strip()
-        self.assertIn('id_somefield', render)
-        self.assertIn('col-md-9', render)
+        html = render('{% form_row form.text_field field_class="col-md-9" %}')
+        self.assertIn('id_text_field', html)
+        self.assertIn('col-md-9', html)
 
 
     def test_tag_with_label_and_control_options_renders_row_including_both_css_classes(self):
     def test_tag_with_label_and_control_options_renders_row_including_both_css_classes(self):
-        tpl_content = """
-{% load misago_admin_form %}
-
-{% form_row form.somefield "col-md-3" "col-md-9" %}
-"""
-
-        tpl = Template(tpl_content)
-        render = tpl.render(self.context).strip()
-
-        self.assertIn('id_somefield', render)
-        self.assertIn('col-md-3', render)
-        self.assertIn('col-md-9', render)
+        html = render('{% form_row form.text_field "col-md-3" "col-md-9" %}')
+        self.assertIn('id_text_field', html)
+        self.assertIn('col-md-3', html)
+        self.assertIn('col-md-9', html)
 
 
     def test_tag_without_field_raises_exception(self):
     def test_tag_without_field_raises_exception(self):
-        tpl_content = """
-{% load misago_admin_form %}
-
-{% form_row %}
-"""
-
         with self.assertRaises(TemplateSyntaxError):
         with self.assertRaises(TemplateSyntaxError):
-            Template(tpl_content)
+            render('{% form_row %}')